www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: SCP upload failure

Re: SCP upload failure

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sun, 30 Aug 2009 23:55:47 +0200 (CEST)

On Fri, 28 Aug 2009, Daniel Stenberg wrote:

>> Oh to add to this, the corruption only happened when I was using a buffer
>> size larger than what libssh2's write packet size limit was (32*1024 I
>> believe was the limit) it would say it was splitting up the writes, I had
>> it set to 128*1024 for buffer size. Once I set it to 32*1024 or lower I no
>> longer had files corrupting when going to this OS X server.
>
> I think it could be an even more basic error because lots of code in libssh2
> takes the passed in size, allocates that big of packet and sends that off.

I've now made libssh2_channel_write_ex() deal with larger than 32K sizes by
simply ignoring everything beyond 32K. Since it returns the number of bytes it
sends it shouldn't cause any particular problems for existing apps.

-- 
  / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2009-08-30

the libssh2 team