www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: [PATCH] Support for exit-signal messages

Re: [PATCH] Support for exit-signal messages

From: Simon Josefsson <simon_at_josefsson.org>
Date: Fri, 01 Oct 2010 18:21:18 +0200

Tommy Lindgren <tommy.lindgren_at_gmail.com> writes:

> On 2010-10-01 16:29, Simon Josefsson wrote:
>> Tommy Lindgren<tommy.lindgren_at_gmail.com> writes:
>>
>>> Hi,
>>>
>>> I've implemented rudimentary support for exit-signal messages (see RFC
>>> 4254 section 6.10) which I'd like to see included in libssh2, please
>>> see attached patch. The patch only adds support for retrieving the
>>> signal name, I skipped the part about the (optional) error message.
>>
>> It looks good to me, thanks for this! However a question: why skip the
>> error message part?
>
> Simply because the error message didn't seem to get set in my test
> cases, so I didn't bother to write code for it.

I think it would be an improvement if the API was modified to make it
possible for a future libssh2 to supply the error message to the
application, when someone improves the protocol parser.

Btw, shouldn't the return value of the API use a 'const' qualifier? The
string should not be modifiable by the application.

/Simon
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-10-01

the libssh2 team