www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: [PATCH] Support for exit-signal messages

Re: [PATCH] Support for exit-signal messages

From: Tommy Lindgren <tommy.lindgren_at_gmail.com>
Date: Mon, 11 Oct 2010 14:14:05 +0200

On 2010-10-05 19:48, Simon Josefsson wrote:
> Tommy Lindgren<tommy.lindgren_at_gmail.com> writes:
>
>> On 2010-10-05 12:02, Simon Josefsson wrote:
>>> Tommy Lindgren<tommy.lindgren_at_gmail.com> writes:
>>>
>>>> The function is always returning LIBSSH2_ERROR_NONE. I'm not sure if
>>>> it should returning anything else? (Perhaps if the malloc fails? Other
>>>> API functions don't seem to do this though.)
>>>
>>> It needs to handle memory allocation errors and return
>>> LIBSSH2_ERROR_ALLOC when it happens.
>>
>> OK. Updated patch attached.
>
> All general issues I can think of looks resolved.

Cool. How do you typically go about submitting patches? Should I create
a Trac issue?

Regards,
Tommy
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-10-11

the libssh2 team