www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: send/recv callbacks (was Re: writing to channel limited to 2 Mb?)

Re: send/recv callbacks (was Re: writing to channel limited to 2 Mb?)

From: Henrik Nordström <henrik_at_henriknordstrom.net>
Date: Thu, 11 Aug 2011 23:34:39 +0200

tor 2011-08-11 klockan 22:57 +0200 skrev Daniel Stenberg:
> On Thu, 11 Aug 2011, Henrik Nordström wrote:
>
> > I think a simpler way is to make all SSH send/recv go via session->send/recv
> > set by default to _libssh2_send/recv
> >
> > Additionally agent.c is also using _libssh2_send/recv with a slightly
> > different usage pattern, doing I/O on the agent fd and not the libssh2
> > session fd.
> >
> > Reworked patch attached. Can also be found in my github repository where
> > various other small changes also resides while I am reading the code.
>
> I think it looks really good. Is there anyone around with (different) opinions
> on Henrik's approach?

Just saw a slight omission in the patch. In transport.c there was one
direct use of session->send instead of using the LIBSSH2_SEND macro
wrapper. Updated patch attached.

Regards
Henrik

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Received on 2011-08-11

the libssh2 team