www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: libssh2_sftp_seek64 doesn't work

Re: libssh2_sftp_seek64 doesn't work

From: Henrik Nordström <henrik_at_henriknordstrom.net>
Date: Fri, 26 Aug 2011 14:55:58 +0200

tor 2011-08-25 klockan 16:33 +0800 skrev m odd:
> libssh2_sftp_seek64 should do more work than now, But my code is not
> very correct. am i right?

It looks reasonable, but sftp_packetlist_flush() looks dangerous to me
(actually in general, not specific to your change). What if it's in the
middle of sending a request?

Another possible issue is response packets arriving after the flush. If
I am not mistaken these will accumulate in the brigade and not get
freed.

Regards
Henrik

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2011-08-26

the libssh2 team