www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: [PATCH] libssh2_channel_request_auth_agent

Re: [PATCH] libssh2_channel_request_auth_agent

From: Mitchell Hashimoto <mitchell.hashimoto_at_gmail.com>
Date: Sat, 17 Mar 2012 12:49:56 -0700

Peter,

On Sat, Mar 17, 2012 at 12:13 PM, Peter Stuge <peter_at_stuge.se> wrote:
> Mitchell Hashimoto wrote:
>> > Not only the man page, look at how the existing API works, and make
>> > the new one for agent forwarding channels work the same.
>>
>> Hm, I took a look at libssh2_channel_process_startup and I'm not quite
>> sure I see the difference in what I'm doing vs what it is doing? What
>> was the problem you saw?
>
> There is no way you can reuse the existing code?

Unless I'm missing something then no, it looks different enough that I
can't. I based most of my code from channel_request_pty since that is
a very similar call (but again, too different to share code).

If this isn't reusable, and besides the example code, are there any
issues you can see with the patch? Would it be possible to get this
patch merged and I can submit another patch to clean up the examples?

Best,
Mitchell

>
>
> //Peter
> _______________________________________________
> libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2012-03-17

the libssh2 team