2010/1/20 Dave McCaldon <davem_at_intersystems.com>:
>
> On Jan 15, 2010, at 9:02 AM, Dave McCaldon wrote:
>
>> Yes, my patch added LIBSSH2_ERROR_AUTHENTICATION_FAILED with the same value as LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED.
>>
> Attached is a git patch that implements handling of SSH_MSG_USERAUTH_FAILURE in both libssh2_userauth_password_ex() and libssh2_userauth_keyboard_interactive_ex(). The error code returned, is LIBSSH2_ERROR_AUTHENTICATION_FAILED and as discussed it replaces LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED, but leaves LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED as an alias for LIBSSH2_ERROR_AUTHENTICATION_FAILED.
Thanks Dave, it looks great. My only suggestions are that the patch
should also change all existing uses of
LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED to
LIBSSH2_ERROR_AUTHENTICATION_FAILED for consistency and add a comment
to the #define explaining that's its for backward-compat.
Alex
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-01-21