Subject: [libssh2] #163: use libssh2_socket_t for socket type

[libssh2] #163: use libssh2_socket_t for socket type

From: libssh2 Trac <trac_at_libssh2.stuge.se>
Date: Wed, 03 Mar 2010 22:50:28 -0000

#163: use libssh2_socket_t for socket type
--------------------+-------------------------------------------------------
 Reporter: sldr | Owner:
     Type: defect | Status: new
 Priority: normal | Milestone:
Component: API | Version: 1.2.5
 Keywords: | Blocking:
Blockedby: |
--------------------+-------------------------------------------------------
 In libssh2.h (line 250) in struct _LIBSSH2_POLLFD a socket is declared as
 int instead of libssh2_socket_t. I don't see an include for libssh2_priv.h
 where libssh2_socket_t is defined but that could be fixed too.

 The int instead of libssh2_socket_t causes a signed unsigned comparison in
 session.c in function libssh2_poll (code is: "if (fds[i].fd.socket >
 maxfd)").

-- 
Ticket URL: <http://libssh2.stuge.se/ticket/163>
libssh2 <http://libssh2.stuge.se/>
C library for writing portable SSH2 clients
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-03-03