"Neil Gierman" <ngierman_at_roadrunn.com> writes:
> I noticed 446 compiler warnings related to data type conversions when
> compiling in VS2008 Itanium mode. They are mostly size_t to unsigned
> long/int conversion warnings. We have defined that in most places the length
> of messages and packets to be unsigned long or unsigned int. In most places
> we are storing the return of strlen() and other related function in to our
> length variables. An example is the definition of libssh2_error() where we
> are storing the return of strlen(errmsg) into session->err_msglen. Strlen
> returns size_t and in Win64 builds, size_t = unsigned __int64. Long = 4
> bytes, __int64 = 8bytes
> (http://msdn.microsoft.com/en-us/library/s3f49ktz(VS.80).aspx). There are
> quite a number of changes to sync up data types to match size_t and I don't
> know if some of those would break the API/ABI. Or we could go the easy way
> and cast the returns of strlen, etc to unsigned long (or whatever we want it
> as) however I think that is masking a future problem.
Agreed. Libssh2 is broken here, the Right Thing is to always use size_t
for string lengths. This change will break the ABI if we don't rename
all the functions though...
/Simon
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-03-10