Subject: Re: libssh2 master d002839... Fix namespace pollution.

Re: libssh2 master d002839... Fix namespace pollution.

From: Simon Josefsson <>
Date: Sun, 21 Mar 2010 19:42:13 +0100

Lars Nordin <> writes:

> On 2010-03-19 14:29, Daniel Stenberg wrote:
>> On Fri, 19 Mar 2010, Lars Nordin wrote:
>>> BTW, is _ the libssh2 standard for static variables? I trying to
>>> understand the code-standard.
>> No.
>> We use _libssh2 as prefix for library-wide non-static symbols that
>> aren't part of the public API. static symbols can be called anything
>> with no prefix requirements.
> OK, then the name should be changed (my fault), but not being
> static. I think we should allow global variables, instead of having to
> hide them and making read and set functions.

Check out how I solved this in latest git without any global variables
or read/set functions. IMHO having cross-file global variables is a
significant pain, and it was rather simple to avoid it here.

Received on 2010-03-21