Subject: Re: Select (function _libssh2_wait_socket) issue on some on an embedded platform

Re: Select (function _libssh2_wait_socket) issue on some on an embedded platform

From: Peter Stuge <peter_at_stuge.se>
Date: Sun, 28 Mar 2010 03:17:46 +0200

Sebastien Fricker wrote:
> In the function _libssh_wait_socket select is used with 2 pointer
> of descriptors: readfd and writefd.
> This pointers are pointing to the same fd_set.
> On RTOS32, this causes an error.

I just pushed this fix.

> if nobody are seeing any problem about this code, I will provide a
> patch.

**PLEASE** just send the patch immediately! It is less work for you
to create than copypasting a bunch of code, it is MUCH easier to
read, and if everyone approves then the patch can be committed
directly and the case is closed. So it would save time for everyone!

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-03-28