Subject: Re: Time for release!

Re: Time for release!

From: Simon Josefsson <simon_at_josefsson.org>
Date: Tue, 13 Apr 2010 09:42:23 +0200

Daniel Stenberg <daniel_at_haxx.se> writes:

> On Tue, 13 Apr 2010, Simon Josefsson wrote:
>
>> What I do is typically add some code in ssh2.c that will hang, like:
>>
>> getchar ()
>>
>> and then do M-x gdb to attach to the running process, add some
>> breakpoint, and then do 'c' in gdb and then start to debug it.
>
> Ah, neat trick - thanks. In this particular case I could also just run
> the test and attach gdb as it would hang in _libssh2_wait_socket()
> ... :-O

Heh, true.

>> I did this some time ago, and then it hang when tearing down the
>> connection in the new poll() code. Of course, it is possible that
>> the ssh2.c self test code is buggy, but still, it used to work so
>> something we changed in the library likely broke it.
>
> Yeah. Switching to the select() code doesn't change the behavior.

Ouch. Then it must have broken earlier...

>> You could also just disable the self check and release anyway.
>
> I might do that. I'll dig around some further first to see if I can
> figure it out. We do run tests all the time with curl using libssh2
> and they run just fine, so I have reason to believe that most of it is
> still functional...

Yup. Having working self-checks inside libssh2 would be useful, though,
since it makes regression testing easier for those not running libssh2
under curl self-checks. For the todo list...

/Simon
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-04-13