On Wed, 19 May 2010, Alexander Lamaison wrote:
> Currently libssh2_knownhost_checkp() uses the magic value 0 in the port
> number argument to indicate that the port number should be ignored and
> generic checking should take place. However, 0 is a valid port number in
> its own right [1]
>
> Therefore, I suggest changing the magic value to -1 before we make the first
> release of libssh2 that includes this new API function.
I have no objections. Port 0 is "magic" to lots of apps and system calls even,
but that doesn't mean we shouldn't work to do it right!
-- / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-05-19