Subject: Re: libssh2 master 81912f6 cast away a warning.

Re: libssh2 master 81912f6 cast away a warning.

From: Tor Arntsen <tor_at_spacetec.no>
Date: Mon, 7 Jun 2010 10:48:38 +0200

On Mon, Jun 7, 2010 at 06:35, Peter Stuge <peter_at_stuge.se> wrote:
> Guenter wrote:
>> we can cast to int until year 2038
>
> I don't mind that cast, but it could be nice to add /* XXX: Y2k38 */
> nearby.

Hm, one of those unfortunate API problems.. it's a parameter to a
public function. The correct fix is of course to change
seconds_to_next to time_t *. No can do here though. In those cases I
personally prefer to fix the internal types, and copy from/to the API
parameter explictly - it makes things pretty obvious then. But that's
just me.

-Tor
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-06-07