Subject: Re: [PATCH] Support for exit-signal messages

Re: [PATCH] Support for exit-signal messages

From: Simon Josefsson <simon_at_josefsson.org>
Date: Tue, 05 Oct 2010 19:48:14 +0200

Tommy Lindgren <tommy.lindgren_at_gmail.com> writes:

> On 2010-10-05 12:02, Simon Josefsson wrote:
>> Tommy Lindgren<tommy.lindgren_at_gmail.com> writes:
>>
>>> The function is always returning LIBSSH2_ERROR_NONE. I'm not sure if
>>> it should returning anything else? (Perhaps if the malloc fails? Other
>>> API functions don't seem to do this though.)
>>
>> It needs to handle memory allocation errors and return
>> LIBSSH2_ERROR_ALLOC when it happens.
>
> OK. Updated patch attached.

All general issues I can think of looks resolved.

/Simon
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-10-05