Subject: Re: libssh2 master aff9c82 channel_write: move some logic to _libssh2_channel_write

Re: libssh2 master aff9c82 channel_write: move some logic to _libssh2_channel_write

From: Peter Stuge <peter_at_stuge.se>
Date: Fri, 12 Nov 2010 18:10:04 +0100

libssh2_at_git.stuge.se wrote:
> +++ b/src/channel.c
> @@ -1994,27 +1994,6 @@ channel_write(LIBSSH2_CHANNEL *channel, int stream_id,
> buflen = 32700;
>
> if (channel->write_state == libssh2_NB_state_idle) {
> - _libssh2_debug(session, LIBSSH2_TRACE_CONN,
> - "Writing %d bytes on channel %lu/%lu, stream #%d",
> - (int) buflen, channel->local.id, channel->remote.id,
> - stream_id);

Losing this logging in channel_write() is a bit unfortunate, since
there are multiple code paths leading to the function.

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-11-12