> No. Using do {} while() must not change (you add braces) since it
> allows the macro to successfully be used as a function in all
> circumstances in C code. In this case you would add an outer
> do {} while() as such:
Ok, that's fair enough. Changed
> Also, please make sure to maintain code style (whitespace changes) in
> the code that you work on. Thanks!
I assume you're talking about the spaces between the backslash and the
code in the macro? If so, I think I've fixed that now (I didn't notice
my editor had done it). If it's something else, can you be more specific
so I can fix that as well?
> Btw, it doesn't make sense to have while(1) immediately preceded by a
> conditional break IMO.
Agreed, changed.
Matt
-- _____________________________________________ Matt Lilley Software Engineer SecuritEase Tel: +64 4 912-2100 Fax: +64 4 912-2101 E-mail: matt.lilley_at_securitease.com Web: http://www.securitease.com _____________________________________________ This e-mail has passed our content security scan. It is covered by the confidentiality clauses at http://www.securitease.com/content_and_confidentialityReceived on 2011-05-03