Subject: Re: [libssh2] #229: static const EVP_CIPHER * make_ctr_evp (size_t keylen) in openssl.c not threadsafe

Re: [libssh2] #229: static const EVP_CIPHER * make_ctr_evp (size_t keylen) in openssl.c not threadsafe

From: libssh2 Trac <trac_at_libssh2.stuge.se>
Date: Thu, 29 Sep 2011 18:40:54 -0000

#229: static const EVP_CIPHER * make_ctr_evp (size_t keylen) in openssl.c
not threadsafe
-----------------------+----------------------
  Reporter: engstrom | Owner: bagder
      Type: defect | Status: assigned
  Priority: normal | Milestone: 1.2.9
 Component: API | Version: 1.3.0
Resolution: | Keywords:
Blocked By: | Blocks:
-----------------------+----------------------

Comment (by bagder):

 static structs are zero'ed already, defined by the C standard. We don't
 need to clear them.

 Thus just skipping the memset() is a MUCH smaller change and creates much
 less duplicated code imho... 

-- 
Ticket URL: <http://trac.libssh2.org/ticket/229#comment:9>
libssh2 <http://trac.libssh2.org/>
C library for writing portable SSH2 clients
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2011-09-29