www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Add support for "signal" message channel request

Re: [PATCH] Add support for "signal" message channel request

From: Pavel Strashkin <pavel.strashkin_at_gmail.com>
Date: Mon, 17 Oct 2011 13:26:30 -0700

Should i remove the changes for that function from the patch? Or i should
fix my mistake and we OK with it for the first time?
17.10.2011 13:10 пользователь "Daniel Stenberg" <daniel_at_haxx.se> написал:

> On Mon, 17 Oct 2011, Pavel Strashkin wrote:
>
> I've also extended "_libssh2_error" with an ability to use formatting
>> string as "_libssh2_debug" does.
>>
>
> Thanks a lot for your work, but...
>
> Pretty please, do not make several unrelated changes in the same patch!
>
> Your _libssh2_error() now returns a pointer to a stack based buffer which
> is completely wrong.
>
> The comment header above libssh2_channel_signal() says the wrong function
> name.
>
> --
>
> / daniel.haxx.se
> ______________________________**_________________
> libssh2-devel http://cool.haxx.se/cgi-bin/**mailman/listinfo/libssh2-devel<http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel>
>

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2011-10-17

the libssh2 team