Subject: Re: [PATCH] sftp: Add support for fsync (OpenSSH extension).

Re: [PATCH] sftp: Add support for fsync (OpenSSH extension).

From: Richard W.M. Jones <rjones_at_redhat.com>
Date: Tue, 9 Apr 2013 17:31:17 +0100

On Tue, Apr 09, 2013 at 09:20:55AM -0700, TJ Saunders wrote:
>
> > In this case, it fails as follows:
> >
> > /* extract from the latest qemu ssh block driver code */
> > r = libssh2_sftp_fsync(s->sftp_handle);
> > /* ... */
> > if (r == LIBSSH2_ERROR_SFTP_PROTOCOL &&
> > libssh2_sftp_last_error(s->sftp) == LIBSSH2_FX_OP_UNSUPPORTED) {
> > unsafe_flush_warning(s, "OpenSSH >= 6.3");
> > return 0;
> > }
>
> What about SSH servers, other than OpenSSH, which might implement this
> extension? The unsafe_flush_warning() message there, then, might be
> misleading...

I'll certainly update this message if other ssh servers support
this extension (and I hope they do).

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2013-04-09