Subject: Re: Suggested patches for WinCNG

Re: Suggested patches for WinCNG

From: Peter Stuge <>
Date: Thu, 20 Mar 2014 08:21:54 +0100

Marc Hoersken wrote:
> > _libssh2_wincng_hash_ctx and _libssh2_wincng_key_ctx: I found this
> > confusing. Kind of a circular #define. I think this is more of what
> > was intended.
> This change is okay with me. I think I used defines, because it the
> approach was used within other places of libssh2. Daniel, Peter,
> what do you think?

I'm afraid I can't do much review without a proper patch series.

I'm happy to help answer questions about git.

Bob, git add -p is your friend.

Received on 2014-03-20