Re: CMake

On 8 December 2014 at 13:45, Kamil Dudka <kdudka_at_redhat.com> wrote:
> On Saturday 06 December 2014 00:34:41 Alexander Lamaison wrote:
>>
>> tl;dr
>> - A version of libssh2 using CMake is available at
>> https://github.com/alamaison/libssh2/tree/cmake
>> - Please test

> I have encountered a few minor issues:
>
> - The shared library is no longer versioned as it used to be. I have
> hard-coded the version into src/CMakeLists.txt for now

Fixed in d50c4f06a14fad1da34bc05af85602c5ce0e95eb
https://github.com/alamaison/libssh2/commit/d50c4f06a14fad1da34bc05af85602c5ce0e95eb

> - The file libssh2.pc is no longer generated with CMake. Is there any plan
> to restore this functionality?

Fixed in 946ab802b9e79acdcc6c8e386b6510cd1f86d058
https://github.com/alamaison/libssh2/commit/946ab802b9e79acdcc6c8e386b6510cd1f86d058

I noticed you had lib64 as the lib path. I had hardcoded 'lib' before
so I changed to use GNUInstallDirs, which tries to do the right thing
based on platform. Let me know if this causes any problems.

> I can help you with the rebase once there is agreement on the final version.

Thanks :)

Alex

-- 
Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org)
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel