src/userauth.c

     = ;   if (session->userauth_pswd_state =3D=3D libssh2_NB_state_s= ent) {
           = ; rc =3D _libssh2_packet_requirev(session, reply_codes,
  &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp; &session->userauth_pswd_data,
     = ;            &n= bsp;            = ;            &se= ssion->userauth_pswd_data_len,
      &n= bsp;            = ;            &n= bsp;          0, NULL, 0,
&= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;    &session->
     &nb= sp;            =             &nb= sp;           userauth_ps= wd_packet_requirev_state);
       &nb= sp;    if (rc =3D=3D LIBSSH2_ERROR_EAGAIN) {
  =             &nb= sp; return _libssh2_error(session, LIBSSH2_ERROR_EAGAIN,
  &nb= sp;            =             &nb= sp;          "Would block wait= ing");
           = ; } else if (rc) {
         = ;       session->userauth_pswd_state =3D l= ibssh2_NB_state_idle;
        &n= bsp;       return _libssh2_error(session, LIB= SSH2_ERROR_TIMEOUT,
        &nbs= p;            &= nbsp;           &nbs= p;    "Would block waiting");
    &nb= sp;       }

= I think it should return the actual error from the transport layer and not = a "general" LIBSSH2_ERROR_TIMEOUT error.

--=_1622dda1d5674e5da579c209325109a8-- --===============0225466556== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel --===============0225466556==-- From libssh2-devel-bounces@cool.haxx.se Wed Apr 17 14:08:11 2013 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HC7hEE019542; Wed, 17 Apr 2013 14:08:04 +0200 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HC7g3K019531 for ; Wed, 17 Apr 2013 14:07:42 +0200 Received: (qmail 8181 invoked by uid 501); 17 Apr 2013 12:07:43 -0000 Message-ID: <20130417120743.8180.qmail@stuge.se> Date: Wed, 17 Apr 2013 14:07:43 +0200 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: libssh2_userauth_password return value Mail-Followup-To: libssh2-devel@cool.haxx.se References: <20130417010004.c9366f9f22cd3bbc3383a912335b41fe.e0a8c3e9ba.mailapi@email11.secureserver.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130417010004.c9366f9f22cd3bbc3383a912335b41fe.e0a8c3e9ba.mailapi@email11.secureserver.net> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.15 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" cosmin@5ivestars.net wrote: > } else if (rc) { > session->userauth_pswd_state = libssh2_NB_state_idle; > return _libssh2_error(session, LIBSSH2_ERROR_TIMEOUT, > "Would block waiting"); > } > > I think it should return the actual error from the transport layer > and not a "general" LIBSSH2_ERROR_TIMEOUT error. Could you send a patch to fix that? Thanks. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Apr 17 15:13:26 2013 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HDD62m028680; Wed, 17 Apr 2013 15:13:22 +0200 Received: from p3plwbeout11-06.prod.phx3.secureserver.net (p3plsmtp11-06-2.prod.phx3.secureserver.net [173.201.192.44]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HDD46V028516 for ; Wed, 17 Apr 2013 15:13:04 +0200 Received: from localhost ([173.201.192.118]) by p3plwbeout11-06.prod.phx3.secureserver.net with bizsmtp id R1Cy1l0012ZjpT9011CyJq; Wed, 17 Apr 2013 06:12:58 -0700 X-SID: R1Cy1l0012ZjpT901 Received: (qmail 16279 invoked by uid 99); 17 Apr 2013 13:12:58 -0000 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_277abf2b50a4031ad5f53ff0e825f349" To: "libssh2 development" From: cosmin@5ivestars.net Subject: RE: Re: libssh2_userauth_password return value In-Reply-To: <20130417120743.8180.qmail@stuge.se> Date: Wed, 17 Apr 2013 06:12:58 -0700 Message-Id: <20130417061258.c9366f9f22cd3bbc3383a912335b41fe.338c77c3e3.mailapi@email11.secureserver.net> X-Originating-IP: 188.240.236.11 User-Agent: MailAPI 24256 X-Sender: cosmin@5ivestars.net X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.15 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --=_277abf2b50a4031ad5f53ff0e825f349 Content-Type: multipart/alternative; boundary="=_0a2b839efcc733bc8b19350d6c01fc90" --=_0a2b839efcc733bc8b19350d6c01fc90 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Here is a little patch, I am not sure it's 100% ok, it does not resolve the= problem entirely, it only handles LIBSSH2_ERROR_SOCKET_DISCONNECT. Maybe = just returning "rc" would be better.=20 --------- Original Message ---------Subject: Re: libssh2_userauth_password = return value From: Peter Stuge Date: 4/17/13 3:07 pm To: libssh2-devel@cool.haxx.se cosmin@5ivestars.net wrote: > } else if (rc) { > session->userauth_pswd_state =3D libssh2_NB_state_idle; > return _libssh2_error(session, LIBSSH2_ERROR_TIMEOUT, > "Would block waiting"); > } >=20 > I think it should return the actual error from the transport layer > and not a "general" LIBSSH2_ERROR_TIMEOUT error. =20 Could you send a patch to fix that? Thanks. =20 =20 //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel --=_0a2b839efcc733bc8b19350d6c01fc90 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

Here is a little patch, I am not sure it's 100% ok, it does not resolv= e the problem entirely, it only handles LIBSSH2_ERROR_SOCKET_DISCONNECT. Ma= ybe just returning "rc" would be better.

--------- Original Message ---------Subject: Re: libssh2_userauth_password return value
From: Peter Stuge = <peter@stuge.se>
Date: 4/17/13 3:07 pm
To: libssh2-devel@cool= =2Ehaxx.se

cosmin@5ivestars.net wrote:
> } else if (rc) {
= > session->userauth_pswd_state =3D libssh2_NB_state_idle;
> r= eturn _libssh2_error(session, LIBSSH2_ERROR_TIMEOUT,
> "Would block = waiting");
> }
>
> I think it should return the actua= l error from the transport layer
> and not a "general" LIBSSH2_ERROR= _TIMEOUT error.

Could you send a patch to fix that? Thanks.

//Peter
_______________________________________________
lib= ssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

--=_0a2b839efcc733bc8b19350d6c01fc90-- --=_277abf2b50a4031ad5f53ff0e825f349 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=patch.txt; charset=UTF-8 Content-Disposition: attachment; filename=patch.txt LS0tIHNyYy91c2VyYXV0aC5jCTIwMTItMDQtMTggMjM6MjQ6MDQuMDAwMDAwMDAwICswMzAwCisr KyBzcmMvdXNlcmF1dGgubmV3LmMJMjAxMy0wNC0xNyAxNTo1MTowMy4yNzU2ODc1MzggKzAzMDAK QEAgLTI4MCw5ICsyODAsMTUgQEAKICAgICAgICAgICAgICAgICByZXR1cm4gX2xpYnNzaDJfZXJy b3Ioc2Vzc2lvbiwgTElCU1NIMl9FUlJPUl9FQUdBSU4sCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICJXb3VsZCBibG9jayB3YWl0aW5nIik7CiAgICAgICAgICAgICB9IGVs c2UgaWYgKHJjKSB7Ci0gICAgICAgICAgICAgICAgc2Vzc2lvbi0+dXNlcmF1dGhfcHN3ZF9zdGF0 ZSA9IGxpYnNzaDJfTkJfc3RhdGVfaWRsZTsKLSAgICAgICAgICAgICAgICByZXR1cm4gX2xpYnNz aDJfZXJyb3Ioc2Vzc2lvbiwgTElCU1NIMl9FUlJPUl9USU1FT1VULAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiV291bGQgYmxvY2sgd2FpdGluZyIpOworCQlpZiAocmMg PT0gTElCU1NIMl9FUlJPUl9TT0NLRVRfRElTQ09OTkVDVCApIHsKKwkJICAgIHNlc3Npb24tPnVz ZXJhdXRoX3Bzd2Rfc3RhdGUgPSBsaWJzc2gyX05CX3N0YXRlX2lkbGU7CisgICAgICAgICAgICAJ ICAgIHJldHVybiBfbGlic3NoMl9lcnJvcihzZXNzaW9uLCBMSUJTU0gyX0VSUk9SX1NPQ0tFVF9E SVNDT05ORUNULAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiQ29ubmVj dGlvbiBjbG9zZWQgYnkgc2VydmVyIik7CisJCX0gZWxzZSB7CisgICAgICAgICAgICAJICAgIHNl c3Npb24tPnVzZXJhdXRoX3Bzd2Rfc3RhdGUgPSBsaWJzc2gyX05CX3N0YXRlX2lkbGU7CisgICAg ICAgICAgICAJICAgIHJldHVybiBfbGlic3NoMl9lcnJvcihzZXNzaW9uLCBMSUJTU0gyX0VSUk9S X1RJTUVPVVQsCisgICAgICAgICAgICAgICAgCSAgICAgICAgICAgICAgICAgICJXb3VsZCBibG9j ayB3YWl0aW5nIik7CisJCX0KICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgaWYgKHNlc3Np b24tPnVzZXJhdXRoX3Bzd2RfZGF0YVswXSA9PSBTU0hfTVNHX1VTRVJBVVRIX1NVQ0NFU1MpIHsK --=_277abf2b50a4031ad5f53ff0e825f349 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel --=_277abf2b50a4031ad5f53ff0e825f349-- From libssh2-devel-bounces@cool.haxx.se Wed Apr 17 15:33:53 2013 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HDXlkk008912; Wed, 17 Apr 2013 15:33:51 +0200 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HDXj4G008898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Wed, 17 Apr 2013 15:33:45 +0200 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id r3HDXjS4008894 for ; Wed, 17 Apr 2013 15:33:45 +0200 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 17 Apr 2013 15:33:45 +0200 (CEST) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: RE: Re: libssh2_userauth_password return value In-Reply-To: <20130417061258.c9366f9f22cd3bbc3383a912335b41fe.338c77c3e3.mailapi@email11.secureserver.net> Message-ID: References: <20130417061258.c9366f9f22cd3bbc3383a912335b41fe.338c77c3e3.mailapi@email11.secureserver.net> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) X-fromdanielhimself: yes MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="1129329158-432444064-1366205625=:32122" X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.15 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1129329158-432444064-1366205625=:32122 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Wed, 17 Apr 2013, cosmin@5ivestars.net wrote: > Here is a little patch, I am not sure it's 100% ok, it does not resolve the > problem entirely, it only handles LIBSSH2_ERROR_SOCKET_DISCONNECT. Maybe > just returning "rc" would be better. I think so. I'd prefer a patch like the one attached here! Thoughts? -- / daniel.haxx.se --1129329158-432444064-1366205625=:32122 Content-Type: TEXT/x-diff; name=0001-userauth_password-pass-on-the-underlying-error-code.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-userauth_password-pass-on-the-underlying-error-code.patch RnJvbSBmOTBkNjAyYWZmYThhYWMzNzVkMzJmN2U0MTY4MjM1NDVmOGRkOTM2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogRGFuaWVsIFN0ZW5i ZXJnIDxkYW5pZWxAaGF4eC5zZT4NCkRhdGU6IFdlZCwgMTcgQXByIDIwMTMg MTU6MzE6MTIgKzAyMDANClN1YmplY3Q6IFtQQVRDSF0gdXNlcmF1dGhfcGFz c3dvcmQ6IHBhc3Mgb24gdGhlIHVuZGVybHlpbmcgZXJyb3IgY29kZQ0KDQpf bGlic3NoMl9wYWNrZXRfcmVxdWlyZXYoKSBtYXkgcmV0dXJuIGRpZmZlcmVu dCBlcnJvcnMgYW5kIHdlIHBhc3MgdGhhdA0KdG8gdGhlIHBhcmVudCBpbnN0 ZWFkIG9mIHJld3JpdGluZyBpdC4NCg0KQnVnOiBodHRwOi8vbGlic3NoMi5v cmcvbWFpbC9saWJzc2gyLWRldmVsLWFyY2hpdmUtMjAxMy0wNC8wMDI5LnNo dG1sDQpSZXBvcnRlZCBieTogQ29zbWluDQotLS0NCiBzcmMvdXNlcmF1dGgu YyB8ICAgMTQgKysrKysrKy0tLS0tLS0NCiAxIGZpbGUgY2hhbmdlZCwgNyBp bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEv c3JjL3VzZXJhdXRoLmMgYi9zcmMvdXNlcmF1dGguYw0KaW5kZXggYTA3MzNk NS4uNjVkYWU0NiAxMDA2NDQNCi0tLSBhL3NyYy91c2VyYXV0aC5jDQorKysg Yi9zcmMvdXNlcmF1dGguYw0KQEAgLTI3NiwxMyArMjc2LDEzIEBAIHVzZXJh dXRoX3Bhc3N3b3JkKExJQlNTSDJfU0VTU0lPTiAqc2Vzc2lvbiwNCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwLCBOVUxM LCAwLA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICZzZXNzaW9uLT4NCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1c2VyYXV0aF9wc3dkX3BhY2tldF9yZXF1aXJldl9z dGF0ZSk7DQotICAgICAgICAgICAgaWYgKHJjID09IExJQlNTSDJfRVJST1Jf RUFHQUlOKSB7DQotICAgICAgICAgICAgICAgIHJldHVybiBfbGlic3NoMl9l cnJvcihzZXNzaW9uLCBMSUJTU0gyX0VSUk9SX0VBR0FJTiwNCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJXb3VsZCBibG9jayB3 YWl0aW5nIik7DQotICAgICAgICAgICAgfSBlbHNlIGlmIChyYykgew0KLSAg ICAgICAgICAgICAgICBzZXNzaW9uLT51c2VyYXV0aF9wc3dkX3N0YXRlID0g bGlic3NoMl9OQl9zdGF0ZV9pZGxlOw0KLSAgICAgICAgICAgICAgICByZXR1 cm4gX2xpYnNzaDJfZXJyb3Ioc2Vzc2lvbiwgTElCU1NIMl9FUlJPUl9USU1F T1VULA0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IldvdWxkIGJsb2NrIHdhaXRpbmciKTsNCisNCisgICAgICAgICAgICBpZiAo cmMpIHsNCisgICAgICAgICAgICAgICAgaWYgKHJjICE9IExJQlNTSDJfRVJS T1JfRUFHQUlOKQ0KKyAgICAgICAgICAgICAgICAgICAgc2Vzc2lvbi0+dXNl cmF1dGhfcHN3ZF9zdGF0ZSA9IGxpYnNzaDJfTkJfc3RhdGVfaWRsZTsNCisN CisgICAgICAgICAgICAgICAgcmV0dXJuIF9saWJzc2gyX2Vycm9yKHNlc3Np b24sIHJjLA0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIldhaXRpbmcgZm9yIHBhc3N3b3JkIHJlc3BvbnNlIik7DQogICAgICAg ICAgICAgfQ0KIA0KICAgICAgICAgICAgIGlmIChzZXNzaW9uLT51c2VyYXV0 aF9wc3dkX2RhdGFbMF0gPT0gU1NIX01TR19VU0VSQVVUSF9TVUNDRVNTKSB7 DQotLSANCjEuNy4xMC40DQoNCg== --1129329158-432444064-1366205625=:32122 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel --1129329158-432444064-1366205625=:32122-- From libssh2-devel-bounces@cool.haxx.se Wed Apr 17 16:03:15 2013 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HE39IX030177; Wed, 17 Apr 2013 16:03:13 +0200 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HE37xZ030143 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Wed, 17 Apr 2013 16:03:07 +0200 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id r3HE373C030139 for ; Wed, 17 Apr 2013 16:03:07 +0200 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 17 Apr 2013 16:03:07 +0200 (CEST) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: [PATCH] sftp: Add support for fsync (OpenSSH extension). In-Reply-To: <20130416215355.22368.qmail@stuge.se> Message-ID: References: <1365500529-25834-1-git-send-email-rjones@redhat.com> <20130416215355.22368.qmail@stuge.se> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.15 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" On Tue, 16 Apr 2013, Peter Stuge wrote: > I strongly dislike the absolute disconnect between the extremely generic > name libssh2_sftp_fsync() and the very opposite name fsync@openssh.com - > unless libssh2 will in the future use a heuristic to determine which actual > extension to use. I don't want that. I do. If there would appear another way to fsync in a future, we can introduce either a way for libssh2 to figure out by itself what method to use, or we provide an API for the application to select method. > At a minimum, I'd like a follow up patch which changes the API name to > libssh2_sftp_fsync_openssh_com() or such.. Why do think this is necessary? I don't think we do a service to our users by exposing the underlying protocol naming in our function names. I also suspect that we won't be flooded by lots of other fsync variations either... -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Apr 17 18:11:10 2013 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HGAh9a018582; Wed, 17 Apr 2013 18:11:04 +0200 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HGAfsF018573 for ; Wed, 17 Apr 2013 18:10:41 +0200 Received: (qmail 27070 invoked by uid 501); 17 Apr 2013 16:10:42 -0000 Message-ID: <20130417161042.27069.qmail@stuge.se> Date: Wed, 17 Apr 2013 18:10:42 +0200 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: [PATCH] sftp: Add support for fsync (OpenSSH extension). Mail-Followup-To: libssh2-devel@cool.haxx.se References: <1365500529-25834-1-git-send-email-rjones@redhat.com> <20130416215355.22368.qmail@stuge.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.15 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Daniel Stenberg wrote: >> I strongly dislike the absolute disconnect between the extremely generic >> name libssh2_sftp_fsync() and the very opposite name fsync@openssh.com - >> unless libssh2 will in the future use a heuristic to determine which >> actual extension to use. I don't want that. > > I do. Even though it doesn't scale at all? > If there would appear another way to fsync in a future, we can introduce > either a way for libssh2 to figure out by itself what method to use, > or we provide an API for the application to select method. Whatever happens in the future the generic API must by default remain this very specific OpenSSH extension, if we introduce such an API now. >> At a minimum, I'd like a follow up patch which changes the API name to >> libssh2_sftp_fsync_openssh_com() or such.. > > Why do think this is necessary? Because we know now that we can not say if a future heuristic will be able to reliably determine what method to use. I find it important to educate library users that this particular call is specific to OpenSSH sshd. While that is definitely a very common case, there are also users which either have mixed environments or simply have no OpenSSH sshd:s at all. > I don't think we do a service to our users by exposing the > underlying protocol naming in our function names. Actually this is what we do for every other part of the protocols, libssh2 concepts map very closely to the RFC concepts, and I think this is a really good thing. > I also suspect that we won't be flooded by lots of other fsync > variations either... I completely agree. It's possible that there will only ever be the OpenSSH extension. When it has become standard (de-facto or otherwise) we can reconsider. Until then, document in the function name what it is. I think it is a critical piece of information for anyone who wants to use it. It could also be viewed as preemptive handling of support requests about libssh2_sftp_fsync() causing data corruption on $non-OpenSSH-servers.. :) //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Apr 17 18:12:21 2013 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HGCJvr019574; Wed, 17 Apr 2013 18:12:20 +0200 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3HGCHiF019538 for ; Wed, 17 Apr 2013 18:12:17 +0200 Received: (qmail 27246 invoked by uid 501); 17 Apr 2013 16:12:19 -0000 Message-ID: <20130417161219.27245.qmail@stuge.se> Date: Wed, 17 Apr 2013 18:12:19 +0200 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: libssh2_userauth_password return value Mail-Followup-To: libssh2-devel@cool.haxx.se References: <20130417061258.c9366f9f22cd3bbc3383a912335b41fe.338c77c3e3.mailapi@email11.secureserver.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.15 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Daniel Stenberg wrote: > From f90d602affa8aac375d32f7e416823545f8dd936 Mon Sep 17 00:00:00 2001 > From: Daniel Stenberg > Date: Wed, 17 Apr 2013 15:31:12 +0200 > Subject: [PATCH] userauth_password: pass on the underlying error code > > _libssh2_packet_requirev() may return different errors and we pass that > to the parent instead of rewriting it. > > Bug: http://libssh2.org/mail/libssh2-devel-archive-2013-04/0029.shtml > Reported by: Cosmin Acked-by: Peter Stuge _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Apr 23 11:04:40 2013 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3N94EhM016326; Tue, 23 Apr 2013 11:04:33 +0200 Received: from dns-factory.at (mail.dns-factory.at [194.242.35.75]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3N94AUf016306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Tue, 23 Apr 2013 11:04:10 +0200 Received: from [172.17.100.8] lists@gknw.net [62.143.120.100] by dns-factory.at with NetMail SMTP Agent $Revision: 8582 $ on Novell NetWare via secured & encrypted transport (TLS); Tue, 23 Apr 2013 11:04:00 +0200 Message-ID: <51764E7D.2080807@gknw.net> Date: Tue, 23 Apr 2013 11:03:57 +0200 From: Guenter User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: libssh2 development Subject: Re: [PATCH] sftp: Add support for fsync (OpenSSH extension). References: <1365500529-25834-1-git-send-email-rjones@redhat.com> <20130416215355.22368.qmail@stuge.se> In-Reply-To: X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id r3N94AUf016306 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.15 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id r3N94EhM016326 On 17.04.2013 16:03, Daniel Stenberg wrote: > On Tue, 16 Apr 2013, Peter Stuge wrote: > >> I strongly dislike the absolute disconnect between the extremely >> generic name libssh2_sftp_fsync() and the very opposite name >> fsync@openssh.com - unless libssh2 will in the future use a heuristic >> to determine which actual extension to use. I don't want that. > > I do. > > If there would appear another way to fsync in a future, we can introduce > either a way for libssh2 to figure out by itself what method to use, or > we provide an API for the application to select method. > >> At a minimum, I'd like a follow up patch which changes the API name to >> libssh2_sftp_fsync_openssh_com() or such.. > > Why do think this is necessary? I don't think we do a service to our > users by exposing the underlying protocol naming in our function names. > I also suspect that we won't be flooded by lots of other fsync > variations either... > what about something like that: #define LIBSSH2_FSYNC_AUTO 0 #define LIBSSH2_FSYNC_OPENSSH 1 libssh2_sftp_fsync(LIBSSH2_FSYNC_OPENSSH, ...) this way the function name could stay also in the future, users of the function can select the method to use, and it would be possible to select an automatic way if it can be implemented ... G�n. _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Apr 23 12:34:05 2013 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3NAXmub018181; Tue, 23 Apr 2013 12:34:02 +0200 Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by giant.haxx.se (8.14.4/8.14.4/Debian-2) with ESMTP id r3NAXkId017886 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 23 Apr 2013 12:33:47 +0200 Received: by mail-vc0-f173.google.com with SMTP id gf12so435564vcb.18 for ; Tue, 23 Apr 2013 03:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=ktnuSk8TWNQYW1bGSIQnqaFe/SDN/TiOxBVHMMZRAxM=; b=sQ3c9ULJlyDVl2tjiPhWTCDDoMXkXN99dWpOuEcY3QfIrTAojvi30H/uhzWVRm4Hvi U3urh/hgELp6oQ6FGudrbZf3LXLhBKOs9WuRTHCiYxfY78tGz55EXfCtvH76L1d+e0ZU LTt6CgzqiDuEkQu+fyqeJ8iQfSnE5rCqG1deszisNc/b7VUQlocgkr0AOws1eFHLHFQ5 TG/Terj1gq5yiJRYzrsM9nVutNyjlGYo54Kmbe54IAshXZQBdUvqy0cV+FjuXQmSWxm6 hND6zcPuBwi3+T+UApMLdKVy+sWRwrlmTlXVPL9avCaxpuh+mVMskpDNwZJXKKAK8ryt wbzg== MIME-Version: 1.0 X-Received: by 10.52.97.131 with SMTP id ea3mr18484184vdb.71.1366713221373; Tue, 23 Apr 2013 03:33:41 -0700 (PDT) Received: by 10.52.113.100 with HTTP; Tue, 23 Apr 2013 03:33:41 -0700 (PDT) In-Reply-To: <51764E7D.2080807@gknw.net> References: <1365500529-25834-1-git-send-email-rjones@redhat.com> <20130416215355.22368.qmail@stuge.se> <51764E7D.2080807@gknw.net> Date: Tue, 23 Apr 2013 11:33:41 +0100 X-Google-Sender-Auth: qQ26XgeQXO09Pc8n3qu1RhGsn3M Message-ID: Subject: Re: [PATCH] sftp: Add support for fsync (OpenSSH extension). From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.15 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2138804016==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============2138804016== Content-Type: multipart/alternative; boundary=20cf307cfc7e11e6b104db04b8c3 --20cf307cfc7e11e6b104db04b8c3 Content-Type: text/plain; charset=ISO-8859-1 On 23 April 2013 10:03, Guenter wrote: > On 17.04.2013 16:03, Daniel Stenberg wrote: > >> On Tue, 16 Apr 2013, Peter Stuge wrote: >> >> I strongly dislike the absolute disconnect between the extremely >>> generic name libssh2_sftp_fsync() and the very opposite name >>> fsync@openssh.com - unless libssh2 will in the future use a heuristic >>> to determine which actual extension to use. I don't want that. >>> >> >> I do. >> >> If there would appear another way to fsync in a future, we can introduce >> either a way for libssh2 to figure out by itself what method to use, or >> we provide an API for the application to select method. >> >> At a minimum, I'd like a follow up patch which changes the API name to >>> libssh2_sftp_fsync_openssh_**com() or such.. >>> >> >> Why do think this is necessary? I don't think we do a service to our >> users by exposing the underlying protocol naming in our function names. >> I also suspect that we won't be flooded by lots of other fsync >> variations either... >> >> what about something like that: > > #define LIBSSH2_FSYNC_AUTO 0 > #define LIBSSH2_FSYNC_OPENSSH 1 > > libssh2_sftp_fsync(LIBSSH2_**FSYNC_OPENSSH, ...) > > this way the function name could stay also in the future, users of the > function can select the method to use, and it would be possible to select > an automatic way if it can be implemented ... > The intentions are good, but we're overengineering here. Is any standard version of this feature realistically going to have an incompatible API? And if, despite sensible predicitons, it is incompatible, is it really the end of the world? We just add a second API call and combine them at the next soname bump. Our API is littered with sub-optimal APIs waiting for the ABI-change green light. Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) --20cf307cfc7e11e6b104db04b8c3 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On 2= 3 April 2013 10:03, Guenter <lists@gknw.net> wrote:

On 17.04.2013 16:03, Daniel Stenberg wrote:

On Tue, 16 Apr 2013, Peter Stuge wrote:

I strongly dislike the absolute disconnect between the extremely
generic name libssh2_sftp_fsync() and the very opposite name
fsync@openssh.com - unless libssh2 will in the future use a heuristic
to determine which actual extension to use. I don't want that.

I do.

If there would appear another way to fsync in a future, we can introduce either a way for libssh2 to figure out by itself what method to use, or
we provide an API for the application to select method.

At a minimum, I'd like a follow up patch which changes the API name to<= br> libssh2_sftp_fsync_openssh_com() or such..

Why do think this is necessary? I don't think we do a service to our users by exposing the underlying protocol naming in our function names.
I also suspect that we won't be flooded by lots of other fsync
variations either...

what about something like that:

#define LIBSSH2_FSYNC_AUTO 0
#define LIBSSH2_FSYNC_OPENSSH 1

libssh2_sftp_fsync(LIBSSH2_FSYNC_OPENSSH, ...)

this way the function name could stay also in the future, users of the func= tion can select the method to use, and it would be possible to select an au= tomatic way if it can be implemented ...

The intentions are good, but we're overengineering here.= =A0 Is any standard version of this feature realistically going to have an = incompatible API?=A0 And if, despite sensible predicitons, it is incompatib= le, is it really the end of the world?=A0 We just add a second API call and= combine them at the next soname bump.=A0 Our API is littered with sub-opti= mal APIs waiting for the ABI-change green light.

Alex

--
Swish - Easy SFTP for Windows Explorer (= http://www.swish-sf= tp.org)