From libssh2-devel-bounces@cool.haxx.se Tue Dec 2 14:58:47 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB2Dw8Rs000360; Tue, 2 Dec 2014 14:58:40 +0100 Received: from node176.itex.at (mail.123x.at [194.242.35.176]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB2Dw6tK032712 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 2 Dec 2014 14:58:06 +0100 Received: from localhost (localhost [127.0.0.1]) by node176.itex.at (Postfix) with ESMTP id 5BBC620364 for ; Tue, 2 Dec 2014 14:58:09 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at node176.itex.at Received: from node176.itex.at ([127.0.0.1]) by localhost (node176.itex.at [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ViMTydXMMBVh for ; Tue, 2 Dec 2014 14:57:59 +0100 (CET) Received: from [172.17.100.8] (ip-109-90-201-94.hsi11.unitymediagroup.de [109.90.201.94]) (Authenticated sender: lists@gknw.net) by node176.itex.at (Postfix) with ESMTPSA id 7ECC91FFE0 for ; Tue, 2 Dec 2014 14:57:59 +0100 (CET) Message-ID: <547DC561.7070302@gknw.net> Date: Tue, 02 Dec 2014 14:57:53 +0100 From: Guenter User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: libssh2 development Subject: time for 1.4.4 ? X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id sB2Dw6tK032712 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB2Dw8Rs000360 Hi all, its now more than 2 years since the release of 1.4.3, and since then a couple of things were fixed or new introduced; last commits were about 3 months ago, so things should have settled ... anything against a soonish release? Maybe as christmas gift for our users ... Gün. _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 2 16:35:05 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB2FYlAc011020; Tue, 2 Dec 2014 16:35:03 +0100 Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [IPv6:2a00:1450:400c:c00::22c]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB2FYkXu011006 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128 verify=NOT) for ; Tue, 2 Dec 2014 16:34:46 +0100 Received: by mail-wg0-f44.google.com with SMTP id b13so17379879wgh.3 for ; Tue, 02 Dec 2014 07:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=google; h=from:content-type:subject:message-id:date:to:mime-version; bh=U5y443BaapxNucD5VnLHtTrIuoIDQaCz3YxW7LPBaxY=; b=ZPW/DmCMA76gokENeg67CwoFnMlBIa47kz6MplMF0IWtbPWenfeelEXti3PtLXcCpV rw8y2DU1/MY8NVYOjRUEm0MlkdWzKd5Q8hGx1+jVVRra5VnAAaUWuWMI45eVflSaadVC 1IzlyDgb5+HZZoMNb10NWkgRk/aOG+ySRVRqY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:content-type:subject:message-id:date:to :mime-version; bh=U5y443BaapxNucD5VnLHtTrIuoIDQaCz3YxW7LPBaxY=; b=YMkkswH6BvzCWnLEUvMRrnajQaEqWTkZYmeEjE/oYfoYY2KQMe8DaaX5/ShKvcDFzT NF5bhweyBmR5pA7xdHunuV3+CqLM3/TGe9LUpedRKiyPV1iz/P0ZKMEJwK0dslIhC3Hh vWAEWjlruPPXA/ifnLsRvb3coVkhIF85/syOnqjXuLAvCYvO1A2sbnieb/Ucx9t3YhjD 5TRsNakkP87GA2GRsJWpQBUYJBN4kPFpfl/8B9HEXGUiz+b7uJwTzFgwKtOZ+SAZjO1D bKqg+1HfhInJTKpqPY7lpSWfITchwixp8/sGaD8vXgGBNv0FTI/hYwJ5E0bjdlYv8QZH aTDw== X-Gm-Message-State: ALoCoQmCdicA7rP8D37s5h4WYkduhAPGah433+8SZSORy6SQRBLp7BKcV8PMRSyrgMUW5YgFjjp8bt4m5UvMWhVpON04yh6GXQD0T7RgMLALUDL62cNiocxA5uQJKt+7pyBAzeuK5bLqbvvy/gOSmcFL7HZgQGSWa99bBMf3wrGey/r1nrzJAyw= X-Received: by 10.180.228.72 with SMTP id sg8mr83873631wic.48.1417534481645; Tue, 02 Dec 2014 07:34:41 -0800 (PST) Received: from [10.28.0.66] (host86-161-50-90.range86-161.btcentralplus.com. [86.161.50.90]) by mx.google.com with ESMTPSA id ej10sm7529524wib.1.2014.12.02.07.34.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Dec 2014 07:34:40 -0800 (PST) From: Keith Duncan Subject: Added OS X Native Crypto Support Message-Id: <2F4A8848-B423-49E9-AC0D-A2A90D08B885@github.com> Date: Tue, 2 Dec 2014 15:34:33 +0000 To: libssh2-devel@cool.haxx.se Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) X-Mailer: Apple Mail (2.1993) X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1365902784==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============1365902784== Content-Type: multipart/alternative; boundary="Apple-Mail=_ED1B839C-84E7-43CE-970F-7AA9634C04FF" --Apple-Mail=_ED1B839C-84E7-43CE-970F-7AA9634C04FF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hello everyone, Similar to the WinCNG crypto backend I=E2=80=99ve added support for = using the OS X native crypto support as a libssh2 crypto backend. https://github.com/keithduncan/libssh2 = SHA1 and MD5 hashes HMAC_SHA1 and HMAC_MD5 signatures It supports both [RSA and = DSA](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7ed5793d08= de69be6858dc62c/src/securetransport.h#L39-L40 = ) asymmetric encryption. Multiple RSA private key = [formats](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7ed57= 93d08de69be6858dc62c/src/securetransport.c#L663-L668 = ) Multiple DSA private key = [formats](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7ed57= 93d08de69be6858dc62c/src/securetransport.c#L1000-L1005 = ). Private -> Public key file = [conversion](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7e= d5793d08de69be6858dc62c/src/securetransport.c#L1382 = ). [AES, Blowfish, RC4, CAST, = 3DES](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7ed5793d0= 8de69be6858dc62c/src/securetransport.h#L51-L56 = ) symmetric encryption. CCCryptorRef claims to implement AES CTR mode but returns an = unimplemented error at runtime. It looks like Nick Zitzmann also started a similar project in 2012 but = discovered that there=E2=80=99s no public BigNum API in OS X = http://lists.apple.com/archives/apple-cdsa/2012/Aug/msg00009.html = I ran in to the same issue but went ahead and used the private BigNum = API he references. For this reason I=E2=80=99m not sure that this would = be a good candidate for submitting upstream. Then again perhaps it could = serve as a compelling reason for the API to be made public if it would = enable OS X native SSH2 crypto. I hope this is of interest, let me know if there=E2=80=99s any interest = in a patch. Cheers, Keith --Apple-Mail=_ED1B839C-84E7-43CE-970F-7AA9634C04FF Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hello everyone,

Similar to the WinCNG crypto backend I=E2=80=99ve added = support for using the OS X native crypto support as a libssh2 crypto = backend.

https://github.com/keithduncan/libssh2

SHA1 and MD5 = hashes
HMAC_SHA1 and HMAC_MD5 signatures

It supports both [RSA = and DSA](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7ed5= 793d08de69be6858dc62c/src/securetransport.h#L39-L40) asymmetric = encryption.

Multiple RSA private key [formats](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7ed5= 793d08de69be6858dc62c/src/securetransport.c#L663-L668)
Multiple DSA private key [formats](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7ed5= 793d08de69be6858dc62c/src/securetransport.c#L1000-L1005).

Private -> Public key = file [conversion](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7ed5= 793d08de69be6858dc62c/src/securetransport.c#L1382).

[AES, Blowfish, RC4, = CAST, 3DES](https://github.com/keithduncan/libssh2/blob/f58d7de73e379ff7ed5= 793d08de69be6858dc62c/src/securetransport.h#L51-L56) symmetric = encryption.

CCCryptorRef claims to implement AES CTR mode but returns an = unimplemented error at runtime.

It looks like Nick Zitzmann also = started a similar project in 2012 but discovered that there=E2=80=99s no = public BigNum API in OS X http://lists.apple.com/archives/apple-cdsa/2012/Aug/msg00009.ht= ml

I ran = in to the same issue but went ahead and used the private BigNum API he = references. For this reason I=E2=80=99m not sure that this would be a = good candidate for submitting upstream. Then again perhaps it could = serve as a compelling reason for the API to be made public if it would = enable OS X native SSH2 crypto.

I hope this is of interest, let me know = if there=E2=80=99s any interest in a patch.

Cheers,
Keith

= --Apple-Mail=_ED1B839C-84E7-43CE-970F-7AA9634C04FF-- --===============1365902784== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============1365902784==-- From libssh2-devel-bounces@cool.haxx.se Tue Dec 2 16:40:32 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB2FeSuR019216; Tue, 2 Dec 2014 16:40:31 +0100 Received: from colibri.localdomain (ppp-93-104-33-154.dynamic.mnet-online.de [93.104.33.154]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB2FeQZF019212 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 2 Dec 2014 16:40:26 +0100 Received: by colibri.localdomain (Postfix, from userid 501) id E81D57B0A3; Tue, 2 Dec 2014 16:40:26 +0100 (CET) Date: Tue, 2 Dec 2014 16:40:26 +0100 From: Dan Fandrich To: libssh2-devel@cool.haxx.se Subject: Re: time for 1.4.4 ? Message-ID: <20141202154026.GB3206@coneharvesters.com> Mail-Followup-To: libssh2-devel@cool.haxx.se References: <547DC561.7070302@gknw.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <547DC561.7070302@gknw.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB2FeSuR019216 On Tue, Dec 02, 2014 at 02:57:53PM +0100, Guenter wrote: > Hi all, > its now more than 2 years since the release of 1.4.3, and since then > a couple of things were fixed or new introduced; last commits were > about 3 months ago, so things should have settled ... > anything against a soonish release? > Maybe as christmas gift for our users ... I was just thinking the same. There are a few potential security fixes in there as well. I think it's time to unleash it! >>> Dan _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Dec 3 15:32:25 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3EVvcx029970; Wed, 3 Dec 2014 15:32:20 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3EVthJ029964 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 3 Dec 2014 15:31:55 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id sB3EVtb4029961 for ; Wed, 3 Dec 2014 15:31:55 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 3 Dec 2014 15:31:55 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: time for 1.4.4 ? In-Reply-To: <20141202154026.GB3206@coneharvesters.com> Message-ID: References: <547DC561.7070302@gknw.net> <20141202154026.GB3206@coneharvesters.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3EVvcx029970 On Tue, 2 Dec 2014, Dan Fandrich wrote: > I was just thinking the same. There are a few potential security fixes in > there as well. I think it's time to unleash it! Yeah, it'd be nice and welcome. Previous release attempts were hold off due to "we just need X fixed first" so perhaps people can name what they "need" merged before we can do a release? If there's no major issue pending (and I think we can leave the native mac crypto for the next one), I'd like to do a release late next week. I think we should call it 1.5.0 though due to the new windows crypto backend (and possibly some more). -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Dec 3 20:15:51 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JFPAR021017; Wed, 3 Dec 2014 20:15:45 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JFOUO021008 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 3 Dec 2014 20:15:24 +0100 Received: (qmail 13780 invoked from network); 3 Dec 2014 19:16:43 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 3 Dec 2014 19:16:43 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Wed, 03 Dec 2014 19:16:43 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #287: LIBSSH2_FX_PERMISSION_DENIED on reading file from other user X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/287#comment:1 Message-ID: <060.ac6dec32fe91f80dac04368671f86185@libssh2.stuge.se> References: <045.6bdb5c97f79b38a31532dbaed5647b89@libssh2.stuge.se> X-Trac-Ticket-ID: 287 In-Reply-To: <045.6bdb5c97f79b38a31532dbaed5647b89@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JFOUO021008 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JFPAR021017 #287: LIBSSH2_FX_PERMISSION_DENIED on reading file from other user -----------------------+--------------------------------------- Reporter: pschultz | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: SFTP | Version: 1.4.2 Resolution: | Keywords: sftp open file permission Blocked By: | Blocks: -----------------------+--------------------------------------- Comment (by pschultz): What have I to do to get any answer? Am I really the only one with this problem? Did I make any errors on creating this ticket? Is it "read only"? I am very disappointed from libssh2.org. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Dec 3 20:15:58 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JFvnH021360; Wed, 3 Dec 2014 20:15:58 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JFtXt021348 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 3 Dec 2014 20:15:55 +0100 Received: (qmail 13930 invoked from network); 3 Dec 2014 19:17:14 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 3 Dec 2014 19:17:14 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Wed, 03 Dec 2014 19:17:14 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #288: Maximum concurrent connections to uniq servers X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/288 Message-ID: <045.dc250e6df202420df02b058541a1d53d@libssh2.stuge.se> X-Trac-Ticket-ID: 288 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JFtXt021348 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JFvnH021360 #288: Maximum concurrent connections to uniq servers ---------------------------------+--------------------------- Reporter: dsyeager | Owner: Scott Yeager Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: API | Version: 1.4.2 Keywords: Maximum Connections | Blocked By: Blocks: | ---------------------------------+--------------------------- I'm developing with the latest libssh2, both the stable and daily versions, on Ubuntu 10.04 and 12.04. Is there a known maximum number of concurrent connections to unique servers? I am writing an event driven (non blocking) application that connects, using ssh, to and runs commands on N servers concurrently. If I limit it to 1000 concurrent connections it works good. If I raise the limit to 1100 or higher I get cores that look like memory overwrites with NULL/0's. I'm assuming that it is not in my framework because the same underlying code works good with concurrent HTTP(S) connections. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Dec 3 20:16:04 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JG4lj021560; Wed, 3 Dec 2014 20:16:04 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JG38d021555 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 3 Dec 2014 20:16:03 +0100 Received: (qmail 13960 invoked from network); 3 Dec 2014 19:17:23 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 3 Dec 2014 19:17:23 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Wed, 03 Dec 2014 19:17:23 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #289: Configure check for EVP_aes_128_ctr does not work properly X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/289 Message-ID: <045.19b533fbe85958c92ff6d2ad08fd491c@libssh2.stuge.se> X-Trac-Ticket-ID: 289 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JG38d021555 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JG4lj021560 #289: Configure check for EVP_aes_128_ctr does not work properly --------------------------------------+-------------------- Reporter: maurerpe | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: misc | Version: 1.4.2 Keywords: autoconf EVP_aes_128_ctr | Blocked By: Blocks: | --------------------------------------+-------------------- configure never detects EVP_aes_128_ctr even when it is present in openssl. I have confirmed this in libssh2 1.4.3 using both openssl 1.0.1h and libressl 2.0.5. The issue seems to be the order in which libraries appear on the command line for the configure test. I have a simple patch that resolves the issue and causes libssh2 to properly detect EVP_aes_128_ctr for both openssl and libressl. The solution is to use put the libs (-lcrypto -lssl) in the LIBS variable and not the LDFLAGS variable. Patch attached. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Dec 3 20:16:54 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JGql4027248; Wed, 3 Dec 2014 20:16:54 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JGpDI027244 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 3 Dec 2014 20:16:51 +0100 Received: (qmail 14161 invoked from network); 3 Dec 2014 19:18:10 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 3 Dec 2014 19:18:10 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Wed, 03 Dec 2014 19:18:10 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #290: segfault in diffie_hellman_sha1 X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/290 Message-ID: <043.cce56a14b3bf52ccab3a2d7cd67bd8f3@libssh2.stuge.se> X-Trac-Ticket-ID: 290 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JGpDI027244 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JGql4027248 #290: segfault in diffie_hellman_sha1 --------------------+-------------------- Reporter: mstrsn | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: crypto | Version: 1.4.2 Keywords: | Blocked By: Blocks: | --------------------+-------------------- If an application happens to call the OpenSSL routine EVP_cleanup, then libssh2 will generate a segfault at the call to libssh2_sh1_update at line 249 in kex.c. Of course, the application should not call EVP_cleanup prematurely, but to avoid crashes in your library, I suggest you guard against this possibility in a manner similar to your guard around the call to libssh2_md5_update at line 222 in kex.c. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Dec 3 20:17:10 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JH97p027651; Wed, 3 Dec 2014 20:17:10 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JH8Ps027646 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 3 Dec 2014 20:17:08 +0100 Received: (qmail 14224 invoked from network); 3 Dec 2014 19:18:28 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 3 Dec 2014 19:18:28 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Wed, 03 Dec 2014 19:18:28 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #291: libssh2_agent_connect always returns -39 when using in on iOS X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/291 Message-ID: <043.8c2655804146d6ddbbf0357167280655@libssh2.stuge.se> X-Trac-Ticket-ID: 291 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JH8Ps027646 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JH97p027651 #291: libssh2_agent_connect always returns -39 when using in on iOS --------------------+-------------------- Reporter: ali312 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: API | Version: 1.4.2 Keywords: | Blocked By: Blocks: | --------------------+-------------------- I'm trying to use lissh2 agent in my iOS app I've tried several different ways, even completely copy&paste in an empty http://www.libssh2.org/examples/ssh2_agent.html And when I get to libssh2_agent_connect it always returns -39 All other methods work good -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Dec 3 20:17:33 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JHVqY027817; Wed, 3 Dec 2014 20:17:33 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB3JHT6l027801 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 3 Dec 2014 20:17:29 +0100 Received: (qmail 14351 invoked from network); 3 Dec 2014 19:18:49 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 3 Dec 2014 19:18:49 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Wed, 03 Dec 2014 19:18:49 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #292: Wrap all uses of socket with callbacks for better compatibility X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/292 Message-ID: <045.566659c6c868dc0804d29e0f4b7ab459@libssh2.stuge.se> X-Trac-Ticket-ID: 292 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JHT6l027801 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB3JHVqY027817 #292: Wrap all uses of socket with callbacks for better compatibility -------------------------+------------------ Reporter: Eschaton | Owner: Type: enhancement | Status: new Priority: normal | Milestone: Component: API | Version: Keywords: | Blocked By: Blocks: | -------------------------+------------------ Only a subset of the functions used on a socket/fd passed into libssh2 are wrapped in standard callbacks. For example, libssh2 will still invoke the stock select/poll and ioctl functions on a socket it's passed, to do things like check for I/O and control non-blocking behavior. This makes it between difficult and impossible to use libssh2 (without significant modification) over another transport, or even over a socket where full control can't be given to the library (such as a socket managed via dispatch I/O on OS X or iOS). If all calls on the socket used by libssh2 always went through semantic callback wrappers (eg "set non blocking," "set reusable" and so on, rather than "do an ioctl") then it would be possible to use libssh2 with an entirely-application-layer transport. It might also make it easier to abstract -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Dec 4 20:37:33 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4JatjL016835; Thu, 4 Dec 2014 20:37:27 +0100 Received: from mail05.wwi.dk (mail05.wwi.dk [91.194.36.75]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4JarPi016774 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Thu, 4 Dec 2014 20:36:53 +0100 Received: from 0x5552c397.adsl.cybercity.dk ([85.82.195.151] helo=[192.0.0.28]) by mail05.wwi.dk with esmtp (Exim 4.80.1) (envelope-from ) id 1XwcCl-0003iW-Et for libssh2-devel@cool.haxx.se; Thu, 04 Dec 2014 20:36:47 +0100 Message-ID: <1417721766.28893.6.camel@think2> Subject: gcc -V causes ubuntu 14.04 compile failure? From: Niels Larsen To: libssh2-devel@cool.haxx.se Organization: Danish Genome Institute Content-Type: multipart/mixed; boundary="=-2MWeEpvEwmbWP/NPJIRn" Date: Thu, 04 Dec 2014 20:36:06 +0100 Mime-Version: 1.0 X-Mailer: Evolution 3.10.4-0ubuntu2 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --=-2MWeEpvEwmbWP/NPJIRn Content-Type: text/plain; charset="ISO-8859-2" Content-Transfer-Encoding: 7bit Libssh2 people, On stock Ubuntu 14.04 (Linux 64 bit) I get: ~/BION/Software/Package_sources/Utilities/libssh2-1.4.3> ./configure checking whether to enable maintainer-specific portions of Makefiles... no checking for sed... /bin/sed checking for a BSD-compatible install... /home/bion/BION/Software/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /home/bion/BION/Software/bin/mkdir -p checking for gawk... no checking for mawk... mawk checking whether make sets $(MAKE)... yes checking libssh2 version... 1.4.3 checking build system type... x86_64-unknown-linux-gnu checking host system type... x86_64-unknown-linux-gnu configure: autobuild project... libssh2 configure: autobuild revision... 1.4.3 configure: autobuild hostname... bion-VirtualBox configure: autobuild timestamp... 20141204-202652 checking for style of include used by make... GNU checking for gcc... gcc checking whether the C compiler works... no configure: error: in `/home/bion/BION/Software/Package_sources/Utilities/libssh2-1.4.3': configure: error: C compiler cannot create executables See `config.log' for more details ~/BION/Software/Package_sources/Utilities/libssh2-1.4.3> and config.log is attached. It looks as if gcc is given the -V argument, which gcc does not understand anymore. The latest daily snapshot (december 4) behaves the same. Can someone tell me where to edit if there is an easy fix, or better, post an update with the fix? Niels L --=-2MWeEpvEwmbWP/NPJIRn Content-Disposition: attachment; filename="config.log" Content-Type: text/x-log; name="config.log"; charset="ISO-8859-2" Content-Transfer-Encoding: quoted-printable This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by libssh2 configure -, which was generated by GNU Autoconf 2.69. Invocation command line was $ ./configure=20 ## --------- ## ## Platform. ## ## --------- ## hostname =3D bion-VirtualBox uname -m =3D x86_64 uname -r =3D 3.13.0-32-generic uname -s =3D Linux uname -v =3D #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014 /usr/bin/uname -p =3D unknown /bin/uname -X =3D unknown /bin/arch =3D unknown /usr/bin/arch -k =3D unknown /usr/convex/getsysinfo =3D unknown /usr/bin/hostinfo =3D unknown /bin/machine =3D unknown /usr/bin/oslevel =3D unknown /bin/universe =3D unknown PATH: /home/bion/BION/Software/bin PATH: /usr/sbin PATH: ~/bin PATH: ~/admin PATH: . PATH: /usr/local/sbin PATH: /usr/local/bin PATH: /usr/sbin PATH: /usr/bin PATH: /sbin PATH: /bin PATH: /usr/games PATH: /usr/local/games ## ----------- ## ## Core tests. ## ## ----------- ## configure:2324: checking whether to enable maintainer-specific portions of = Makefiles configure:2333: result: no configure:2349: checking for sed configure:2368: found /bin/sed configure:2381: result: /bin/sed configure:2442: checking for a BSD-compatible install configure:2510: result: /home/bion/BION/Software/bin/install -c configure:2521: checking whether build environment is sane configure:2571: result: yes configure:2712: checking for a thread-safe mkdir -p configure:2751: result: /home/bion/BION/Software/bin/mkdir -p configure:2764: checking for gawk configure:2794: result: no configure:2764: checking for mawk configure:2780: found /usr/bin/mawk configure:2791: result: mawk configure:2802: checking whether make sets $(MAKE) configure:2824: result: yes configure:2904: checking libssh2 version configure:2906: result: 1.4.3 configure:2917: checking build system type configure:2931: result: x86_64-unknown-linux-gnu configure:2951: checking host system type configure:2964: result: x86_64-unknown-linux-gnu configure:2991: autobuild project... libssh2 configure:2997: autobuild revision... 1.4.3 configure:3002: autobuild hostname... bion-VirtualBox configure:3013: autobuild timestamp... 20141204-202652 configure:3054: checking for style of include used by make configure:3082: result: GNU configure:3153: checking for gcc configure:3169: found /usr/bin/gcc configure:3180: result: gcc configure:3409: checking for C compiler version configure:3418: gcc --version >&5 gcc (Ubuntu 4.8.2-19ubuntu1) 4.8.2 Copyright (C) 2013 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. configure:3429: $? =3D 0 configure:3418: gcc -v >&5 Using built-in specs. COLLECT_GCC=3Dgcc COLLECT_LTO_WRAPPER=3D/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion=3D'Ubuntu 4.8.2-19ub= untu1' --with-bugurl=3Dfile:///usr/share/doc/gcc-4.8/README.Bugs --enable-l= anguages=3Dc,c++,java,go,d,fortran,objc,obj-c++ --prefix=3D/usr --program-s= uffix=3D-4.8 --enable-shared --enable-linker-build-id --libexecdir=3D/usr/l= ib --without-included-gettext --enable-threads=3Dposix --with-gxx-include-d= ir=3D/usr/include/c++/4.8 --libdir=3D/usr/lib --enable-nls --with-sysroot= =3D/ --enable-clocale=3Dgnu --enable-libstdcxx-debug --enable-libstdcxx-tim= e=3Dyes --enable-gnu-unique-object --disable-libmudflap --enable-plugin --w= ith-system-zlib --disable-browser-plugin --enable-java-awt=3Dgtk --enable-g= tk-cairo --with-java-home=3D/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64/jre --ena= ble-java-home --with-jvm-root-dir=3D/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64 -= -with-jvm-jar-dir=3D/usr/lib/jvm-exports/java-1.5.0-gcj-4.8-amd64 --with-ar= ch-directory=3Damd64 --with-ecj-jar=3D/usr/share/java/eclipse-ecj.jar --ena= ble-objc-gc --enable-multiarch --disable-werror --with-arch-32=3Di686 --wit= h-abi=3Dm64 --with-multilib-list=3Dm32,m64,mx32 --with-tune=3Dgeneric --ena= ble-checking=3Drelease --build=3Dx86_64-linux-gnu --host=3Dx86_64-linux-gnu= --target=3Dx86_64-linux-gnu Thread model: posix gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1)=20 configure:3429: $? =3D 0 configure:3418: gcc -V >&5 gcc: error: unrecognized command line option '-V' gcc: fatal error: no input files compilation terminated. configure:3429: $? =3D 4 configure:3418: gcc -qversion >&5 gcc: error: unrecognized command line option '-qversion' gcc: fatal error: no input files compilation terminated. configure:3429: $? =3D 4 configure:3449: checking whether the C compiler works configure:3471: gcc -arch x86_64 -arch x86_64 conftest.c >&5 gcc: error: x86_64: No such file or directory gcc: error: x86_64: No such file or directory gcc: error: unrecognized command line option '-arch' gcc: error: unrecognized command line option '-arch' configure:3475: $? =3D 1 configure:3513: result: no configure: failed program was: | /* confdefs.h */ | #define PACKAGE_NAME "libssh2" | #define PACKAGE_TARNAME "libssh2" | #define PACKAGE_VERSION "-" | #define PACKAGE_STRING "libssh2 -" | #define PACKAGE_BUGREPORT "libssh2-devel@cool.haxx.se" | #define PACKAGE_URL "" | #define PACKAGE "libssh2" | #define VERSION "-" | /* end confdefs.h. */ |=20 | int | main () | { |=20 | ; | return 0; | } configure:3518: error: in `/home/bion/BION/Software/Package_sources/Utiliti= es/libssh2-1.4.3': configure:3520: error: C compiler cannot create executables See `config.log' for more details ## ---------------- ## ## Cache variables. ## ## ---------------- ## ac_cv_build=3Dx86_64-unknown-linux-gnu ac_cv_env_CC_set=3D ac_cv_env_CC_value=3D ac_cv_env_CFLAGS_set=3Dset ac_cv_env_CFLAGS_value=3D'-arch x86_64' ac_cv_env_CPPFLAGS_set=3D ac_cv_env_CPPFLAGS_value=3D ac_cv_env_CPP_set=3D ac_cv_env_CPP_value=3D ac_cv_env_LDFLAGS_set=3Dset ac_cv_env_LDFLAGS_value=3D'-arch x86_64' ac_cv_env_LIBS_set=3D ac_cv_env_LIBS_value=3D ac_cv_env_build_alias_set=3D ac_cv_env_build_alias_value=3D ac_cv_env_host_alias_set=3D ac_cv_env_host_alias_value=3D ac_cv_env_target_alias_set=3D ac_cv_env_target_alias_value=3D ac_cv_host=3Dx86_64-unknown-linux-gnu ac_cv_path_SED=3D/bin/sed ac_cv_path_install=3D'/home/bion/BION/Software/bin/install -c' ac_cv_path_mkdir=3D/home/bion/BION/Software/bin/mkdir ac_cv_prog_AWK=3Dmawk ac_cv_prog_ac_ct_CC=3Dgcc ac_cv_prog_make_make_set=3Dyes ## ----------------- ## ## Output variables. ## ## ----------------- ## ACLOCAL=3D'${SHELL} /home/bion/BION/Software/Package_sources/Utilities/libs= sh2-1.4.3/missing --run aclocal-1.11' ALLOCA=3D'' AMDEPBACKSLASH=3D'\' AMDEP_FALSE=3D'#' AMDEP_TRUE=3D'' AMTAR=3D'$${TAR-tar}' AR=3D'' AS=3D'' AUTOCONF=3D'${SHELL} /home/bion/BION/Software/Package_sources/Utilities/lib= ssh2-1.4.3/missing --run autoconf' AUTOHEADER=3D'${SHELL} /home/bion/BION/Software/Package_sources/Utilities/l= ibssh2-1.4.3/missing --run autoheader' AUTOMAKE=3D'${SHELL} /home/bion/BION/Software/Package_sources/Utilities/lib= ssh2-1.4.3/missing --run automake-1.11' AWK=3D'mawk' BUILD_EXAMPLES_FALSE=3D'' BUILD_EXAMPLES_TRUE=3D'' CC=3D'gcc' CCDEPMODE=3D'' CFLAGS=3D'-arch x86_64' CPP=3D'' CPPFLAGS=3D'' CYGPATH_W=3D'echo' DEFS=3D'' DEPDIR=3D'.deps' DLLTOOL=3D'' DSYMUTIL=3D'' DUMPBIN=3D'' ECHO_C=3D'' ECHO_N=3D'-n' ECHO_T=3D'' EGREP=3D'' EXEEXT=3D'' FGREP=3D'' GREP=3D'' HAVE_LIBGCRYPT=3D'' HAVE_LIBSSL=3D'' HAVE_LIBZ=3D'' HAVE_SYS_UN_H_FALSE=3D'' HAVE_SYS_UN_H_TRUE=3D'' INSTALL_DATA=3D'${INSTALL} -m 644' INSTALL_PROGRAM=3D'${INSTALL}' INSTALL_SCRIPT=3D'${INSTALL}' INSTALL_STRIP_PROGRAM=3D'$(install_sh) -c -s' LD=3D'' LDFLAGS=3D'-arch x86_64' LIBGCRYPT=3D'' LIBGCRYPT_FALSE=3D'' LIBGCRYPT_PREFIX=3D'' LIBGCRYPT_TRUE=3D'' LIBOBJS=3D'' LIBS=3D'' LIBSREQUIRED=3D'' LIBSSH2VER=3D'1.4.3' LIBSSL=3D'' LIBSSL_PREFIX=3D'' LIBTOOL=3D'' LIBZ=3D'' LIBZ_PREFIX=3D'' LIPO=3D'' LN_S=3D'' LTLIBGCRYPT=3D'' LTLIBOBJS=3D'' LTLIBSSL=3D'' LTLIBZ=3D'' MAINT=3D'#' MAINTAINER_MODE_FALSE=3D'' MAINTAINER_MODE_TRUE=3D'#' MAKEINFO=3D'${SHELL} /home/bion/BION/Software/Package_sources/Utilities/lib= ssh2-1.4.3/missing --run makeinfo' MANIFEST_TOOL=3D'' MKDIR_P=3D'/home/bion/BION/Software/bin/mkdir -p' NM=3D'' NMEDIT=3D'' OBJDUMP=3D'' OBJEXT=3D'' OTOOL64=3D'' OTOOL=3D'' PACKAGE=3D'libssh2' PACKAGE_BUGREPORT=3D'libssh2-devel@cool.haxx.se' PACKAGE_NAME=3D'libssh2' PACKAGE_STRING=3D'libssh2 -' PACKAGE_TARNAME=3D'libssh2' PACKAGE_URL=3D'' PACKAGE_VERSION=3D'-' PATH_SEPARATOR=3D':' RANLIB=3D'' SED=3D'/bin/sed' SET_MAKE=3D'' SHELL=3D'/bin/bash' SSHD=3D'' SSHD_FALSE=3D'' SSHD_TRUE=3D'' STRIP=3D'' VERSION=3D'-' ac_ct_AR=3D'' ac_ct_CC=3D'gcc' ac_ct_DUMPBIN=3D'' am__EXEEXT_FALSE=3D'' am__EXEEXT_TRUE=3D'' am__fastdepCC_FALSE=3D'' am__fastdepCC_TRUE=3D'' am__include=3D'include' am__isrc=3D'' am__leading_dot=3D'.' am__nodep=3D'_no' am__quote=3D'' am__tar=3D'$${TAR-tar} chof - "$$tardir"' am__untar=3D'$${TAR-tar} xf -' bindir=3D'${exec_prefix}/bin' build=3D'x86_64-unknown-linux-gnu' build_alias=3D'' build_cpu=3D'x86_64' build_os=3D'linux-gnu' build_vendor=3D'unknown' datadir=3D'${datarootdir}' datarootdir=3D'${prefix}/share' docdir=3D'${datarootdir}/doc/${PACKAGE_TARNAME}' dvidir=3D'${docdir}' exec_prefix=3D'NONE' host=3D'x86_64-unknown-linux-gnu' host_alias=3D'' host_cpu=3D'x86_64' host_os=3D'linux-gnu' host_vendor=3D'unknown' htmldir=3D'${docdir}' includedir=3D'${prefix}/include' infodir=3D'${datarootdir}/info' install_sh=3D'${SHELL} /home/bion/BION/Software/Package_sources/Utilities/l= ibssh2-1.4.3/install-sh' libdir=3D'${exec_prefix}/lib' libexecdir=3D'${exec_prefix}/libexec' localedir=3D'${datarootdir}/locale' localstatedir=3D'${prefix}/var' mandir=3D'${datarootdir}/man' mkdir_p=3D'/home/bion/BION/Software/bin/mkdir -p' oldincludedir=3D'/usr/include' pdfdir=3D'${docdir}' prefix=3D'NONE' program_transform_name=3D's,x,x,' psdir=3D'${docdir}' sbindir=3D'${exec_prefix}/sbin' sharedstatedir=3D'${prefix}/com' sysconfdir=3D'${prefix}/etc' target_alias=3D'' ## ----------- ## ## confdefs.h. ## ## ----------- ## /* confdefs.h */ #define PACKAGE_NAME "libssh2" #define PACKAGE_TARNAME "libssh2" #define PACKAGE_VERSION "-" #define PACKAGE_STRING "libssh2 -" #define PACKAGE_BUGREPORT "libssh2-devel@cool.haxx.se" #define PACKAGE_URL "" #define PACKAGE "libssh2" #define VERSION "-" configure: exit 77 --=-2MWeEpvEwmbWP/NPJIRn Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --=-2MWeEpvEwmbWP/NPJIRn-- From libssh2-devel-bounces@cool.haxx.se Thu Dec 4 20:54:26 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4JsJb8004872; Thu, 4 Dec 2014 20:54:24 +0100 Received: from colibri.localdomain (ppp-93-104-47-67.dynamic.mnet-online.de [93.104.47.67]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4JsHj4004864 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 4 Dec 2014 20:54:18 +0100 Received: by colibri.localdomain (Postfix, from userid 501) id 35746FE11; Thu, 4 Dec 2014 20:54:18 +0100 (CET) Date: Thu, 4 Dec 2014 20:54:18 +0100 From: Dan Fandrich To: libssh2-devel@cool.haxx.se Subject: Re: gcc -V causes ubuntu 14.04 compile failure? Message-ID: <20141204195418.GA7523@coneharvesters.com> Mail-Followup-To: libssh2-devel@cool.haxx.se References: <1417721766.28893.6.camel@think2> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1417721766.28893.6.camel@think2> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB4JsJb8004872 On Thu, Dec 04, 2014 at 08:36:06PM +0100, Niels Larsen wrote: > Libssh2 people, > > On stock Ubuntu 14.04 (Linux 64 bit) I get: > > ~/BION/Software/Package_sources/Utilities/libssh2-1.4.3> ./configure > checking whether to enable maintainer-specific portions of Makefiles... > no > checking for sed... /bin/sed [...] > and config.log is attached. It looks as if gcc is given the -V argument, > which > gcc does not understand anymore. That doesn't seem to be the issue. The issue is > configure:3449: checking whether the C compiler works > configure:3471: gcc -arch x86_64 -arch x86_64 conftest.c >&5 > gcc: error: x86_64: No such file or directory > gcc: error: x86_64: No such file or directory > gcc: error: unrecognized command line option '-arch' > gcc: error: unrecognized command line option '-arch' > configure:3475: $? = 1 > configure:3513: result: no There is an unsupported option -arch being specified somewhere, and not once, but twice. It's likely to be in a CFLAGS environment variable. Try cleaning that variable and related ones (like CPPFLAGS, LDFLAGS, LIBS) and try again. >>> Dan _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Dec 4 20:58:47 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4Jwj9l008688; Thu, 4 Dec 2014 20:58:47 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4Jwh89008683 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 4 Dec 2014 20:58:43 +0100 Received: (qmail 1720 invoked from network); 4 Dec 2014 20:00:03 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 4 Dec 2014 20:00:03 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Thu, 04 Dec 2014 20:00:03 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #287: LIBSSH2_FX_PERMISSION_DENIED on reading file from other user X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/287#comment:2 Message-ID: <060.6170657dff6b9c956e4e48ffe35c2c92@libssh2.stuge.se> References: <045.6bdb5c97f79b38a31532dbaed5647b89@libssh2.stuge.se> X-Trac-Ticket-ID: 287 In-Reply-To: <045.6bdb5c97f79b38a31532dbaed5647b89@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB4Jwh89008683 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB4Jwj9l008688 #287: LIBSSH2_FX_PERMISSION_DENIED on reading file from other user -----------------------+--------------------------------------- Reporter: pschultz | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: SFTP | Version: 1.4.2 Resolution: | Keywords: sftp open file permission Blocked By: | Blocks: -----------------------+--------------------------------------- Comment (by bagder): This project is just seriously undermanned and underpowered. If you have specific questions then I suggest trying to ask them on the mailing list. We're all volunteers and I personally have had little time or energy for libssh2 lately. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Dec 4 21:01:27 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4K1Opm015136; Thu, 4 Dec 2014 21:01:26 +0100 Received: from homiemail-a5.g.dreamhost.com (homie.mail.dreamhost.com [208.97.132.208]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4K1LIA015125 for ; Thu, 4 Dec 2014 21:01:21 +0100 Received: from homiemail-a5.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a5.g.dreamhost.com (Postfix) with ESMTP id 437D2704071 for ; Thu, 4 Dec 2014 12:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=eschatologist.net; h= content-type:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to; s= eschatologist.net; bh=xha9edic3J5o9eN8GLc/1htr/d4=; b=12o9kd/2/C /Cq2kzlSex/YehZ8Wb2IxFYDTnn4xJX5+qW5M6CsQeHeVdveHwFaWiM9sY5SYvKW fcUnRqkcB1qfA214sNdqU4lY6feyVv3zF8FHyDBrkAO0bmbLLVq2L2I5c/zNuSFX if9EmyW+n2Tnj0vhOozLsDp5v0ZR6lzgU= Received: from [10.0.1.203] (c-50-174-52-144.hsd1.ca.comcast.net [50.174.52.144]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cmhanson@eschatologist.net) by homiemail-a5.g.dreamhost.com (Postfix) with ESMTPSA id 3074170406E for ; Thu, 4 Dec 2014 12:01:21 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2064\)) Subject: Re: gcc -V causes ubuntu 14.04 compile failure? From: Chris Hanson In-Reply-To: <20141204195418.GA7523@coneharvesters.com> Date: Thu, 4 Dec 2014 12:01:20 -0800 Message-Id: References: <1417721766.28893.6.camel@think2> <20141204195418.GA7523@coneharvesters.com> To: libssh2 development X-Mailer: Apple Mail (2.2064) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id sB4K1LIA015125 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB4K1Opm015136 On Dec 4, 2014, at 11:54 AM, Dan Fandrich wrote: > There is an unsupported option -arch being specified somewhere, and not once, > but twice. It's likely to be in a CFLAGS environment variable. Try cleaning > that variable and related ones (like CPPFLAGS, LDFLAGS, LIBS) and try again. Passing “-arch x86_64” to the compiler is how you’d target 64-bit Intel on OS X and iOS, so perhaps there’s something making your build think it’s on a Darwin platform. -- Chris _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Dec 4 21:06:58 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4K6quR019832; Thu, 4 Dec 2014 21:06:57 +0100 Received: from mail05.wwi.dk (mail05.wwi.dk [91.194.36.75]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4K6p7g019689 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Thu, 4 Dec 2014 21:06:51 +0100 Received: from 0x5552c397.adsl.cybercity.dk ([85.82.195.151] helo=[192.0.0.28]) by mail05.wwi.dk with esmtp (Exim 4.80.1) (envelope-from ) id 1Xwcfm-0004Rt-2n for libssh2-devel@cool.haxx.se; Thu, 04 Dec 2014 21:06:46 +0100 Message-ID: <1417723577.2875.2.camel@think2> Subject: Re: gcc -V causes ubuntu 14.04 compile failure? From: Niels Larsen To: libssh2 development In-Reply-To: <20141204195418.GA7523@coneharvesters.com> References: <1417721766.28893.6.camel@think2> <20141204195418.GA7523@coneharvesters.com> Organization: Danish Genome Institute Date: Thu, 04 Dec 2014 21:06:17 +0100 Mime-Version: 1.0 X-Mailer: Evolution 3.10.4-0ubuntu2 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB4K6quR019832 Dan, Many thanks, that did it, great great. And Chris Hanson, yes, it had to do with that. Niels L - > That doesn't seem to be the issue. The issue is > > > configure:3449: checking whether the C compiler works > > configure:3471: gcc -arch x86_64 -arch x86_64 conftest.c >&5 > > gcc: error: x86_64: No such file or directory > > gcc: error: x86_64: No such file or directory > > gcc: error: unrecognized command line option '-arch' > > gcc: error: unrecognized command line option '-arch' > > configure:3475: $? = 1 > > configure:3513: result: no > > There is an unsupported option -arch being specified somewhere, and not once, > but twice. It's likely to be in a CFLAGS environment variable. Try cleaning > that variable and related ones (like CPPFLAGS, LDFLAGS, LIBS) and try again. > _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Dec 4 22:00:47 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4L0SYH001133; Thu, 4 Dec 2014 22:00:45 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4L0R98001062 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 4 Dec 2014 22:00:27 +0100 Received: (qmail 13233 invoked from network); 4 Dec 2014 21:01:47 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 4 Dec 2014 21:01:47 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Thu, 04 Dec 2014 21:01:47 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #288: Maximum concurrent connections to uniq servers X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/288#comment:1 Message-ID: <060.222ce937e545733ac2ec1d5cddd5e293@libssh2.stuge.se> References: <045.dc250e6df202420df02b058541a1d53d@libssh2.stuge.se> X-Trac-Ticket-ID: 288 In-Reply-To: <045.dc250e6df202420df02b058541a1d53d@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB4L0R98001062 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB4L0SYH001133 #288: Maximum concurrent connections to uniq servers -----------------------+--------------------------------- Reporter: dsyeager | Owner: Scott Yeager Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: API | Version: 1.4.2 Resolution: | Keywords: Maximum Connections Blocked By: | Blocks: -----------------------+--------------------------------- Comment (by bagder): Are you possibly using select() ? Then using file descriptors over 1024 is a common problem and source for pain and sorrow. Also, most *nix systems by default only allows 1024 concurrent open file descriptors. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Dec 4 22:45:53 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4LjeBb005970; Thu, 4 Dec 2014 22:45:50 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB4LjdjI005951 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 4 Dec 2014 22:45:39 +0100 Received: (qmail 21547 invoked from network); 4 Dec 2014 21:46:59 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 4 Dec 2014 21:46:59 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Thu, 04 Dec 2014 21:46:59 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #289: Configure check for EVP_aes_128_ctr does not work properly X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/289#comment:1 Message-ID: <060.26e84d7ee1ce1306df5247d5c69a6ab4@libssh2.stuge.se> References: <045.19b533fbe85958c92ff6d2ad08fd491c@libssh2.stuge.se> X-Trac-Ticket-ID: 289 In-Reply-To: <045.19b533fbe85958c92ff6d2ad08fd491c@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB4LjdjI005951 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB4LjeBb005970 #289: Configure check for EVP_aes_128_ctr does not work properly -----------------------+-------------------------------------- Reporter: maurerpe | Owner: bagder Type: defect | Status: closed Priority: normal | Milestone: 1.4.3 Component: misc | Version: 1.4.2 Resolution: fixed | Keywords: autoconf EVP_aes_128_ctr Blocked By: | Blocks: -----------------------+-------------------------------------- Changes (by bagder): * owner: => bagder * status: new => closed * resolution: => fixed Comment: In [changeset:"751e0087a874fe771db2748e5d11b29c50fd52bb/libssh2"]: {{{ #!CommitTicketReference repository="libssh2" revision="751e0087a874fe771db2748e5d11b29c50fd52bb" configure: change LIBS not LDFLAGS when checking for libs Closes #289 Patch-by: maurerpe }}} -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sat Dec 6 01:35:25 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB60YlWr023440; Sat, 6 Dec 2014 01:35:19 +0100 Received: from mail-wg0-x233.google.com (mail-wg0-x233.google.com [IPv6:2a00:1450:400c:c00::233]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB60YjmA023250 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128 verify=NOT) for ; Sat, 6 Dec 2014 01:34:45 +0100 Received: by mail-wg0-f51.google.com with SMTP id k14so2158414wgh.38 for ; Fri, 05 Dec 2014 16:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=OppKIXFRiIcsNAUs+HJV/iFbIm37pN7/2yKDLOVDv7Y=; b=GwHrheuZ7W2LJTUi2uw7ApJDXdfQ2bNi03tz9X1qdgs+les0BMNmmtHp6+KpDNGY7t Og3+HshR4CagirmqL8oSzpYAkpnvEZGuArECwCQ9sgovaBzeuIo/NDmlTNMH2OEwfQsn Vb5v73feoj75XCjaslqh3WAoLijQr69DoKUbIyu4ubHiy4mrsn3HKlypH5PUksOCt/rO 5nxJPKHf2a7IlZUe6cptEvpfx4ZaiR1WUvB7ZPXU01yQOA4/gOd3PqLpQDFLlG463Ojg bEtDatSYaArQa8jLD8kotH/juIWi2lm3qPzy3qFLJUL1IuxpdvaJhF2DqNm4mNtD/hlt WnnA== MIME-Version: 1.0 X-Received: by 10.194.61.18 with SMTP id l18mr27126607wjr.42.1417826081523; Fri, 05 Dec 2014 16:34:41 -0800 (PST) Received: by 10.194.22.232 with HTTP; Fri, 5 Dec 2014 16:34:41 -0800 (PST) Date: Sat, 6 Dec 2014 00:34:41 +0000 X-Google-Sender-Auth: EovhcOj2UwP2Wvnp8G430_4RLlc Message-ID: Subject: CMake From: Alexander Lamaison To: "development, libssh2" X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB60YlWr023440 You may recall that back in March I promised to convert the libssh2 build system to CMake 'soon'. Well, 9 months later, it is more or less complete: https://github.com/alamaison/libssh2/tree/cmake. I would greatly appreciate your feedback and help with testing on the platforms that matter to you. The goal is to match or exceed every relevant feature of the autotools system like-for-like, so, unless otherwise stated in this email, assume that any missing functionality is a bug. Please report it. CMake, however, is fundamentally different from autotools, so some features (for example, building source distributions, aka `make dist`) aren't relevant anymore and aren't specifically catered for. The README should get you started but, if you need help getting accustomed to CMake, I'm very happy to answer any questions you have. tl;dr - A version of libssh2 using CMake is available at https://github.com/alamaison/libssh2/tree/cmake - Please test Platform support ================ I've tested the build with the three major platforms, Linux (GCC 4.6.3, Clang 3.4), Windows (VS2005, VS2008) and MacOS X (AppleClang 6.0.0), in a variety of configurations. I've also set up continuous integration using Travis CI [2], so libssh2 is continually tested on Linux in 32 combinations of OpenSSL/Libgrypt, 32-bit/64-bit, GCC/Clang, shared/static, with/without zlib. I've not been able to test with VMS or Netware, two of the more unusual platforms that we support. I don't have access to that kind of hardware, so any help testing would be greatly appreciated. Why? ==== If you are wondering what benefits this change brings, there is plenty of discussion about this out there about the merits of CMake, but the main reasons that it makes sense for libssh2 are: 1) We were trying (failing?) to maintain build files by hand for non-autotool platforms such as Windows. As well as being a waste of effort, these custom jobds rarely kept up with libssh2 development. For example, they are hardcoded to use OpenSSL even though libssh2 supports multiple crypto backends. Using CMake we are now able to build libssh2 for all the common platforms and crypto backends using a single build configuration. When it is updated to accomodate a new feature, all platforms feel the benefit simultaneously. 2) Even if we supported your _platform_, our build setup restricted your choice of development environment to GNU Makefiles on Unix or Visual Studio 6 on Windows. Using CMake we can now generate the necessary files for your choosen environment: GNU Makefiles, Visual Studio 2005-2014, Xcode, Eclipse CDT ... and many more [1]. 3) CMake makes it easy to automatically fetch and build a projects as a component of a larger CMake project. This a big deal for a library. 4) For better or worse, CMake has won the latest war of the C/C++ build systems. This makes it the focus of new innovation and the support community is very active. As more and more projects are adopting it, they can take advantage of 3). What doesn't work yet? ====================== I've already mentioned that I've not been able to test VMS or Netware, so I'm going to assume that doesn't work simply because I've not done anything with the code in the `vms` and `nw` directories yet. It's possible that that code is redunant for CMake but, if not, I'll adjust the build files if a VMS/Netware user can explain to me what they need. Compiling with OpenWatcom works but I'm having trouble linking against OpenSSL. Using WinCNG also doesn't compile and it seems to be a SDK issue. Can anyone familiar with that compiler help me understand what extra steps are necessary? Another issue with OpenWatcom is that version 1.9 doesn't work if CMake is installed in a path containing spaces or parentheses. The bug is with the compiler, but I've filed a CMake issue to request a workaround [3]. Libssh2 inherited some complex compiler warning settings from cURL. I've not ported this to CMake yet because I want to understand the goal first, so that I can do this in a cross-platform way. For now, I've turned on -Wall or /W4. Would anyone like other warnings enabled? If so, which? Any changes committed to develop since I branched are not yet integrated into the cmake branch. That's the next job. Thanks for listening. Fire away. Alex [1] http://www.cmake.org/cmake/help/v3.1/manual/cmake-generators.7.html [2] https://travis-ci.org/alamaison/libssh2 [3] http://www.cmake.org/Bug/view.php?id=15279 -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Dec 8 14:47:11 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB8DjeUO014766; Mon, 8 Dec 2014 14:47:06 +0100 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB8DjbSA014718 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 8 Dec 2014 14:45:38 +0100 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB8DjaGB007751 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Dec 2014 08:45:36 -0500 Received: from kdudka.brq.redhat.com (kdudka.brq.redhat.com [10.34.4.67]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sB8DjYMD005244 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 8 Dec 2014 08:45:35 -0500 From: Kamil Dudka To: Alexander Lamaison Subject: Re: CMake Date: Mon, 08 Dec 2014 14:45:33 +0100 Message-ID: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> User-Agent: KMail/4.14.3 (Linux/3.17.4-301.fc21.x86_64; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB8DjeUO014766 On Saturday 06 December 2014 00:34:41 Alexander Lamaison wrote: > You may recall that back in March I promised to convert the libssh2 > build system to CMake 'soon'. Well, 9 months later, it is more or > less complete: https://github.com/alamaison/libssh2/tree/cmake. I > would greatly appreciate your feedback and help with testing on the > platforms that matter to you. > > The goal is to match or exceed every relevant feature of the autotools > system like-for-like, so, unless otherwise stated in this email, > assume that any missing functionality is a bug. Please report it. > > CMake, however, is fundamentally different from autotools, so some > features (for example, building source distributions, aka `make dist`) > aren't relevant anymore and aren't specifically catered for. The > README should get you started but, if you need help getting accustomed > to CMake, I'm very happy to answer any questions you have. > > tl;dr > - A version of libssh2 using CMake is available at > https://github.com/alamaison/libssh2/tree/cmake > - Please test Thank you for working on this! I got libssh2 successfully built for Fedora using CMake and your patchset: http://pkgs.fedoraproject.org/cgit/libssh2.git/commit/?id=213e752a http://koji.fedoraproject.org/koji/taskinfo?taskID=8321846 I have encountered a few minor issues: - The shared library is no longer versioned as it used to be. I have hard-coded the version into src/CMakeLists.txt for now: --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -186,7 +186,9 @@ endif() add_library(libssh2 ${SOURCES}) # we want it to be called libssh2 on all platforms -set_target_properties(libssh2 PROPERTIES PREFIX "") +set_target_properties(libssh2 PROPERTIES PREFIX "" + SOVERSION 1 + VERSION 1.0.1) target_compile_definitions(libssh2 PRIVATE ${PRIVATE_COMPILE_DEFINITIONS}) target_include_directories(libssh2 - The file libssh2.pc is no longer generated with CMake. Is there any plan to restore this functionality? - Man pages are not installed by CMake. - Before it goes to master, it would be good to merge some commits to make the history easier to follow. Namely the unnecessary renames of libssh2.h to libssh2.h.in and vice versa make the patchset difficult to apply on the latest upstream release. Kamil _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 9 01:47:22 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB90jx2R004597; Tue, 9 Dec 2014 01:47:18 +0100 Received: from mail-wg0-x232.google.com (mail-wg0-x232.google.com [IPv6:2a00:1450:400c:c00::232]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB90jv54004548 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128 verify=NOT) for ; Tue, 9 Dec 2014 01:45:57 +0100 Received: by mail-wg0-f50.google.com with SMTP id a1so239034wgh.9 for ; Mon, 08 Dec 2014 16:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=DYvJnvO6PkueD51rW8E+SCQkDYxwJGzWmP0T/7GbVMo=; b=RspcHhAN//uS3+YnR+0Xk3DjvNx9nm7j5q3T02pMKQ9vE4LAOZe9cgoEf+o9jjjMJW 3FhP0E/UYID6QRjf7WN2N//K8gsn6Qbigyap5A0KJrymsXjYrHuNEhEuN3damzJdl/y9 K8R5E37r4Lhk3618I9GFx5CnB6vFWer14ymOic6fO6RJJVi5tadnyo6yxCYUWVgV7wA/ 4mQdqBfLzE3M6yrWgFT+w39IKckINEghjC8JzXQ39r72NOMNbwtdcqzhbWbO64fFEy5H ++sFzQRNi9Zaj/qhhAe9HDY9m3K4L3cWeEZSNY1pdCTlD+SCNakxBQuzIyNKPswF/LKF Qr5Q== MIME-Version: 1.0 X-Received: by 10.180.99.1 with SMTP id em1mr295003wib.29.1418085953852; Mon, 08 Dec 2014 16:45:53 -0800 (PST) Received: by 10.216.151.7 with HTTP; Mon, 8 Dec 2014 16:45:53 -0800 (PST) In-Reply-To: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> References: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> Date: Tue, 9 Dec 2014 00:45:53 +0000 X-Google-Sender-Auth: QbltmRdIhPmyvOKYVHdhOYTqatY Message-ID: Subject: Re: CMake From: Alexander Lamaison To: Kamil Dudka Cc: "development, libssh2" X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB90jx2R004597 On 8 December 2014 at 13:45, Kamil Dudka wrote: > On Saturday 06 December 2014 00:34:41 Alexander Lamaison wrote: >> You may recall that back in March I promised to convert the libssh2 >> build system to CMake 'soon'. ... >> >> tl;dr >> - A version of libssh2 using CMake is available at >> https://github.com/alamaison/libssh2/tree/cmake >> - Please test > > I got libssh2 successfully built for Fedora using CMake and your patchset: > > http://pkgs.fedoraproject.org/cgit/libssh2.git/commit/?id=213e752a > http://koji.fedoraproject.org/koji/taskinfo?taskID=8321846 Thanks for testing :) > I have encountered a few minor issues: > > - The shared library is no longer versioned as it used to be. I have > hard-coded the version into src/CMakeLists.txt for now: > > --- a/src/CMakeLists.txt > +++ b/src/CMakeLists.txt > @@ -186,7 +186,9 @@ endif() > > add_library(libssh2 ${SOURCES}) > # we want it to be called libssh2 on all platforms > -set_target_properties(libssh2 PROPERTIES PREFIX "") > +set_target_properties(libssh2 PROPERTIES PREFIX "" > + SOVERSION 1 > + VERSION 1.0.1) > > target_compile_definitions(libssh2 PRIVATE ${PRIVATE_COMPILE_DEFINITIONS}) > target_include_directories(libssh2 I'll look into that tomorrow. IIRC they were always hardcoded, so your patch might be a reasonable fix. > - The file libssh2.pc is no longer generated with CMake. Is there any plan > to restore this functionality? CMake has a feature [1] that allows it to be used in place of pkg-config. In theory this removes the need for a .pc file, but, as you can see from the comments, the feature isn't universally popular. If you prefer, I can generate libssh2.pc from a template the way some other projects do. > - Man pages are not installed by CMake. Fixed: https://github.com/alamaison/libssh2/commit/ce9c01d4621d5ae020f4386d390860e8c7aa553d > - Before it goes to master, it would be good to merge some commits to make > the history easier to follow. Namely the unnecessary renames of libssh2.h > to libssh2.h.in and vice versa make the patchset difficult to apply on the > latest upstream release. I'll see what I can do to neaten it up. [1] https://blogs.kde.org/2011/11/09/cool-new-stuff-cmake-286-2-pkg-config-compatible-mode-added-use-eg-autotools Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 9 04:42:49 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB92xU5r012497; Tue, 9 Dec 2014 04:00:48 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB92xQoM012492 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 9 Dec 2014 03:59:26 +0100 Received: (qmail 28053 invoked by uid 501); 9 Dec 2014 02:59:27 -0000 Message-ID: <20141209025927.28052.qmail@stuge.se> Date: Tue, 9 Dec 2014 03:59:27 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: CMake Mail-Followup-To: libssh2-devel@cool.haxx.se References: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB92xU5r012497 Alexander Lamaison wrote: > > - The file libssh2.pc is no longer generated with CMake. Is > > there any plan to restore this functionality? > > CMake has a feature [1] that allows it to be used in place of > pkg-config. In theory this removes the need for a .pc file, Only if you assume that the universe only cares about the tool you prefer today, and no longer the tool that you prefered yesterday. > If you prefer, I can generate libssh2.pc from a template the way some > other projects do. I think anything less would be a severe regression. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 9 13:49:31 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB9Clt60001139; Tue, 9 Dec 2014 13:49:26 +0100 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB9ClpIS000969 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 9 Dec 2014 13:47:53 +0100 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB9Clerj008999 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 9 Dec 2014 07:47:45 -0500 Received: from kdudka.brq.redhat.com (kdudka.brq.redhat.com [10.34.4.67]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sB9C58BO017798 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Tue, 9 Dec 2014 07:05:10 -0500 From: Kamil Dudka To: Alexander Lamaison Subject: Re: CMake Date: Tue, 09 Dec 2014 13:05:08 +0100 Message-ID: <3482903.aQVECdcjeO@kdudka.brq.redhat.com> User-Agent: KMail/4.14.3 (Linux/3.17.4-301.fc21.x86_64; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB9Clt60001139 On Tuesday 09 December 2014 00:45:53 Alexander Lamaison wrote: > > - The file libssh2.pc is no longer generated with CMake. Is there any > > plan > > to restore this functionality? > > CMake has a feature [1] that allows it to be used in place of > pkg-config. In theory this removes the need for a .pc file, but, as > you can see from the comments, the feature isn't universally popular. > If you prefer, I can generate libssh2.pc from a template the way some > other projects do. We cannot just drop the file libssh2.pc in an update of the package in Fedora. If we really want to get rid of it (so far there seems to be no consensus on this topic), we need to go through a proper deprecation process. That is, we need to provide both variants, document the current variant as deprecated, and drop it after a few years from now. > > - Man pages are not installed by CMake. > > Fixed: > https://github.com/alamaison/libssh2/commit/ce9c01d4621d5ae020f4386d390860e > 8c7aa553d This works for me. Thanks! > > - Before it goes to master, it would be good to merge some commits to make > > the history easier to follow. Namely the unnecessary renames of libssh2.h > > to libssh2.h.in and vice versa make the patchset difficult to apply on the > > latest upstream release. > > I'll see what I can do to neaten it up. I can help you with the rebase once there is agreement on the final version. Kamil > [1] > https://blogs.kde.org/2011/11/09/cool-new-stuff-cmake-286-2-pkg-config-comp > atible-mode-added-use-eg-autotools > > Alex _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 9 14:00:34 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB9CxJde003631; Tue, 9 Dec 2014 14:00:33 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sB9CxIah003625 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 9 Dec 2014 13:59:18 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id sB9CxI58003620; Tue, 9 Dec 2014 13:59:18 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Tue, 9 Dec 2014 13:59:18 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: CMake In-Reply-To: <3482903.aQVECdcjeO@kdudka.brq.redhat.com> Message-ID: References: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> <3482903.aQVECdcjeO@kdudka.brq.redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) X-fromdanielhimself: yes MIME-Version: 1.0 Cc: Alexander Lamaison X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sB9CxJde003631 On Tue, 9 Dec 2014, Kamil Dudka wrote: >>> - The file libssh2.pc is no longer generated with CMake >> CMake has a feature [1] that allows it to be used in place of >> pkg-config. > > We cannot just drop the file libssh2.pc in an update of the package in Fedora. We basically cannot drop it at all, period. The (primary) use of libssh2.pc (and pkg-config in general) is to offer information about libssh2 on a system for other apps/libraries/users. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Dec 11 01:33:06 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBB0VV5X013757; Thu, 11 Dec 2014 01:32:59 +0100 Received: from mail-wi0-x233.google.com (mail-wi0-x233.google.com [IPv6:2a00:1450:400c:c05::233]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBB0VSYE013526 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128 verify=NOT) for ; Thu, 11 Dec 2014 01:31:28 +0100 Received: by mail-wi0-f179.google.com with SMTP id ex7so6998797wid.0 for ; Wed, 10 Dec 2014 16:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=L6pEfsadZ4g6ZWKWBP7JmCU0QPhai3esHfA+kMlrgYI=; b=QOTFM9PLFf4+ia71xy2PNf5YOslaPa7EvkX+1QCRQ3Ax+Kjt9kDYmPDTcS2E5YS7cK rf9mtS3N4c46HSmROIQ10kZklds27RjD6cQ0ovsWRjEaBQLkCpqASUsFp4YeoDVKLHP3 oco7IWMfyPgwdfqQDDBFIVKs5E56lI2SJoT3DLh7cQW/GjobFU8FuglOLAAVjAwxqHcL SjitFHTr0EMipMe2FjQsB65JG3L1bmEUVuxSyQLlWAf+XKv7S6DdhTnwZ4uUA/gpngwy BdelLlJBx1mQ4aRyX5ntQtj29qnRC8DiV7MoIoDDjG+eUOR2NGcHCiYq0O0v8cEoYB1N 1+jQ== MIME-Version: 1.0 X-Received: by 10.180.221.201 with SMTP id qg9mr10762368wic.29.1418257884451; Wed, 10 Dec 2014 16:31:24 -0800 (PST) Received: by 10.216.151.7 with HTTP; Wed, 10 Dec 2014 16:31:24 -0800 (PST) In-Reply-To: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> References: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> Date: Thu, 11 Dec 2014 00:31:24 +0000 X-Google-Sender-Auth: 1XHLfJF-ryh3yv8p0KoX1vG07J8 Message-ID: Subject: Re: CMake From: Alexander Lamaison To: Kamil Dudka Cc: "development, libssh2" X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBB0VV5X013757 On 8 December 2014 at 13:45, Kamil Dudka wrote: > On Saturday 06 December 2014 00:34:41 Alexander Lamaison wrote: >> >> tl;dr >> - A version of libssh2 using CMake is available at >> https://github.com/alamaison/libssh2/tree/cmake >> - Please test > I have encountered a few minor issues: > > - The shared library is no longer versioned as it used to be. I have > hard-coded the version into src/CMakeLists.txt for now Fixed in d50c4f06a14fad1da34bc05af85602c5ce0e95eb https://github.com/alamaison/libssh2/commit/d50c4f06a14fad1da34bc05af85602c5ce0e95eb > - The file libssh2.pc is no longer generated with CMake. Is there any plan > to restore this functionality? Fixed in 946ab802b9e79acdcc6c8e386b6510cd1f86d058 https://github.com/alamaison/libssh2/commit/946ab802b9e79acdcc6c8e386b6510cd1f86d058 I noticed you had lib64 as the lib path. I had hardcoded 'lib' before so I changed to use GNUInstallDirs, which tries to do the right thing based on platform. Let me know if this causes any problems. > I can help you with the rebase once there is agreement on the final version. Thanks :) Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Dec 11 07:24:04 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBB6MeKc011680; Thu, 11 Dec 2014 07:24:00 +0100 Received: from mail-la0-x236.google.com (mail-la0-x236.google.com [IPv6:2a00:1450:4010:c03::236]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBB6Mdxw011667 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128 verify=NOT) for ; Thu, 11 Dec 2014 07:22:39 +0100 Received: by mail-la0-f54.google.com with SMTP id pv20so3605103lab.41 for ; Wed, 10 Dec 2014 22:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=o1uiO59I6jkngq0z/oasx16Agdd6SpSHimSQhmT7tl4=; b=QaN2kQxbAehn+JbMePwqCd2MSW/k9aZGJx2Zr75gL1+9hAmoiwQkvkg5Ylki7yfV20 GYCIdN6hZV0N3D6QGMWk3bui9G18vSt0uoG365GWNXdYCPEzdIOmvRkrBb3Gz5nXJZPQ PJqyQQIFp743JSDjK8rOpzvB9I0Ihh2jFOqWp7DFX8q7QoRv8r+D81A76z7AY9tO8k7C jEwqVXc0b+yo2qnGgvzjnX49DYNiHux+vYb67kys2Wh/Tc37IlfCWXZd4/jAq9Y4pO6D 00i74ZflxrhOnHrlPDkqkGjaVe081Z1sApBPBtQee9FMqYBEBZqfvB9DK9VktrOtytyC zLHw== MIME-Version: 1.0 X-Received: by 10.152.43.166 with SMTP id x6mr8140603lal.14.1418278954944; Wed, 10 Dec 2014 22:22:34 -0800 (PST) Received: by 10.25.42.199 with HTTP; Wed, 10 Dec 2014 22:22:34 -0800 (PST) In-Reply-To: References: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> Date: Thu, 11 Dec 2014 01:22:34 -0500 Message-ID: Subject: Re: CMake From: Toan Pham To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1676511363==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============1676511363== Content-Type: multipart/alternative; boundary=001a11c29b584d51210509eacd47 --001a11c29b584d51210509eacd47 Content-Type: text/plain; charset=UTF-8 Hi Alexander I understand your reasons for migrating to CMake. But where did you get reason# 4 (below)? I know that most of kde projects use Cmake; but other than that, i dont know why cmake has won the WAR! do you have a reference? thank you -toan 4) For better or worse, CMake has won the latest war of the C/C++ build systems. This makes it the focus of new innovation and the support community is very active. As more and more projects are adopting it, they can take advantage of 3). --001a11c29b584d51210509eacd47 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Alexander

I understand your reas= ons for migrating to CMake.=C2=A0 But where did you get reason# 4 (below)?<= br>
I know that most of kde projects use Cmake; but other than th= at, i dont know why cmake has won the WAR!=C2=A0 do you have a reference?


thank you

-toan

4) For better or worse, CMake has won the latest war of the C/C++
=C2=A0 =C2=A0build systems.=C2=A0 This makes it the focus of new innovation= and the
=C2=A0 =C2=A0support community is very active.=C2=A0 As more and more proje= cts are
=C2=A0 =C2=A0adopting it, they can take advantage of 3).


<= /div> --001a11c29b584d51210509eacd47-- --===============1676511363== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============1676511363==-- From libssh2-devel-bounces@cool.haxx.se Thu Dec 11 12:49:40 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBBBmIYt003847; Thu, 11 Dec 2014 12:49:35 +0100 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBBBmFbm003830 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 11 Dec 2014 12:48:17 +0100 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBBBmCOq032046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 11 Dec 2014 06:48:12 -0500 Received: from kdudka.brq.redhat.com (kdudka.brq.redhat.com [10.34.4.67]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBBBmAmu000837 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Thu, 11 Dec 2014 06:48:12 -0500 From: Kamil Dudka To: Alexander Lamaison Subject: Re: CMake Date: Thu, 11 Dec 2014 12:48:10 +0100 Message-ID: <4543944.vpIiFCdAIH@kdudka.brq.redhat.com> User-Agent: KMail/4.14.3 (Linux/3.17.4-301.fc21.x86_64; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Cc: "'libssh2 development'" X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBBBmIYt003847 On Thursday 11 December 2014 00:31:24 Alexander Lamaison wrote: > On 8 December 2014 at 13:45, Kamil Dudka wrote: > > On Saturday 06 December 2014 00:34:41 Alexander Lamaison wrote: > >> tl;dr > >> - A version of libssh2 using CMake is available at > >> > >> https://github.com/alamaison/libssh2/tree/cmake > >> > >> - Please test > > > > I have encountered a few minor issues: > > > > - The shared library is no longer versioned as it used to be. I have > > hard-coded the version into src/CMakeLists.txt for now > > Fixed in d50c4f06a14fad1da34bc05af85602c5ce0e95eb > https://github.com/alamaison/libssh2/commit/d50c4f06a14fad1da34bc05af85602c5 > ce0e95eb > > - The file libssh2.pc is no longer generated with CMake. Is there any > > plan > > to restore this functionality? > > Fixed in 946ab802b9e79acdcc6c8e386b6510cd1f86d058 > https://github.com/alamaison/libssh2/commit/946ab802b9e79acdcc6c8e386b6510cd > 1f86d058 > > I noticed you had lib64 as the lib path. I had hardcoded 'lib' before > so I changed to use GNUInstallDirs, which tries to do the right thing > based on platform. Let me know if this causes any problems. Thanks for the additional patches! I have incorporated them into my private branch of the Fedora package: http://pkgs.fedoraproject.org/cgit/libssh2.git/log/?h=private-kdudka-use-cmake-r0 Everything works just fine at first glance. Kamil > > I can help you with the rebase once there is agreement on the final > > version. > Thanks :) > > Alex _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Dec 14 19:56:27 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBEIsw01014707; Sun, 14 Dec 2014 19:56:21 +0100 Received: from mx.uxnr.de (mx.uxnr.de [IPv6:2a00:1828:2000:378:3:25:59ee:5430]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBEIsu0k014593 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 14 Dec 2014 19:54:56 +0100 Received: from [10.2.2.10] (MH01.ma01.uxnr.net [10.2.2.10]) by mx.uxnr.de (Postfix) with ESMTPSA id AC1DF1C5A31A for ; Sun, 14 Dec 2014 19:54:55 +0100 (CET) X-DKIM: OpenDKIM Filter v2.6.8 mx.uxnr.de AC1DF1C5A31A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=marc-hoersken.de; s=picard; t=1418583295; bh=BnG4BMytR4ZctE8S2lCGjRokp1/aWNnuyON9X2DAJao=; h=Date:From:To:Subject:References:In-Reply-To:From; b=YwjGzHVtdC+vSXTNv6ZJRJCH9UKFuMyy2Bl/OntLJkh3jxT55v76PZy2Jrz3zUvqU 3gkB/ZJ1HG7WwQWugYL0GABb1EmB7NPGo+1Ec3UzTkOtq8RfhiDQmZeG/kimY1rmWF K7EchXVeVdrYDRw2NpnVUgU8u8x0YvsHWPYf4fho= Message-ID: <548DDCF8.9040705@marc-hoersken.de> Date: Sun, 14 Dec 2014 19:54:48 +0100 From: Marc Hoersken User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: libssh2-devel@cool.haxx.se Subject: Re: CMake References: In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, T_DKIM_INVALID autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on picard.vpn.uxnr.de X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id sBEIsu0k014593 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBEIsw01014707 Hey Alexander, thanks for your work on the CMake build files. I just rebased your cmake branch onto the current master (19f1402f1d) by skipping the following commits: 1. 3c939b49eadbd1e629eab0a626c80cd71a23642d 2. ac3dc09e2fb32628d20117f151ae073801068c33 You can find my rebased branch here: https://github.com/mback2k/libssh2/commits/cmake It also includes a small fix to make it work with WinCNG again: https://github.com/mback2k/libssh2/commit/85f241fb7a37296240c828851813210a89e8b3cc This way I was able to compile with WinCNG and connect to my local SSHd using the ssh example: E:\OS\libssh2\example\Debug>example-ssh2.exe 127.0.0.1 test test Fingerprint: F6 C2 3B A2 56 C4 D8 BC 49 ED 3E 3E 90 1B 1A D9 6F 51 9A BF Authentication methods: publickey,password Authentication by password succeeded. all done! Please do not remove the existing build infrastructure, just yet. CMake cannot replace all of them and even those that can be replaced need to deprecated first and slowly phased out. Best regards, Marc _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Dec 14 20:00:36 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBEIxXu3020018; Sun, 14 Dec 2014 20:00:35 +0100 Received: from mx.uxnr.de (mx.uxnr.de [IPv6:2a00:1828:2000:378:3:25:59ee:5430]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBEIxVaa019955 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 14 Dec 2014 19:59:32 +0100 Received: from [10.2.2.10] (MH01.ma01.uxnr.net [10.2.2.10]) by mx.uxnr.de (Postfix) with ESMTPSA id 19C061C5A31A for ; Sun, 14 Dec 2014 19:59:31 +0100 (CET) X-DKIM: OpenDKIM Filter v2.6.8 mx.uxnr.de 19C061C5A31A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=marc-hoersken.de; s=picard; t=1418583571; bh=TRh+RnFP1tbsZYPIVAzWiB1sgXx2gHcj4L5lOSLVUc8=; h=Date:From:To:Subject:References:In-Reply-To:From; b=S0c8fJiWYambD5XfScZKiLFAhs3Uyy5uIqRgKpmgB9P+J+XpQwyTqEe+3QbpO7aEj UlN52rUszHr9ud7IJSp28oD3vNdCHnIAb8qGzcbCNdXJn0jYvQC3Y3vuZaCyWtp70z Qu86Pv2ZLM+1bzH9MQDHGnYp1mVOR1GdSsv6C4jI= Message-ID: <548DDE0C.4080504@marc-hoersken.de> Date: Sun, 14 Dec 2014 19:59:24 +0100 From: Marc Hoersken User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: libssh2-devel@cool.haxx.se Subject: Re: CMake References: <548DDCF8.9040705@marc-hoersken.de> In-Reply-To: <548DDCF8.9040705@marc-hoersken.de> X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, T_DKIM_INVALID autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on picard.vpn.uxnr.de X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBEIxXu3020018 On 14.12.2014 19:54 Marc Hoersken wrote: > You can find my rebased branch here: > https://github.com/mback2k/libssh2/commits/cmake > > It also includes a small fix to make it work with WinCNG again: > https://github.com/mback2k/libssh2/commit/85f241fb7a37296240c828851813210a89e8b3cc > > ... > > Please do not remove the existing build infrastructure, just yet. > CMake cannot replace all of them and even those that can be replaced > need to deprecated first and slowly phased out. Please also keep the changes to non-CMake-relevant files to a minimum, see: https://github.com/mback2k/libssh2/compare/cmake#files_bucket And before this can be merged into master, I think the smaller commits should be squashed into logical commits. Thanks in advance! _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Dec 15 01:34:17 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBF0WlMh027770; Mon, 15 Dec 2014 01:34:09 +0100 Received: from mx.uxnr.de (mx.uxnr.de [IPv6:2a00:1828:2000:378:3:25:59ee:5430]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBF0WjrP027045 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 15 Dec 2014 01:32:45 +0100 Received: from [10.2.2.10] (MH01.ma01.uxnr.net [10.2.2.10]) by mx.uxnr.de (Postfix) with ESMTPSA id 95CB41C5A31A for ; Mon, 15 Dec 2014 01:32:47 +0100 (CET) X-DKIM: OpenDKIM Filter v2.6.8 mx.uxnr.de 95CB41C5A31A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=marc-hoersken.de; s=picard; t=1418603567; bh=lCy9nLpLqpzNYbxSx6G+hpchiCixrdL2k0cZBBmUiyg=; h=Date:From:To:Subject:From; b=qczM2TM45fWI2i0+TR4auJSoMobhG0Pva0szUgosxhqLeUP95G5ItexJTzyc5xVoL g1DWyeMabLt3vAYHl0dQqAsM3Y6cKYWwRblG0mT383aTLJKIHb+n1CkMphnRLVSe6V b0E3ihYHYo43ZFQ5WeeT/G4iKwQ3y/6ffUXFL94I= Message-ID: <548E2C25.1090603@marc-hoersken.de> Date: Mon, 15 Dec 2014 01:32:37 +0100 From: Marc Hoersken User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: libssh2 development Subject: Additional questions related to my fixes of possible NULL pointer de-references X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, T_DKIM_INVALID autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on picard.vpn.uxnr.de X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id sBF0WjrP027045 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBF0WlMh027770 Hello everyone, I just posted a bunch of patches to the Git repository that are the result of running the code analysis feature of VS2012 against libssh2 using the new CMake generated project files. Most of them are quite basic, but at least the following two patches raise additional questions that I would like to bring to your attention: - kex.c: fix possible NULL pointer de-reference with session->kex [1] - packet.c: fix possible NULL pointer de-reference within listen_state [2] I think that just catching the possible NULL pointer in those code paths is actually not enough to make libssh2 behave correctly. In my opinion some kind of error code needs to be raised if such an error condition is reached. What do you think? Patches and ideas are welcome. Best regards, Marc [1] http://git.libssh2.org/?p=libssh2.git;a=commitdiff;h=1c1699545b0a1114e8ca3e6cd097cc9df1e67201;js=1 [2] http://git.libssh2.org/?p=libssh2.git;a=commitdiff;h=e57f29f8f65c83063fd8f63c88f88830fc269bd6;js=1 _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Dec 15 12:28:13 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBFBQpbi018861; Mon, 15 Dec 2014 12:28:09 +0100 Received: from mx.uxnr.de (mx.uxnr.de [89.238.84.48]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBFBQmex018818 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 15 Dec 2014 12:26:49 +0100 Received: from marcs-mbp.ma01.uxnr.net (p5B0A5822.dip0.t-ipconnect.de [91.10.88.34]) by mx.uxnr.de (Postfix) with ESMTPSA id A91321C5A4CB for ; Mon, 15 Dec 2014 12:26:43 +0100 (CET) X-DKIM: OpenDKIM Filter v2.6.8 mx.uxnr.de A91321C5A4CB DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=marc-hoersken.de; s=picard; t=1418642803; bh=5WrHqa12Ecs04ke4w98ff1CFzVyPD9L8ZGF4DzIxVp4=; h=From:Subject:Date:To:From; b=M+7q8j10igQqCc7i1fFPOxs8E/wk/t6Na18FpmqJBUILjrSGjnhkUyvCmJH/73+QD dsCNijmHjKck2w4l2b/wW29K/VP38HSg5P0lSmbt+XdbFlenLbasD5DMT4cuKVsbdl CsphQY41P+1OWO08GKmcShvvhGFVfOgFzRKVBCS8= From: =?utf-8?Q?Marc_H=C3=B6rsken?= X-Pgp-Agent: GPGMail 2.5b3 Subject: [PATCH] silence multiple data conversion warnings Date: Mon, 15 Dec 2014 12:26:34 +0100 Message-Id: To: libssh2 development Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) X-Mailer: Apple Mail (2.1993) X-Spam-Status: No, score=0.1 required=5.0 tests=DKIM_SIGNED,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on picard.vpn.uxnr.de X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0408636334==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0408636334== Content-Type: multipart/signed; boundary="Apple-Mail=_A120B46D-C437-49D0-B960-5FC3789498F4"; protocol="application/pgp-signature"; micalg=pgp-sha512 --Apple-Mail=_A120B46D-C437-49D0-B960-5FC3789498F4 Content-Type: multipart/mixed; boundary="Apple-Mail=_06328776-C0FF-4549-A21E-EA5E466C35D5" --Apple-Mail=_06328776-C0FF-4549-A21E-EA5E466C35D5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hello everyone, attached you will find a patch to silence multiple compiler warnings = about invalid data conversions with possible data loss using the VS2012 = compiler. Since these are quite a lot of small changes, I would like someone else = to review and push it to the repository. Thanks in advance. Best regards, Marc --Apple-Mail=_06328776-C0FF-4549-A21E-EA5E466C35D5 Content-Disposition: attachment; filename=0001-silence-multiple-data-conversion-warnings.patch Content-Type: application/octet-stream; name="0001-silence-multiple-data-conversion-warnings.patch" Content-Transfer-Encoding: quoted-printable =46rom=20437e279cf144551880a16c9492c0ff684f97de3b=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Marc=20Hoersken=20=0A= Date:=20Mon,=2015=20Dec=202014=2012:23:43=20+0100=0ASubject:=20[PATCH]=20= silence=20multiple=20data=20conversion=20warnings=0A=0A---=0A=20= src/channel.c=20=20=20|=204=20++--=0A=20src/keepalive.c=20|=207=20= ++++---=0A=20src/misc.c=20=20=20=20=20=20|=208=20++++----=0A=20= src/packet.c=20=20=20=20|=206=20+++---=0A=20src/scp.c=20=20=20=20=20=20=20= |=202=20+-=0A=20src/sftp.c=20=20=20=20=20=20|=204=20++--=0A=20= src/transport.c=20|=202=20+-=0A=20src/userauth.c=20=20|=203=20++-=0A=20= src/wincng.c=20=20=20=20|=203=20++-=0A=209=20files=20changed,=2021=20= insertions(+),=2018=20deletions(-)=0A=0Adiff=20--git=20a/src/channel.c=20= b/src/channel.c=0Aindex=2058cee5f..e0766a1=20100644=0A---=20= a/src/channel.c=0A+++=20b/src/channel.c=0A@@=20-1625,7=20+1625,7=20@@=20= libssh2_channel_receive_window_adjust(LIBSSH2_CHANNEL=20*channel,=0A=20=20= =20=20=20int=20rc;=0A=20=0A=20=20=20=20=20if(!channel)=0A-=20=20=20=20=20= =20=20=20return=20LIBSSH2_ERROR_BAD_USE;=0A+=20=20=20=20=20=20=20=20= return=20(unsigned=20long)LIBSSH2_ERROR_BAD_USE;=0A=20=0A=20=20=20=20=20= BLOCK_ADJUST(rc,=20channel->session,=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20_libssh2_channel_receive_window_adjust(channel,=20adj,=0A= @@=20-1672,7=20+1672,7=20@@=20= _libssh2_channel_extended_data(LIBSSH2_CHANNEL=20*channel,=20int=20= ignore_mode)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20"Setting=20channel=20%lu/%lu=20handle_extended_data"=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"=20= mode=20to=20%d",=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20channel->local.id,=20channel->remote.id,=20= ignore_mode);=0A-=20=20=20=20=20=20=20=20= channel->remote.extended_data_ignore_mode=20=3D=20ignore_mode;=0A+=20=20=20= =20=20=20=20=20channel->remote.extended_data_ignore_mode=20=3D=20= (char)ignore_mode;=0A=20=0A=20=20=20=20=20=20=20=20=20= channel->extData2_state=20=3D=20libssh2_NB_state_created;=0A=20=20=20=20=20= }=0Adiff=20--git=20a/src/keepalive.c=20b/src/keepalive.c=0Aindex=20= 260206a..fd749dd=20100644=0A---=20a/src/keepalive.c=0A+++=20= b/src/keepalive.c=0A@@=20-75,7=20+75,8=20@@=20libssh2_keepalive_send=20= (LIBSSH2_SESSION=20*session,=0A=20=20=20=20=20=20=20=20=20size_t=20len=20= =3D=20sizeof=20(keepalive_data)=20-=201;=0A=20=20=20=20=20=20=20=20=20= int=20rc;=0A=20=0A-=20=20=20=20=20=20=20=20keepalive_data[len=20-=201]=20= =3D=20session->keepalive_want_reply;=0A+=20=20=20=20=20=20=20=20= keepalive_data[len=20-=201]=20=3D=0A+=20=20=20=20=20=20=20=20=20=20=20=20= (unsigned=20char)session->keepalive_want_reply;=0A=20=0A=20=20=20=20=20=20= =20=20=20rc=20=3D=20_libssh2_transport_send(session,=20keepalive_data,=20= len,=20NULL,=200);=0A=20=20=20=20=20=20=20=20=20/*=20Silently=20ignore=20= PACKET_EAGAIN=20here:=20if=20the=20write=20buffer=20is=0A@@=20-90,8=20= +91,8=20@@=20libssh2_keepalive_send=20(LIBSSH2_SESSION=20*session,=0A=20=20= =20=20=20=20=20=20=20if=20(seconds_to_next)=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20*seconds_to_next=20=3D=20session->keepalive_interval;=0A=20=20= =20=20=20}=20else=20if=20(seconds_to_next)=20{=0A-=20=20=20=20=20=20=20=20= *seconds_to_next=20=3D=20(int)=20session->keepalive_last_sent=0A-=20=20=20= =20=20=20=20=20=20=20=20=20+=20session->keepalive_interval=20-=20now;=0A= +=20=20=20=20=20=20=20=20*seconds_to_next=20=3D=20(int)=20= (session->keepalive_last_sent=20-=20now)=0A+=20=20=20=20=20=20=20=20=20=20= =20=20+=20session->keepalive_interval;=0A=20=20=20=20=20}=0A=20=0A=20=20=20= =20=20return=200;=0Adiff=20--git=20a/src/misc.c=20b/src/misc.c=0Aindex=20= 4d89876..d48ea62=20100644=0A---=20a/src/misc.c=0A+++=20b/src/misc.c=0A@@=20= -266,15=20+266,15=20@@=20libssh2_base64_decode(LIBSSH2_SESSION=20= *session,=20char=20**data,=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= continue;=0A=20=20=20=20=20=20=20=20=20switch=20(i=20%=204)=20{=0A=20=20=20= =20=20=20=20=20=20case=200:=0A-=20=20=20=20=20=20=20=20=20=20=20=20= d[len]=20=3D=20v=20<<=202;=0A+=20=20=20=20=20=20=20=20=20=20=20=20d[len]=20= =3D=20(unsigned=20char)(v=20<<=202);=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20break;=0A=20=20=20=20=20=20=20=20=20case=201:=0A=20=20=20=20=20=20=20=20= =20=20=20=20=20d[len++]=20|=3D=20v=20>>=204;=0A-=20=20=20=20=20=20=20=20=20= =20=20=20d[len]=20=3D=20v=20<<=204;=0A+=20=20=20=20=20=20=20=20=20=20=20=20= d[len]=20=3D=20(unsigned=20char)(v=20<<=204);=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20break;=0A=20=20=20=20=20=20=20=20=20case=202:=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20d[len++]=20|=3D=20v=20>>=202;=0A-=20=20=20=20=20=20= =20=20=20=20=20=20d[len]=20=3D=20v=20<<=206;=0A+=20=20=20=20=20=20=20=20=20= =20=20=20d[len]=20=3D=20(unsigned=20char)(v=20<<=206);=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20break;=0A=20=20=20=20=20=20=20=20=20case=203:=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20d[len++]=20|=3D=20v;=0A@@=20-605,7=20= +605,7=20@@=20int=20__cdecl=20_libssh2_gettimeofday(struct=20timeval=20= *tp,=20void=20*tzp)=0A=20=20=20=20=20unsigned=20__int64=20ns100;=20= /*time=20since=201=20Jan=201601=20in=20100ns=20units=20*/=0A=20=20=20=20=20= FILETIME=20ft;=0A=20=20=20}=20=20_now;=0A-=0A+=20=20(void)tzp;=0A=20=20=20= if(tp)=0A=20=20=20=20=20{=0A=20=20=20=20=20=20=20GetSystemTimeAsFileTime=20= (&_now.ft);=0Adiff=20--git=20a/src/packet.c=20b/src/packet.c=0Aindex=20= 789c803..08bb719=20100644=0A---=20a/src/packet.c=0A+++=20b/src/packet.c=0A= @@=20-1160,8=20+1160,7=20@@=20_libssh2_packet_burn(LIBSSH2_SESSION=20*=20= session,=0A=20{=0A=20=20=20=20=20unsigned=20char=20*data;=0A=20=20=20=20=20= size_t=20data_len;=0A-=20=20=20=20unsigned=20char=20all_packets[255];=0A= -=20=20=20=20int=20i;=0A+=20=20=20=20unsigned=20char=20i,=20= all_packets[255];=0A=20=20=20=20=20int=20ret;=0A=20=0A=20=20=20=20=20if=20= (*state=20=3D=3D=20libssh2_NB_state_idle)=20{=0A@@=20-1196,7=20+1195,8=20= @@=20_libssh2_packet_burn(LIBSSH2_SESSION=20*=20session,=0A=20=0A=20=20=20= =20=20=20=20=20=20/*=20Be=20lazy,=20let=20packet_ask=20pull=20it=20out=20= of=20the=20brigade=20*/=0A=20=20=20=20=20=20=20=20=20if=20(0=20=3D=3D=0A= -=20=20=20=20=20=20=20=20=20=20=20=20_libssh2_packet_ask(session,=20ret,=20= &data,=20&data_len,=200,=20NULL,=200))=20{=0A+=20=20=20=20=20=20=20=20=20= =20=20=20_libssh2_packet_ask(session,=20(unsigned=20char)ret,=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20&data,=20&data_len,=200,=20NULL,=20= 0))=20{=0A=20=20=20=20=20=20=20=20=20=20=20=20=20/*=20Smoke=20'em=20if=20= you=20got=20'em=20*/=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= LIBSSH2_FREE(session,=20data);=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= *state=20=3D=20libssh2_NB_state_idle;=0Adiff=20--git=20a/src/scp.c=20= b/src/scp.c=0Aindex=201ccd3be..89f302b=20100644=0A---=20a/src/scp.c=0A= +++=20b/src/scp.c=0A@@=20-727,7=20+727,7=20@@=20scp_recv(LIBSSH2_SESSION=20= *=20session,=20const=20char=20*path,=20struct=20stat=20*=20sb)=0A=20=20=20= =20=20=20=20=20=20sb->st_mtime=20=3D=20session->scpRecv_mtime;=0A=20=20=20= =20=20=20=20=20=20sb->st_atime=20=3D=20session->scpRecv_atime;=0A=20=20=20= =20=20=20=20=20=20sb->st_size=20=3D=20session->scpRecv_size;=0A-=20=20=20= =20=20=20=20=20sb->st_mode=20=3D=20session->scpRecv_mode;=0A+=20=20=20=20= =20=20=20=20sb->st_mode=20=3D=20(unsigned=20short)session->scpRecv_mode;=0A= =20=20=20=20=20}=0A=20=0A=20=20=20=20=20session->scpRecv_state=20=3D=20= libssh2_NB_state_idle;=0Adiff=20--git=20a/src/sftp.c=20b/src/sftp.c=0A= index=2065c3cf1..2f9119a=20100644=0A---=20a/src/sftp.c=0A+++=20= b/src/sftp.c=0A@@=20-1620,7=20+1620,7=20@@=20static=20ssize_t=20= sftp_readdir(LIBSSH2_SFTP_HANDLE=20*handle,=20char=20*buffer,=0A=20=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20filename_len=20=3D=20= real_filename_len;=0A=20=20=20=20=20=20=20=20=20=20=20=20=20if=20= (filename_len=20>=3D=20buffer_maxlen)=20{=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20filename_len=20=3D=20LIBSSH2_ERROR_BUFFER_TOO_SMALL;=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20filename_len=20=3D=20= (size_t)LIBSSH2_ERROR_BUFFER_TOO_SMALL;=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20goto=20end;=0A=20=20=20=20=20=20=20=20=20=20=20=20=20}=0A= =20=0A@@=20-1635,7=20+1635,7=20@@=20static=20ssize_t=20= sftp_readdir(LIBSSH2_SFTP_HANDLE=20*handle,=20char=20*buffer,=0A=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20longentry_len=20=3D=20= real_longentry_len;=0A=20=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20if=20(longentry_len=20>=3D=20longentry_maxlen)=20{=0A-=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20filename_len=20=3D=20= LIBSSH2_ERROR_BUFFER_TOO_SMALL;=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20filename_len=20=3D=20= (size_t)LIBSSH2_ERROR_BUFFER_TOO_SMALL;=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20goto=20end;=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20}=0A=20=0Adiff=20--git=20a/src/transport.c=20= b/src/transport.c=0Aindex=203d61f8d..5b3d66d=20100644=0A---=20= a/src/transport.c=0A+++=20b/src/transport.c=0A@@=20-829,7=20+829,7=20@@=20= int=20_libssh2_transport_send(LIBSSH2_SESSION=20*session,=0A=20=20=20=20=20= =20=20=20the=20MAC=20and=20the=20packet_length=20field=20itself=20*/=0A=20= =20=20=20=20_libssh2_htonu32(p->outbuf,=20packet_length=20-=204);=0A=20=20= =20=20=20/*=20store=20padding_length=20*/=0A-=20=20=20=20p->outbuf[4]=20= =3D=20padding_length;=0A+=20=20=20=20p->outbuf[4]=20=3D=20(unsigned=20= char)padding_length;=0A=20=0A=20=20=20=20=20/*=20fill=20the=20padding=20= area=20with=20random=20junk=20*/=0A=20=20=20=20=20= _libssh2_random(p->outbuf=20+=205=20+=20data_len,=20padding_length);=0A= diff=20--git=20a/src/userauth.c=20b/src/userauth.c=0Aindex=20= edfe729..3cd5486=20100644=0A---=20a/src/userauth.c=0A+++=20= b/src/userauth.c=0A@@=20-216,7=20+216,8=20@@=20= userauth_password(LIBSSH2_SESSION=20*session,=0A=20=20=20=20=20=20=20=20=20= =20*=20chgpwdbool(1)=20+=20password_len(4)=20*/=0A=20=20=20=20=20=20=20=20= =20session->userauth_pswd_data_len=20=3D=20username_len=20+=2040;=0A=20=0A= -=20=20=20=20=20=20=20=20session->userauth_pswd_data0=20=3D=20= ~SSH_MSG_USERAUTH_PASSWD_CHANGEREQ;=0A+=20=20=20=20=20=20=20=20= session->userauth_pswd_data0=20=3D=0A+=20=20=20=20=20=20=20=20=20=20=20=20= (unsigned=20char)=20~SSH_MSG_USERAUTH_PASSWD_CHANGEREQ;=0A=20=0A=20=20=20= =20=20=20=20=20=20/*=20TODO:=20remove=20this=20alloc=20with=20a=20fixed=20= buffer=20in=20the=20session=0A=20=20=20=20=20=20=20=20=20=20=20=20struct=20= */=0Adiff=20--git=20a/src/wincng.c=20b/src/wincng.c=0Aindex=20= e7a4c4d..4a8aa16=20100644=0A---=20a/src/wincng.c=0A+++=20b/src/wincng.c=0A= @@=20-1278,7=20+1278,8=20@@=20= _libssh2_wincng_pub_priv_keyfile(LIBSSH2_SESSION=20*session,=0A=20=20=20=20= =20unsigned=20char=20*pbEncoded,=20**rpbDecoded;=0A=20=20=20=20=20= unsigned=20long=20cbEncoded,=20*rcbDecoded;=0A=20=20=20=20=20unsigned=20= char=20*key=20=3D=20NULL,=20*mth=20=3D=20NULL;=0A-=20=20=20=20unsigned=20= long=20keylen,=20mthlen,=20index,=20offset,=20length;=0A+=20=20=20=20= unsigned=20long=20keylen=20=3D=200,=20mthlen=20=3D=200;=0A+=20=20=20=20= unsigned=20long=20index,=20offset,=20length;=0A=20=20=20=20=20int=20ret;=0A= =20=0A=20=20=20=20=20ret=20=3D=20_libssh2_wincng_load_private(session,=20= privatekey,=20passphrase,=0A--=20=0A1.9.4.msysgit.1=0A=0A= --Apple-Mail=_06328776-C0FF-4549-A21E-EA5E466C35D5-- --Apple-Mail=_A120B46D-C437-49D0-B960-5FC3789498F4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUjsVqAAoJEPhLrsrSvXftI2IIAMyp68R1NhGw8fWK+xab1Bjj WWHDjrfgf3yL0wrzrF6+FtJ5156woXaAwXmOzcqUvhJpOb8Pk05C/J4LXqKtS8J4 LkRCWQtSKVms186Gbw6BksaB2mX/h3KziNYPTArzVytCznzR+sjMEmc1IK57Qa19 nE69E1fkScScG1fBJDmy9DqDqCc5/JxPiu8kxfdJR8qHaxABLhKYww9YBsUGDOsT ifEXzQX6Givgg0tE5AMm8LV3+ar7J9OX7W/gcvEvPcbAnaikNGzRRUzk06P7SAKv tbqtQm4qPpwENnojNf9NzLEZw1u5h/ZwzAjbD0bMmEWAsF8hWvdjMFzTDHvyWHU= =seWP -----END PGP SIGNATURE----- --Apple-Mail=_A120B46D-C437-49D0-B960-5FC3789498F4-- --===============0408636334== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0408636334==-- From libssh2-devel-bounces@cool.haxx.se Tue Dec 16 19:55:21 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGIrqdm016141; Tue, 16 Dec 2014 19:55:16 +0100 Received: from mail-wg0-x233.google.com (mail-wg0-x233.google.com [IPv6:2a00:1450:400c:c00::233]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGIrpZA016059 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128 verify=NOT) for ; Tue, 16 Dec 2014 19:53:51 +0100 Received: by mail-wg0-f51.google.com with SMTP id x12so18072338wgg.38 for ; Tue, 16 Dec 2014 10:53:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=gqSq4mvq2hh3MlbIIiVBQ7GrSQg1SYY3Kpj/K6wp8FM=; b=0l2MoHR/wSiba/nUz2T3tprX7nFhxV6FWd6FvH2IxiWbYK7uAGcHx3sCa0Xb/CtfKx a+Quhv/8ZSBDSK1wgHxdrHB+/7vJTAmfAMvw02EzOzoMO0Tr2KuP/DYTq6pWP9iHS91K goeFPPnVrumiFdtl1pN8Gmj9QLAX/I8hpUiqZdgv03EeWVBwGiMyrAn/eY3OTRdeXLNs P0dJIZ9tny3VMf8tF1rBD5qU1MXYOG+0G9gXnzZauYmLfABCg8G51sGVG3kl/AyXhn1J IVKtKu9JFXwkZv/d9l8MimFDQHjzCmPSWyykUXnEDN9HWBJ7zOv9Mp/QvcohwGmTEkTU ENfw== MIME-Version: 1.0 X-Received: by 10.180.221.201 with SMTP id qg9mr7314734wic.29.1418756026665; Tue, 16 Dec 2014 10:53:46 -0800 (PST) Received: by 10.216.151.7 with HTTP; Tue, 16 Dec 2014 10:53:46 -0800 (PST) In-Reply-To: References: <4731159.xs7Bx9JFpv@kdudka.brq.redhat.com> Date: Tue, 16 Dec 2014 18:53:46 +0000 X-Google-Sender-Auth: KJsk_zFcgvGAUTc704CANZOgv0o Message-ID: Subject: Re: CMake From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGIrqdm016141 On 11 December 2014 at 06:22, Toan Pham wrote: > > 4) For better or worse, CMake has won the latest war of the C/C++ > > build systems. > > I understand your reasons for migrating to CMake. But where did you get > reason# 4 (below)? > I know that most of kde projects use Cmake; but other than that, i dont know > why cmake has won the WAR! do you have a reference? No reference, just a conclusion based on mounting evidence. I can't remember the last time I saw a new project that chose a build system other than CMake. Jetbrains chose CMake as the basis of CLion, their new flavour of the IntelliJ IDE for C/C++. Microsoft joined the party (not as definitive a win as it used to be, but definitely noteworthy). Boost are putting huge effort into moving to CMake from Boost.Jam. The little bits all add up to a win. Just my humble opinion. Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 16 20:16:45 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGJFaNf020246; Tue, 16 Dec 2014 20:16:44 +0100 Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [IPv6:2a00:1450:400c:c05::22f]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGJFZsa019650 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128 verify=NOT) for ; Tue, 16 Dec 2014 20:15:35 +0100 Received: by mail-wi0-f175.google.com with SMTP id l15so13333317wiw.14 for ; Tue, 16 Dec 2014 11:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=gQt4/FNWyyyvu/JDJzK3IxI80aMwV0aAHorG4R5+jvc=; b=sePCl7H5+TKI+tC1p4Sqv52tGXV9LmERCPYldQI71JVgxVpJw01IukIBRGS2BJUjdr sopAF7Z5hsWxoCJyyI5og1z4bFcCCpA76ctW/rTUObqXH6oc7GYo/0RqOqLK0Kj2KuVC L0XBieCiKheM5ewMCurD5UELw6hOQjq1Utsb6FmmJK6Dw+UWZd26i5l3YCl09/sVw7/t cYjinkYl522QS2/go4MdzAk5NtmKsJ9NuGTRhi8t9kAf8wiwc2t9J7y8xEKj8R5pQz6m RuT/D2zhySGkcBuW3LV9OET9WujF46W/BmM64Q3HJQNC+K1PMnokH9weZiShDYaVyLPe szVA== MIME-Version: 1.0 X-Received: by 10.180.108.205 with SMTP id hm13mr7598232wib.5.1418757330444; Tue, 16 Dec 2014 11:15:30 -0800 (PST) Received: by 10.216.151.7 with HTTP; Tue, 16 Dec 2014 11:15:30 -0800 (PST) In-Reply-To: <548DDCF8.9040705@marc-hoersken.de> References: <548DDCF8.9040705@marc-hoersken.de> Date: Tue, 16 Dec 2014 19:15:30 +0000 X-Google-Sender-Auth: pxuWcX5wkoAhT73TTUunv8krdsg Message-ID: Subject: Re: CMake From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGJFaNf020246 On 14 December 2014 at 18:54, Marc Hoersken wrote: > > Please do not remove the existing build infrastructure, just yet. > CMake cannot replace all of them and even those that can be replaced > need to deprecated first and slowly phased out. I've left the autotools system in place, though removing it should be the long-term goal so that we have less to maintain, not more. I've removed the Windows project files because the CMake build provides all the fuctionality they had, and much more (if that's not the case, please let me know because it's a bug). > Please also keep the changes to non-CMake-relevant files to a minimum, see: > https://github.com/mback2k/libssh2/compare/cmake#files_bucket I limited changes that would affect non-CMake builds, but probably didn't avoid them entirely. The amount of effort required to create the CMake build, and test it in every available combination, has already taken so long that I decided it was more important to present that work before back-fixing the original builds. Did you have any specific changes in mind? > And before this can be merged into master, I think the smaller commits should be squashed into logical commits. Absolutely. Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 16 22:40:30 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGLdAc3012806; Tue, 16 Dec 2014 22:40:27 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGLd8PT012789 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Dec 2014 22:39:08 +0100 Received: (qmail 24904 invoked from network); 16 Dec 2014 21:40:42 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 16 Dec 2014 21:40:42 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Tue, 16 Dec 2014 21:40:42 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #288: Maximum concurrent connections to uniq servers X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/288#comment:2 Message-ID: <060.e61edc682e6bd8f9dd8b5842539754dd@libssh2.stuge.se> References: <045.dc250e6df202420df02b058541a1d53d@libssh2.stuge.se> X-Trac-Ticket-ID: 288 In-Reply-To: <045.dc250e6df202420df02b058541a1d53d@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGLd8PT012789 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGLdAc3012806 #288: Maximum concurrent connections to uniq servers -----------------------+--------------------------------- Reporter: dsyeager | Owner: Scott Yeager Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: API | Version: 1.4.2 Resolution: | Keywords: Maximum Connections Blocked By: | Blocks: -----------------------+--------------------------------- Changes (by raysatiro): * cc: raysatiro@… (added) -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 16 22:41:31 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGLeUTW014019; Tue, 16 Dec 2014 22:41:31 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGLduRG013082 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Dec 2014 22:39:56 +0100 Received: (qmail 24997 invoked from network); 16 Dec 2014 21:41:30 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 16 Dec 2014 21:41:30 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Tue, 16 Dec 2014 21:41:30 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #293: error in direct_tcpip.c example X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/293 Message-ID: <040.50f97f5ec9adf4d67ca239997a1097f9@libssh2.stuge.se> X-Trac-Ticket-ID: 293 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGLduRG013082 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGLeUTW014019 #293: error in direct_tcpip.c example ----------------------+-------------------- Reporter: bbo | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.5.0 Component: examples | Version: 1.4.2 Keywords: | Blocked By: Blocks: | ----------------------+-------------------- The example direct_tcpip.c doesn't take care of EAGAIN case return by libssh2_channel_write. This can lead to non transmitted file when this error is raised, while this should just delay the transmission because the socket are busy. To see the error, just run a process with high priority on the receiver of data trasnmitted through the libssh2_channel_write. Solution is just to retry the call to libssh2_channel_write one (or several) other time. Here under is the current code taken from the git repo today: Git repo code: wr = 0; do { i = libssh2_channel_write(channel, buf, len); if (i < 0) { fprintf(stderr, "libssh2_channel_write: %d\n", i); goto shutdown; } wr += i; } while(i > 0 && wr < len); Code patched: wr = 0; do { i = libssh2_channel_write(channel, buf, len); if (i >= 0) { wr += i; } else if(i == LIBSSH2_ERROR_EAGAIN) { fprintf(stderr, "libssh2_channel_write: LIBSSH2_ERROR_EAGAIN, retry to write\n"); } else { fprintf(stderr, "libssh2_channel_write: %d\n", i); goto shutdown; } } while(wr < len); -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 16 22:42:33 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGLfVup014709; Tue, 16 Dec 2014 22:42:33 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGLe81i013891 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Dec 2014 22:40:08 +0100 Received: (qmail 25153 invoked from network); 16 Dec 2014 21:41:42 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 16 Dec 2014 21:41:42 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Tue, 16 Dec 2014 21:41:42 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #292: Wrap all uses of socket with callbacks for better compatibility X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/292#comment:1 Message-ID: <060.49ec58ed343485d979923dc257e3ddd1@libssh2.stuge.se> References: <045.566659c6c868dc0804d29e0f4b7ab459@libssh2.stuge.se> X-Trac-Ticket-ID: 292 In-Reply-To: <045.566659c6c868dc0804d29e0f4b7ab459@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGLe81i013891 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGLfVup014709 #292: Wrap all uses of socket with callbacks for better compatibility --------------------------+----------------- Reporter: Eschaton | Owner: Type: enhancement | Status: new Priority: normal | Milestone: Component: API | Version: Resolution: | Keywords: Blocked By: | Blocks: --------------------------+----------------- Comment (by Eschaton): I've looked at this and it appears it would be pretty straightforward to do with only three additional callbacks modeled after the recv/send callbacks: - A get_blocking callback to get the current blocking state of the socket in the couple places it's checked - A set_blocking callback to set the current blocking state of the socket in the couple places it's adjusted - A poll callback to be used by _libssh2_wait_socket() and possibly the deprecated libssh2_poll() With only those three callbacks, it should be possible to layer libssh2 atop an arbitrary transport rather than specifically atop Berkeley sockets. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 16 22:43:35 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGLgXGH015561; Tue, 16 Dec 2014 22:43:35 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBGLefDW014171 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Dec 2014 22:40:41 +0100 Received: (qmail 25246 invoked from network); 16 Dec 2014 21:42:15 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 16 Dec 2014 21:42:15 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Tue, 16 Dec 2014 21:42:15 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #291: libssh2_agent_connect always returns -39 when using in on iOS X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/291#comment:1 Message-ID: <058.a26b9c2bdfcc72a44ad77a7743d0822a@libssh2.stuge.se> References: <043.8c2655804146d6ddbbf0357167280655@libssh2.stuge.se> X-Trac-Ticket-ID: 291 In-Reply-To: <043.8c2655804146d6ddbbf0357167280655@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGLefDW014171 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Reply-To: trac@libssh2.stuge.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBGLgXGH015561 #291: libssh2_agent_connect always returns -39 when using in on iOS ---------------------+------------------- Reporter: ali312 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: API | Version: 1.4.2 Resolution: | Keywords: Blocked By: | Blocks: ---------------------+------------------- Comment (by Eschaton): Apps on iOS can't run or communicate with their own daemons/agents, and iOS doesn't run an ssh agent itself, so this is behaving correctly. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 23 23:13:05 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBNMCeqS021042; Tue, 23 Dec 2014 23:13:00 +0100 Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com [IPv6:2a00:1450:400c:c05::231]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBNMCd7R020954 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128 verify=NOT) for ; Tue, 23 Dec 2014 23:12:39 +0100 Received: by mail-wi0-f177.google.com with SMTP id l15so12107053wiw.10 for ; Tue, 23 Dec 2014 14:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=HNMtYbN08M+0YDkbDnkJhGHrRzLZGAUTWBvBjaRzdss=; b=upV8zRtQtzWHfkhXink2eSbt/YHoCA+TE30vo2UrDrpJ3h4FuhS4cBDgoRx5sI2ruD Sxd6hNIbiSw1SqK9M26oMSRiS7RnYyo1i+ugPbzNKP27qw0wGrIHroFIKT7MJi13Ku9O Mz5ZQt355AONCAcJQiNtsQIo6gNroOyVLwXnVPDMxwDdXqGdRCeUvNiUALK+w2M2ghVK 6OBikpCjppnQUndLVVyorf3bGVlVTDsoSDTMcyxSdDSDDPQ3iAdmzWabwdwMUchhbO1e BE3EYx/EVGgWY/x361sTKZ85MRUNLHKtF2TAWiQnsct1fE+HC5PrWFalBHMs62RQOEln g98Q== MIME-Version: 1.0 X-Received: by 10.194.156.161 with SMTP id wf1mr55038816wjb.134.1419372755098; Tue, 23 Dec 2014 14:12:35 -0800 (PST) Received: by 10.216.151.7 with HTTP; Tue, 23 Dec 2014 14:12:35 -0800 (PST) In-Reply-To: References: <548DDCF8.9040705@marc-hoersken.de> Date: Tue, 23 Dec 2014 22:12:35 +0000 X-Google-Sender-Auth: bm2xZsXWCPmsGqiokVWiN3ssyJI Message-ID: Subject: Re: CMake From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBNMCeqS021042 On 16 December 2014 at 19:15, Alexander Lamaison wrote: > On 14 December 2014 at 18:54, Marc Hoersken wrote: >> >> And before this can be merged into master, I think the smaller commits > should be squashed into logical commits. > > Absolutely. I've rebased against latest master and squashed everything down to a few commits. The result is in the 'cmake-with-ci' branch: https://github.com/alamaison/libssh2/tree/cmake-with-ci. Thoughts? Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Dec 24 18:10:40 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBOHAD41000741; Wed, 24 Dec 2014 18:10:34 +0100 Received: from mail-wi0-x22c.google.com (mail-wi0-x22c.google.com [IPv6:2a00:1450:400c:c05::22c]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBOHABt8000663 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128 verify=NOT) for ; Wed, 24 Dec 2014 18:10:11 +0100 Received: by mail-wi0-f172.google.com with SMTP id n3so14005357wiv.17 for ; Wed, 24 Dec 2014 09:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=paHlOGoHfwLWOq9K5qI+raVAGkNMF6yoOD0WtVTDGy4=; b=J3HNlciM4mwoyjqVZBzj4ALha5aQ10WVeicYbIy6fbMTsUHcxK7trfG3vBJWTq5sD1 Ot06Z7Rbd97V8pTxVlbWxCk+7f0Rqh0XInXtbuSfv2tV97EimzBgEASuWbIkbegDpAMR O0ApLxRLc93GT/4Nw/Uq+7EEKtDx4yvJ0vnP+1n3/y8SfV9NMXF1ez/+Je81x9H2TTIS 1E+bfw+28dAebbYlhoSIFWQbe+kh1H2RwSWL+yh2ay7a03IUEkEIGFSeLByEbQ+DQ13H mJzL1Fw5KdZVA/tugroRnMOavZ7/JMvUJ5j1h5gBj3oZE0/dLUmpHIDvR9EN/zoEPC2S IFfw== MIME-Version: 1.0 X-Received: by 10.194.58.19 with SMTP id m19mr4932141wjq.52.1419441007643; Wed, 24 Dec 2014 09:10:07 -0800 (PST) Received: by 10.216.151.7 with HTTP; Wed, 24 Dec 2014 09:10:07 -0800 (PST) In-Reply-To: <548E2C25.1090603@marc-hoersken.de> References: <548E2C25.1090603@marc-hoersken.de> Date: Wed, 24 Dec 2014 17:10:07 +0000 X-Google-Sender-Auth: TRWEC8hTpcf1pMmP0sGZgoQNnCg Message-ID: Subject: Re: Additional questions related to my fixes of possible NULL pointer de-references From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sBOHAD41000741 On 15 December 2014 at 00:32, Marc Hoersken wrote: > Hello everyone, > > I just posted a bunch of patches to the Git repository that are the > result of running the code analysis feature of VS2012 against libssh2 > using the new CMake generated project files. > > Most of them are quite basic, but at least the following two patches > raise additional questions that I would like to bring to your attention: > - kex.c: fix possible NULL pointer de-reference with session->kex [1] This extra check isn't necessary because session->kex cannot be NULL if rc == 0. The call to kex_agree_methods on line 1749 returns -1 if session->kex is not initialised. > - packet.c: fix possible NULL pointer de-reference within listen_state [2] This case is less obvious, but the check is also unecessary. It's impossible for listen_state->channel to be NULL before it is de-referenced. Any path that arrives at line 219 must have passed line 142 because listen_state->state is initialised as _state_idle and the only way to reach line 219 is via the state transition on line 203. > I think that just catching the possible NULL pointer in those code paths > is actually not enough to make libssh2 behave correctly. > In my opinion some kind of error code needs to be raised if such an > error condition is reached. I think VS2012 was being a little overzealous. Does it output a particular path it claims would lead to the unhappy situation? > [1] > http://git.libssh2.org/?p=libssh2.git;a=commitdiff;h=1c1699545b0a1114e8ca3e6cd097cc9df1e67201;js=1 > [2] > http://git.libssh2.org/?p=libssh2.git;a=commitdiff;h=e57f29f8f65c83063fd8f63c88f88830fc269bd6;js=1 Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Dec 26 11:09:32 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBQA92g6012583; Fri, 26 Dec 2014 11:09:26 +0100 Received: from mx.uxnr.de (mx.uxnr.de [IPv6:2a00:1828:2000:378:3:25:59ee:5430]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sBQA91wq012406 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 26 Dec 2014 11:09:01 +0100 Received: from marcs-mbp.ob01.uxnr.net (p3EE2D91E.dip0.t-ipconnect.de [62.226.217.30]) by mx.uxnr.de (Postfix) with ESMTPSA id 2B7AD1C5A2F5 for ; Fri, 26 Dec 2014 11:08:56 +0100 (CET) X-DKIM: OpenDKIM Filter v2.6.8 mx.uxnr.de 2B7AD1C5A2F5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=marc-hoersken.de; s=picard; t=1419588536; bh=el9U8wjtxi8zp+ysZ45tLMHHGx3NG0DYL++NjRY7ZFo=; h=Subject:From:In-Reply-To:Date:References:To:From; b=ESADBuG6MfdWDLiUrAdayPAmY/3/QpqDNlvuZ9D/TE4tkPLn5AkURPLgpOZkxrYUr bZmLnORVfxNf4qIL0Zs3/UUcwFNwkYrjazpi94qMYh4fSRsNjeBBfux1UbItE+yO4R o1pP84ZK5+cQWFL6lQ/FxmUcxe+uqxH2GGyf8BII= Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: [PATCH] silence multiple data conversion warnings X-Pgp-Agent: GPGMail 2.5b3 From: =?utf-8?Q?Marc_H=C3=B6rsken?= In-Reply-To: Date: Fri, 26 Dec 2014 11:08:48 +0100 Message-Id: <855E0A9B-13C5-470C-90C1-01C53181A12D@marc-hoersken.de> References: To: libssh2 development X-Mailer: Apple Mail (2.1993) X-Spam-Status: No, score=0.1 required=5.0 tests=DKIM_SIGNED,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on picard.vpn.uxnr.de X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0101413031==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0101413031== Content-Type: multipart/signed; boundary="Apple-Mail=_1CCFD0B7-CCDA-452B-9F40-511C92F657CA"; protocol="application/pgp-signature"; micalg=pgp-sha512 --Apple-Mail=_1CCFD0B7-CCDA-452B-9F40-511C92F657CA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hello everyone, I just pushed the relevant patch to the repository. Best regards, Marc > Am 15.12.2014 um 12:26 schrieb Marc H=C3=B6rsken = : >=20 > <0001-silence-multiple-data-conversion-warnings.patch> --Apple-Mail=_1CCFD0B7-CCDA-452B-9F40-511C92F657CA Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUnTOwAAoJEPhLrsrSvXftes0H/1vNha92yeR6O4Asmsyu4/DG nTAn9Unb752WwcIoUtjNCq2ojAEjuj7IxKwikTe/SweTmwM7Ofv9BxTXESbFKw66 3KZmMm423vevfPt5DoVYO+78QhMmO1lrkz+bCny+lMcpE8pVAsBUsLSIqqGK3WOo jyauSPMdGWSnDbcad4Uq+wsmsfNTWGSzMklTvLnkcTMwwCurltOOfdkBLDmIfO9q D1CkuH/ghVDWa59zj8aKNPzURdIo7MeOkicOGmixLcwN1swU8B3uPH9B/CcQFpeC 1dP56OtC6D+SXVOekOzPPL0gSbszK3TNuxFbBy+cuW0eJibeeOaIkGHircKdqXQ= =yElh -----END PGP SIGNATURE----- --Apple-Mail=_1CCFD0B7-CCDA-452B-9F40-511C92F657CA-- --===============0101413031== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0101413031==--