From libssh2-devel-bounces@cool.haxx.se Thu Dec 3 18:46:13 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB3Hjo7o010709; Thu, 3 Dec 2015 18:46:10 +0100 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB3Hjlxp010057 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 3 Dec 2015 18:45:49 +0100 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 471C0C001247; Thu, 3 Dec 2015 17:45:47 +0000 (UTC) Received: from kdudka.brq.redhat.com (kdudka.brq.redhat.com [10.34.4.67]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB3HjiCn010885; Thu, 3 Dec 2015 12:45:45 -0500 From: Kamil Dudka To: libssh2-devel@cool.haxx.se Subject: [PATCH] libssh2.pc.in: fix the output of pkg-config --libs Date: Thu, 3 Dec 2015 18:45:41 +0100 Message-Id: <1449164741-6370-1-git-send-email-kdudka@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Cc: Paul Howarth X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tB3Hjo7o010709 From: Paul Howarth ... such that it does not include LDFLAGS used to build libssh2 itself. There was a similar fix in the curl project long time ago: https://github.com/bagder/curl/commit/curl-7_19_7-56-g4c8adc8 Bug: https://bugzilla.redhat.com/1279966 Signed-off-by: Kamil Dudka --- libssh2.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libssh2.pc.in b/libssh2.pc.in index 26d8a45..084918a 100644 --- a/libssh2.pc.in +++ b/libssh2.pc.in @@ -12,6 +12,6 @@ URL: http://www.libssh2.org/ Description: Library for SSH-based communication Version: @LIBSSH2VER@ Requires.private: @LIBSREQUIRED@ -Libs: -L${libdir} -lssh2 @LDFLAGS@ @LIBS@ +Libs: -L${libdir} -lssh2 @LIBS@ Libs.private: @LIBS@ Cflags: -I${includedir} -- 2.5.0 _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sat Dec 5 00:27:23 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB4NQxDL017634; Sat, 5 Dec 2015 00:27:19 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB4NQu9b017558 for ; Sat, 5 Dec 2015 00:26:56 +0100 Received: from [10.0.0.187] (unknown [38.103.165.36]) by mail.panic.com (Postfix) with ESMTPSA id 194A8CA02E3E for ; Fri, 4 Dec 2015 15:26:46 -0800 (PST) From: Will Cosgrove Subject: Elliptical Curve Progress Message-Id: <5B9716C2-58A6-4118-97BF-156BC5BEB0C0@panic.com> Date: Fri, 4 Dec 2015 15:26:51 -0800 To: libssh2 development Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) X-Mailer: Apple Mail (2.3096.5) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id tB4NQu9b017558 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tB4NQxDL017634 Hi All, I wanted to give you guys a heads up, I’m working on ecdsa-sha2-nistp256 host key support as well as KEX (ecdh-sha2-nistp256) support. I will likely add nistp384/521 KEX support as well. I’ve also added sha256 host key hash support to be in line with OpenSSH as they now default to sha256 hashes. I plan on landing these changes post libssh2 release to let them have a time to bake a bit. Let me know if you have any questions/comments. Cheers, Will _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sat Dec 5 00:36:28 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB4NaOoi003390; Sat, 5 Dec 2015 00:36:28 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB4NaMQb003203 for ; Sat, 5 Dec 2015 00:36:22 +0100 Received: from [10.0.0.187] (unknown [38.103.165.36]) by mail.panic.com (Postfix) with ESMTPSA id 8A1A6CA030B2 for ; Fri, 4 Dec 2015 15:36:12 -0800 (PST) From: Will Cosgrove Subject: MAC ETM Progress Message-Id: <74F4B6A3-6A56-4305-A71F-D7582F31097B@panic.com> Date: Fri, 4 Dec 2015 15:36:17 -0800 To: libssh2 development Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) X-Mailer: Apple Mail (2.3096.5) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id tB4NaMQb003203 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tB4NaOoi003390 Hi Again, One last thing I forgot, I’ve added hmac-sha2-512-etm@openssh.com and hmac-sha2-256-etm@openssh.com MAC support as well. ETM support means pretty low level work on the transport layer. It’s working well (and has been shipping in our apps for a while now). I also plan on landing that patch post release. Cheers, Will _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sat Dec 5 21:30:41 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB5KUJbc020781; Sat, 5 Dec 2015 21:30:37 +0100 Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB5KUHqh020769 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for ; Sat, 5 Dec 2015 21:30:17 +0100 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1a5JTE-0001Ab-5k for libssh2-devel@cool.haxx.se; Sat, 05 Dec 2015 21:30:16 +0100 Received: from 92.56.141.104 ([92.56.141.104]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 05 Dec 2015 21:30:16 +0100 Received: from sfandino by 92.56.141.104 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 05 Dec 2015 21:30:16 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: libssh2-devel@cool.haxx.se From: =?UTF-8?Q?Salvador_Fandi=c3=b1o?= Subject: [PATCH] agent_disconnect_unix: unset the agent fd after closing it Date: Sat, 5 Dec 2015 21:30:04 +0100 Lines: 70 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020309090404000100050907" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 92.56.141.104 X-Mozilla-News-Host: news://nntp.gmane.org:119 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" This is a multi-part message in MIME format. --------------020309090404000100050907 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit agent_disconnect_unix", called by "libssh2_agent_disconnect", was leaving the file descriptor in the agent structure unchanged. Later, "libssh2_agent_free" would call again "libssh2_agent_disconnect" under the hood and it would try to close again the same file descriptor. In most cases that resulted in just a harmless error, but it is also possible that the file descriptor had been reused between the two calls resulting in the closing of an unrelated file descriptor. This patch sets agent->fd to LIBSSH2_INVALID_SOCKET avoiding that issue. --------------020309090404000100050907 Content-Type: text/x-patch; name="0001-agent_disconnect_unix-unset-the-agent-fd-after-closi.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename*0="0001-agent_disconnect_unix-unset-the-agent-fd-after-closi.pa"; filename*1="tch" From de2afe816035354ef58fec03094c869fca4b95b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Salvador=20Fandi=C3=B1o?= Date: Sat, 5 Dec 2015 21:16:13 +0100 Subject: [PATCH] agent_disconnect_unix: unset the agent fd after closing it MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "agent_disconnect_unix", called by "libssh2_agent_disconnect", was leaving the file descriptor in the agent structure unchanged. Later, "libssh2_agent_free" would call again "libssh2_agent_disconnect" under the hood and it would try to close again the same file descriptor. In most cases that resulted in just a harmless error, but it is also possible that the file descriptor had been reused between the two calls resulting in the closing of an unrelated file descriptor. This patch sets agent->fd to LIBSSH2_INVALID_SOCKET avoiding that issue. Signed-off-by: Salvador Fandiño --- src/agent.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/agent.c b/src/agent.c index b797cbd..e771643 100644 --- a/src/agent.c +++ b/src/agent.c @@ -239,8 +239,9 @@ agent_disconnect_unix(LIBSSH2_AGENT *agent) { int ret; ret = close(agent->fd); - - if(ret == -1) + if(ret != -1) + agent->fd = LIBSSH2_INVALID_SOCKET; + else return _libssh2_error(agent->session, LIBSSH2_ERROR_SOCKET_DISCONNECT, "failed closing the agent socket"); return LIBSSH2_ERROR_NONE; -- 2.5.0 --------------020309090404000100050907 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --------------020309090404000100050907-- From libssh2-devel-bounces@cool.haxx.se Mon Dec 7 13:56:52 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB7CuR29005936; Mon, 7 Dec 2015 13:56:49 +0100 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB7CuOn9005860 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 7 Dec 2015 13:56:25 +0100 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 75ADCC0B0209; Mon, 7 Dec 2015 12:56:23 +0000 (UTC) Received: from kdudka.brq.redhat.com (kdudka.brq.redhat.com [10.34.4.67]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB7CuKFk025363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 7 Dec 2015 07:56:22 -0500 From: Kamil Dudka To: Peter Stuge Subject: upstream git repo (was Re: [PATCH] add function libssh2_session_set_last_error) Date: Mon, 07 Dec 2015 13:56:07 +0100 Message-ID: <4815853.8VTd6kyyDR@kdudka.brq.redhat.com> User-Agent: KMail/4.14.10 (Linux/4.2.6-301.fc23.x86_64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <20151102164014.729.qmail@stuge.se> References: <20151102164014.729.qmail@stuge.se> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Cc: Daniel Stenberg , libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tB7CuR29005936 On Monday 02 November 2015 17:40:14 Peter Stuge wrote: > Daniel Stenberg wrote: > >> Daniel, I think you have to decide exactly what you want git.libssh2.org > >> and trac.libssh2.org to do in the future, if anything. > > > > The former git repo at git.libssh2.org has been abandoned and > > we only use that as a historical reference in case of need. > > Sorry, but that's contradictory. It is either abandoned or being used. > (As an archive.) If used as archive then I'll clean up the users. > If abandoned then I'd suggest a redirect to github.com. So it is one month later and we still have two _divergent_ git repositories that both look like upstream? Kamil > > trac.libssh2.org is still populated with lots of bug reports that we > > haven't taken care of, so it would be nice to keep that around for an > > unknown period going forward. > > That's fine. > > > //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Dec 7 14:24:25 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB7DOJc5026537; Mon, 7 Dec 2015 14:24:24 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB7DOHSA026533 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 7 Dec 2015 14:24:18 +0100 Received: (qmail 24305 invoked by uid 501); 7 Dec 2015 13:24:18 -0000 Message-ID: <20151207132418.24304.qmail@stuge.se> Date: Mon, 7 Dec 2015 14:24:18 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: upstream git repo (was Re: [PATCH] add function libssh2_session_set_last_error) Mail-Followup-To: libssh2-devel@cool.haxx.se References: <20151102164014.729.qmail@stuge.se> <4815853.8VTd6kyyDR@kdudka.brq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4815853.8VTd6kyyDR@kdudka.brq.redhat.com> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tB7DOJc5026537 Kamil Dudka wrote: > On Monday 02 November 2015 17:40:14 Peter Stuge wrote: > > > The former git repo at git.libssh2.org has been abandoned and > > > we only use that as a historical reference in case of need. > > > > Sorry, but that's contradictory. It is either abandoned or being used. > > (As an archive.) If used as archive then I'll clean up the users. > > If abandoned then I'd suggest a redirect to github.com. > > So it is one month later and we still have two _divergent_ git > repositories that both look like upstream? Yes, that's what happens when noone has free time. The ball lies with Daniel - he needs to decide whether the repository is abandoned (in which case I would like to redirect from there to github.com) or whether it is being used in some way. It can not be both abandoned and used at the same time. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 8 18:02:16 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB8H1n2p012739; Tue, 8 Dec 2015 18:02:11 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB8H1nDM012732 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 8 Dec 2015 18:01:49 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id tB8H1msd012729 for ; Tue, 8 Dec 2015 18:01:49 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Tue, 8 Dec 2015 18:01:48 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: upstream git repo (was Re: [PATCH] add function libssh2_session_set_last_error) In-Reply-To: <4815853.8VTd6kyyDR@kdudka.brq.redhat.com> Message-ID: References: <20151102164014.729.qmail@stuge.se> <4815853.8VTd6kyyDR@kdudka.brq.redhat.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tB8H1n2p012739 On Mon, 7 Dec 2015, Kamil Dudka wrote: > So it is one month later and we still have two _divergent_ git repositories > that both look like upstream? The github one is the upstream one since many months back. Is there any mention somehwere that makes this unclear? -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 8 18:20:19 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB8HKDoC028957; Tue, 8 Dec 2015 18:20:18 +0100 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB8HK9Rg028876 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 8 Dec 2015 18:20:10 +0100 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id CCE15C0B7A19; Tue, 8 Dec 2015 17:20:09 +0000 (UTC) Received: from kdudka.brq.redhat.com (kdudka.brq.redhat.com [10.34.4.67]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB8HK8Qn017336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 8 Dec 2015 12:20:09 -0500 From: Kamil Dudka To: Daniel Stenberg Subject: Re: upstream git repo (was Re: [PATCH] add function libssh2_session_set_last_error) Date: Tue, 08 Dec 2015 18:19:59 +0100 Message-ID: <2899193.bJksf5fq1P@kdudka.brq.redhat.com> User-Agent: KMail/4.14.10 (Linux/4.2.6-301.fc23.x86_64; KDE/4.14.14; x86_64; ; ) In-Reply-To: References: <4815853.8VTd6kyyDR@kdudka.brq.redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tB8HKDoC028957 On Tuesday 08 December 2015 18:01:48 Daniel Stenberg wrote: > On Mon, 7 Dec 2015, Kamil Dudka wrote: > > So it is one month later and we still have two _divergent_ git > > repositories > > that both look like upstream? > > The github one is the upstream one since many months back. Is there any > mention somehwere that makes this unclear? One would expect that a git repository at http://git.libssh2.org/ named libssh2 is the upstream git repository for the libssh2 project. I am not sure if removing external references to it is enough to avoid confusion. Kamil _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 8 18:28:57 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB8HSssh007349; Tue, 8 Dec 2015 18:28:57 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tB8HSr6T007342 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 8 Dec 2015 18:28:53 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id tB8HSrJe007338; Tue, 8 Dec 2015 18:28:53 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Tue, 8 Dec 2015 18:28:53 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: Kamil Dudka , Peter Stuge Subject: Re: upstream git repo (was Re: [PATCH] add function libssh2_session_set_last_error) In-Reply-To: <2899193.bJksf5fq1P@kdudka.brq.redhat.com> Message-ID: References: <4815853.8VTd6kyyDR@kdudka.brq.redhat.com> <2899193.bJksf5fq1P@kdudka.brq.redhat.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 Cc: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tB8HSssh007349 On Tue, 8 Dec 2015, Kamil Dudka wrote: > One would expect that a git repository at http://git.libssh2.org/ named > libssh2 is the upstream git repository for the libssh2 project. I am not > sure if removing external references to it is enough to avoid confusion. Fair enough. Peter, can you please shut down your libssh2 git server there? I've asked Sara to remove the entry from the libssh2.org domain as well. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sat Dec 12 13:58:54 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBCCwPpP002797; Sat, 12 Dec 2015 13:58:50 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBCCwO2j002793 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 12 Dec 2015 13:58:24 +0100 Received: (qmail 6390 invoked from network); 12 Dec 2015 13:06:51 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 12 Dec 2015 13:06:51 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Cc: libssh2-devel@cool.haxx.se Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software X-Trac-Project: libssh2 Date: Sat, 12 Dec 2015 13:06:51 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #309: latest libssh2 library fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/309 Message-ID: <044.d5e68fb6fb081e9e153178a9fd059545@libssh2.stuge.se> X-Trac-Ticket-ID: 309 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tBCCwO2j002793 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tBCCwPpP002797 #309: latest libssh2 library fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile ---------------------+-------------------- Reporter: mohisan | Owner: Type: defect | Status: new Priority: high | Milestone: 1.4.3 Component: API | Version: 1.5.0 Keywords: | Blocked By: Blocks: | ---------------------+-------------------- libssh2 library was build against MinGW Makefiles and using OpenSSL. Target OS Windows 7. public/private key pair was generated using OpenSSL, without passphrase. I am using freeSSHd Server application, where I set a user "testuser" and authentication SSH public key only. My Code look like this: {{{ // authenticate by public key. int iResult = libssh2_userauth_publickey_fromfile( mySession, "testuser", "public.pem", "private.pem", NULL ); }}} '''iResult''' always returns '''LIBSSH2_ERROR_PUBLICKEY_UNVERIFIED'''. what am I doing wrong? I really can't help myself and I couldn't find out what I am doing wrong. By the way '''libssh2_userauth_password''' works fine, but I need public key authentication Could you please help me. Mohi -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 15 05:19:39 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBF4JF5E030320; Tue, 15 Dec 2015 05:19:35 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBF4JDhT030299 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 15 Dec 2015 05:19:13 +0100 Received: (qmail 30507 invoked by uid 501); 15 Dec 2015 04:19:13 -0000 Message-ID: <20151215041913.30506.qmail@stuge.se> Date: Tue, 15 Dec 2015 05:19:13 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: upstream git repo (was Re: [PATCH] add function libssh2_session_set_last_error) Mail-Followup-To: libssh2-devel@cool.haxx.se References: <4815853.8VTd6kyyDR@kdudka.brq.redhat.com> <2899193.bJksf5fq1P@kdudka.brq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tBF4JF5E030320 Daniel Stenberg wrote: >> One would expect that a git repository at http://git.libssh2.org/ named >> libssh2 is the upstream git repository for the libssh2 project. I am not >> sure if removing external references to it is enough to avoid confusion. > > Fair enough. Peter, can you please shut down your libssh2 git server there? I've put a 301 Moved Permanently HTTP redirect from git.libssh2.org to https://github.com/libssh2/libssh2 I'll (re)move the repositores so that git:// can no longer access them. > I've asked Sara to remove the entry from the libssh2.org domain as well. Oh ok. Feel free to keep the HTTP redirect as long (or short) as you like. :) //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Dec 15 11:41:32 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBFAfBST010688; Tue, 15 Dec 2015 11:41:28 +0100 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBFAf6gO010327 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 15 Dec 2015 11:41:07 +0100 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 1A6C5B0F9F; Tue, 15 Dec 2015 10:41:00 +0000 (UTC) Received: from nbkamil.localnet (ovpn-204-32.brq.redhat.com [10.40.204.32]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBFAexKt012661; Tue, 15 Dec 2015 05:41:00 -0500 From: Kamil Dudka To: libssh2-devel@cool.haxx.se Subject: Re: [PATCH] libssh2.pc.in: fix the output of pkg-config --libs Date: Tue, 15 Dec 2015 11:40:36 +0100 Message-ID: <1749199.Wny3GYkxqT@nbkamil> User-Agent: KMail/4.14.8 (Linux/4.1.12-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1449164741-6370-1-git-send-email-kdudka@redhat.com> References: <1449164741-6370-1-git-send-email-kdudka@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Cc: Paul Howarth X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tBFAfBST010688 On Thursday, December 03, 2015 18:45:41 Kamil Dudka wrote: > From: Paul Howarth > > ... such that it does not include LDFLAGS used to build libssh2 itself. Pushed upstream: https://github.com/libssh2/libssh2/commit/9bf32da6 Kamil > There was a similar fix in the curl project long time ago: > > https://github.com/bagder/curl/commit/curl-7_19_7-56-g4c8adc8 > > Bug: https://bugzilla.redhat.com/1279966 > Signed-off-by: Kamil Dudka > --- > libssh2.pc.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libssh2.pc.in b/libssh2.pc.in > index 26d8a45..084918a 100644 > --- a/libssh2.pc.in > +++ b/libssh2.pc.in > @@ -12,6 +12,6 @@ URL: http://www.libssh2.org/ > Description: Library for SSH-based communication > Version: @LIBSSH2VER@ > Requires.private: @LIBSREQUIRED@ > -Libs: -L${libdir} -lssh2 @LDFLAGS@ @LIBS@ > +Libs: -L${libdir} -lssh2 @LIBS@ > Libs.private: @LIBS@ > Cflags: -I${includedir} _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Dec 20 18:45:34 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBKHj3qB028478; Sun, 20 Dec 2015 18:45:30 +0100 Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com [IPv6:2607:f8b0:4001:c05::22a]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBKHj1oe027715 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 20 Dec 2015 18:45:02 +0100 Received: by mail-ig0-x22a.google.com with SMTP id mv3so19620574igc.0 for ; Sun, 20 Dec 2015 09:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=QT5ioZLrBuvF80M905e9TVmR8Wd1gsOG3iggJAi5ZqI=; b=hSUmq5rl4crOdFZp/8Ho9/RB4FxbPjGiMQmY7mNxHFRkJnViC+Ma/wC4CiviuhhBRr 5udKnv0doCBoVyccoITU9NXT3dmZDSZbVqsQzhaRni1VjEos+wQsjDTHPIglXTdsWTLK o3O1v4WGDgxMNVkBxbiXypDdfiT3v0AXfqlikYJRmLCda0TCVbFJWYyTSkdOmKilWUz/ P/ExUL7GMYBKpLTELScXFSFP62kYQOfrMZYJ2CHorItBJ3tgL/OBwJvICMOyAxeqHHwH 0CJuO6kBvqjYZQxZYgxzd/OEz2Ime/pB9lCGHUXSkphFJLSqvv0dvG2vVarXf9qhZ3SN QsXg== MIME-Version: 1.0 X-Received: by 10.50.13.100 with SMTP id g4mr13141794igc.64.1450633497189; Sun, 20 Dec 2015 09:44:57 -0800 (PST) Received: by 10.79.97.131 with HTTP; Sun, 20 Dec 2015 09:44:57 -0800 (PST) Date: Sun, 20 Dec 2015 11:44:57 -0600 Message-ID: Subject: problems building under Windows From: Matthew Fleming To: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0064153950==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0064153950== Content-Type: multipart/alternative; boundary=089e013c66144ca22c052757ee87 --089e013c66144ca22c052757ee87 Content-Type: text/plain; charset=UTF-8 Hi, I'm trying to build libssh2 for use under Windows. I am using Visual Studio Community 2015 under Windows 10. I tried opening the Visual Studio Solution under libssh2-1.6.0/win. Trying to build this solution produces the following error: 1>cl : Command line error D8016: '/ZI' and '/Gy-' command-line options are incompatible 2>cl : Command line error D8016: '/ZI' and '/Gy-' command-line options are incompatible When I remove the /ZI switch I get this error: version.c 1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4005: 'snprintf': macro redefinition 1> ..\win32\libssh2_config.h(27): note: see previous definition of 'snprintf' 1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error: Macro definition of snprintf conflicts with Standard Library function declaration 1> wincng.c 1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4005: 'snprintf': macro redefinition 1> ..\win32\libssh2_config.h(27): note: see previous definition of 'snprintf' 1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error: Macro definition of snprintf conflicts with Standard Library function declaration I get the same snprintf error if I use nmake. Advice as to how to solve these problems would be greatly appreciated, thanks. Matthew Fleming --089e013c66144ca22c052757ee87 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,=C2=A0

I'm trying to build libss= h2 for use under Windows. I am using Visual Studio Community 2015 under Win= dows 10. I tried opening the Visual Studio Solution under libssh2-1.6.0/win= . Trying to build this solution produces the following error:
1>cl : Command line error D8016: '/ZI' and '= ;/Gy-' command-line options are incompatible
2>cl : Comman= d line error D8016: '/ZI' and '/Gy-' command-line options a= re incompatible

When I remove the /ZI switch= I get this error:

=C2=A0version.c
= 1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio= .h(1925): warning C4005: 'snprintf': macro redefinition
1= > =C2=A0..\win32\libssh2_config.h(27): note: see previous definition of = 'snprintf'
1>C:\Program Files (x86)\Windows Kits\10\In= clude\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error: =C2=A0Mac= ro definition of snprintf conflicts with Standard Library function declarat= ion
1> =C2=A0wincng.c
1>C:\Program Files (x86)\Wi= ndows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4005: '= snprintf': macro redefinition
1> =C2=A0..\win32\libssh2_co= nfig.h(27): note: see previous definition of 'snprintf'
1= >C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.= h(1927): fatal error C1189: #error: =C2=A0Macro definition of snprintf conf= licts with Standard Library function declaration

=
I get the same snprintf error if I use nmake.

Advice as to how to solve these problems would be greatly appreciated, tha= nks.

Matthew Fleming


=
--089e013c66144ca22c052757ee87-- --===============0064153950== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0064153950==-- From libssh2-devel-bounces@cool.haxx.se Sun Dec 20 19:11:59 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBKIBqD5014611; Sun, 20 Dec 2015 19:11:57 +0100 Received: from mail.rcousins.com (mail.rcousins.com [66.220.7.56]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBKIBoM9014590 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 20 Dec 2015 19:11:51 +0100 Received: from android-10492b4077af4e4a.beef (76-244-45-114.lightspeed.sntcca.sbcglobal.net [76.244.45.114]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail.rcousins.com (Postfix) with ESMTPSA id B7EE5C21585; Sun, 20 Dec 2015 10:11:44 -0800 (PST) User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Subject: Re: problems building under Windows From: Matthew Voss Date: Sun, 20 Dec 2015 10:11:43 -0800 To: libssh2 development , Matthew Fleming Message-ID: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0528279079==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0528279079== Content-Type: multipart/alternative; boundary="----K44S9RBMBHJIV27YUA55V73B2I7Z70" Content-Transfer-Encoding: 8bit ------K44S9RBMBHJIV27YUA55V73B2I7Z70 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Do you have access to the cmake build file? It should be CMakeLists.txt under the root directory. Cmake should be able to generate all the necessary build files. Matthew On December 20, 2015 9:44:57 AM PST, Matthew Fleming wrote: >Hi, > >I'm trying to build libssh2 for use under Windows. I am using Visual >Studio >Community 2015 under Windows 10. I tried opening the Visual Studio >Solution >under libssh2-1.6.0/win. Trying to build this solution produces the >following error: > >1>cl : Command line error D8016: '/ZI' and '/Gy-' command-line options >are >incompatible >2>cl : Command line error D8016: '/ZI' and '/Gy-' command-line options >are >incompatible > >When I remove the /ZI switch I get this error: > > version.c >1>C:\Program Files (x86)\Windows >Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4005: >'snprintf': >macro redefinition >1> ..\win32\libssh2_config.h(27): note: see previous definition of >'snprintf' >1>C:\Program Files (x86)\Windows >Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: >#error: > Macro definition of snprintf conflicts with Standard Library function >declaration >1> wincng.c >1>C:\Program Files (x86)\Windows >Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4005: >'snprintf': >macro redefinition >1> ..\win32\libssh2_config.h(27): note: see previous definition of >'snprintf' >1>C:\Program Files (x86)\Windows >Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: >#error: > Macro definition of snprintf conflicts with Standard Library function >declaration > >I get the same snprintf error if I use nmake. > >Advice as to how to solve these problems would be greatly appreciated, >thanks. > >Matthew Fleming > > >------------------------------------------------------------------------ > >_______________________________________________ >libssh2-devel >http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel -- Sent from my Android device with K-9 Mail. Please excuse my brevity. ------K44S9RBMBHJIV27YUA55V73B2I7Z70 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit Do you have access to the cmake build file? It should be CMakeLists.txt under the root directory. Cmake should be able to generate all the necessary build files.

Matthew

On December 20, 2015 9:44:57 AM PST, Matthew Fleming <mgflem@gmail.com> wrote:
Hi, 

I'm trying to build libssh2 for use under Windows. I am using Visual Studio Community 2015 under Windows 10. I tried opening the Visual Studio Solution under libssh2-1.6.0/win. Trying to build this solution produces the following error:

1>cl : Command line error D8016: '/ZI' and '/Gy-' command-line options are incompatible
2>cl : Command line error D8016: '/ZI' and '/Gy-' command-line options are incompatible

When I remove the /ZI switch I get this error:

 version.c
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4005: 'snprintf': macro redefinition
1>  ..\win32\libssh2_config.h(27): note: see previous definition of 'snprintf'
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error:  Macro definition of snprintf conflicts with Standard Library function declaration
1>  wincng.c
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4005: 'snprintf': macro redefinition
1>  ..\win32\libssh2_config.h(27): note: see previous definition of 'snprintf'
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error:  Macro definition of snprintf conflicts with Standard Library function declaration

I get the same snprintf error if I use nmake.

Advice as to how to solve these problems would be greatly appreciated, thanks.

Matthew Fleming



libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

--
Sent from my Android device with K-9 Mail. Please excuse my brevity. ------K44S9RBMBHJIV27YUA55V73B2I7Z70-- --===============0528279079== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0528279079==-- From libssh2-devel-bounces@cool.haxx.se Sun Dec 20 22:16:44 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBKLGMdO005426; Sun, 20 Dec 2015 22:16:41 +0100 Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBKLGJaT005398 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 20 Dec 2015 22:16:20 +0100 Received: by mail-io0-x22d.google.com with SMTP id q126so137457358iof.2 for ; Sun, 20 Dec 2015 13:16:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=BgTq2gpvm1Cv0rED4KhkirWxLRWX9PDLnAvl+skrSO0=; b=q+QrECiGXPMdIGStV7KeRjBfggvOdkZjZ0ggalBO73x2EQKhu+kpW68EUm3P+6fjBP WJQRuzhQoUhieJg4Six7jv+aE8UZFBqWVABhDMxBbVAKzCaN0zP31OksIi2n//Y7FwlF 3iBsRX5sWzXHvD+jr6nj2F63PKbINke/4431UeVYmPeTGhCYM33+B0Bvv6o5PIRv55ga 9AKTLX2/gasqcnW46SDQWBktnKJYcUHbZIoA10sPkZLuvnTkpRYGhNssNDDZuvt2XgSa F5CqLxSbySoVHeLGLGPYrGjE7eLdvLRyXT0sHyjyxzaI/GbOVHRpnyDT6XKbDmFTkcqT 5Keg== MIME-Version: 1.0 X-Received: by 10.107.170.194 with SMTP id g63mr15279311ioj.178.1450646175019; Sun, 20 Dec 2015 13:16:15 -0800 (PST) Received: by 10.79.97.131 with HTTP; Sun, 20 Dec 2015 13:16:14 -0800 (PST) In-Reply-To: References: Date: Sun, 20 Dec 2015 15:16:14 -0600 Message-ID: Subject: Re: problems building under Windows From: Matthew Fleming To: Matthew Voss Cc: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============1749645269==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============1749645269== Content-Type: multipart/alternative; boundary=001a1141d432f4ff2905275ae129 --001a1141d432f4ff2905275ae129 Content-Type: text/plain; charset=UTF-8 Thanks for the suggestion. I was eventually able to get the library built, but its not working quite right. I tried to send a file with sample code from http://www.libssh2.org/examples/sftp_write.html. This code: /* Request a file via SFTP */ sftp_handle = libssh2_sftp_open(sftp_session, sftppath, LIBSSH2_FXF_WRITE | LIBSSH2_FXF_CREAT | LIBSSH2_FXF_TRUNC, LIBSSH2_SFTP_S_IRUSR | LIBSSH2_SFTP_S_IWUSR | LIBSSH2_SFTP_S_IRGRP | LIBSSH2_SFTP_S_IROTH); if (!sftp_handle) { fprintf(stderr, "Unable to open file with SFTP\n"); char *error; int errmsg_len, want_buf=1; libssh2_session_last_error(session, &error, &errmsg_len, want_buf); fprintf(stderr, "%s\n", error); goto shutdown; } produces this error: libssh2_sftp_init()! libssh2_sftp_open()! Unable to open file with SFTP Failed opening remote file all done This is not a very informative message, and I don't know what to do with it. I am trying to transfer from a Windows 10 machine to a Raspberry Pi running Ubuntu Linux. There doesn't seem to be any problem with the server, because I can transfer to the server from the same Windows machine using WinSCP. There don't seem to be any problems with directory permissions, etc. Any suggestions would be greatly appreciated. Matthew Fleming On Sun, Dec 20, 2015 at 12:11 PM, Matthew Voss wrote: > Do you have access to the cmake build file? It should be CMakeLists.txt > under the root directory. Cmake should be able to generate all the > necessary build files. > > Matthew > > On December 20, 2015 9:44:57 AM PST, Matthew Fleming > wrote: > >> Hi, >> >> I'm trying to build libssh2 for use under Windows. I am using Visual >> Studio Community 2015 under Windows 10. I tried opening the Visual Studio >> Solution under libssh2-1.6.0/win. Trying to build this solution produces >> the following error: >> >> 1>cl : Command line error D8016: '/ZI' and '/Gy-' command-line options >> are incompatible >> 2>cl : Command line error D8016: '/ZI' and '/Gy-' command-line options >> are incompatible >> >> When I remove the /ZI switch I get this error: >> >> version.c >> 1>C:\Program Files (x86)\Windows >> Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4005: 'snprintf': >> macro redefinition >> 1> ..\win32\libssh2_config.h(27): note: see previous definition of >> 'snprintf' >> 1>C:\Program Files (x86)\Windows >> Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error: >> Macro definition of snprintf conflicts with Standard Library function >> declaration >> 1> wincng.c >> 1>C:\Program Files (x86)\Windows >> Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4005: 'snprintf': >> macro redefinition >> 1> ..\win32\libssh2_config.h(27): note: see previous definition of >> 'snprintf' >> 1>C:\Program Files (x86)\Windows >> Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error: >> Macro definition of snprintf conflicts with Standard Library function >> declaration >> >> I get the same snprintf error if I use nmake. >> >> Advice as to how to solve these problems would be greatly appreciated, >> thanks. >> >> Matthew Fleming >> >> >> ------------------------------ >> >> libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel >> >> > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity. > --001a1141d432f4ff2905275ae129 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks for the suggestion. I was eventually able to get th= e library built, but its not working quite right.

I trie= d to send a file with sample code from=C2=A0http://www.libssh2.org/examples/sftp_write.htm= l.

This code:

/*= Request a file via SFTP */
sftp_handle =3D
libssh2_sftp_open(sftp_session, sftppath,

LIBSSH2_FXF_W= RITE | LIBSSH2_FXF_CREAT | LIBSSH2_FXF_TRUNC,
LIBSSH2_SFTP_S_IRUSR | LIBSSH2_SFTP_S_IWU= SR |
LIBSSH2= _SFTP_S_IRGRP | LIBSSH2_SFTP_S_IROTH);

if (!sftp_handle) {
fprintf(stderr, "Unable= to open file with SFTP\n");
char *error;
int errmsg_len, want_buf=3D1;
libssh2_session_last_error(session, &= amp;error, &errmsg_len, want_buf);
fprintf(stderr, "%s\n", error);
goto shutdown;
=
}
<= br>
produces this error:


=
libssh2_sftp_init()!
libssh2_sftp_open()!
Unable t= o open file with SFTP
Failed opening remote file
all do= ne

This is not a very informative message, a= nd I don't know what to do with it. I am trying to transfer from a Wind= ows 10 machine to a Raspberry Pi running Ubuntu Linux. There doesn't se= em to be any problem with the server, because I can transfer to the server = from the same Windows machine using WinSCP. There don't seem to be any = problems with directory permissions, etc.=C2=A0

An= y suggestions would be greatly appreciated.

Matthe= w Fleming




On Sun, Dec 20,= 2015 at 12:11 PM, Matthew Voss <ormris@ormris.us> wrote:
=
Do you have access to the cmake build f= ile? It should be CMakeLists.txt under the root directory. Cmake should be = able to generate all the necessary build files.

Matthew

On Decembe= r 20, 2015 9:44:57 AM PST, Matthew Fleming <mgflem@gmail.com> wrote:
Hi,=C2=A0

I'm trying to build libss= h2 for use under Windows. I am using Visual Studio Community 2015 under Win= dows 10. I tried opening the Visual Studio Solution under libssh2-1.6.0/win= . Trying to build this solution produces the following error:
1>cl : Command line error D8016: '/ZI' and '= ;/Gy-' command-line options are incompatible
2>cl : Comman= d line error D8016: '/ZI' and '/Gy-' command-line options a= re incompatible

When I remove the /ZI switch= I get this error:

=C2=A0version.c
= 1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio= .h(1925): warning C4005: 'snprintf': macro redefinition
1= > =C2=A0..\win32\libssh2_config.h(27): note: see previous definition of = 'snprintf'
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error:= =C2=A0Macro definition of snprintf conflicts with Standard Library functio= n declaration
1> =C2=A0wincng.c
1>C:\Program File= s (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdio.h(1925): warning C4= 005: 'snprintf': macro redefinition
1> =C2=A0..\win32\= libssh2_config.h(27): note: see previous definition of 'snprintf'
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\u= crt\stdio.h(1927): fatal error C1189: #error: =C2=A0Macro definition of snp= rintf conflicts with Standard Library function declaration
=
I get the same snprintf error if I use nmake.

=
Advice as to how to solve these problems would be greatly apprec= iated, thanks.

Matthew Fleming


http://cool.haxx= .se/cgi-bin/mailman/listinfo/libssh2-devel


--
Sent from my Android device with K-9 Mail. Please excuse my brevity.=

--001a1141d432f4ff2905275ae129-- --===============1749645269== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============1749645269==-- From libssh2-devel-bounces@cool.haxx.se Sun Dec 20 22:26:49 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBKLQipp014631; Sun, 20 Dec 2015 22:26:48 +0100 Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBKLQhIo014560 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 20 Dec 2015 22:26:43 +0100 Received: by mail-wm0-f47.google.com with SMTP id p187so46579203wmp.0 for ; Sun, 20 Dec 2015 13:26:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-type; bh=+qp9U/8wyHa1Juno5ffqZMlUe+QNg17C9Jn33BQOJJw=; b=WbukkQZW8coZY41GuW+psBlzLpOg8zFm+/L2IkdOTa7vWq3JsqLL6OxAjrS0pD2hr9 Anp4caRAT+gHf1/LNNXptrArluU3DNK9oZEAs4HOjbgiSUUbMlKS6JR9Sj6bNT7ky1bI Z/s9Ex+A6s3WluZGp/cgX5viGG1MhlXdWqRQnAypjJ6BTVoWyS8eKDQxg8h9PKozjYzw IlAUc1B10QLMX05WH2tD9zJ+ZD0wa99mZGeVxY0KbQNub8S58INO/ZhucZ2Izf33w06U ve0PSYmFcwYKqGuSAFstqKNm8F29Jl783pgocn0BtdTLpdf1i8YgGffLCbwtoc5o5ZUs 4miQ== X-Received: by 10.28.221.85 with SMTP id u82mr5623849wmg.95.1450646798734; Sun, 20 Dec 2015 13:26:38 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Lamaison Date: Sun, 20 Dec 2015 21:26:28 +0000 Message-ID: Subject: Removing non-CMake windows support (was Re: problems building under Windows) To: "development, libssh2" , Matthew Fleming X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0788504849==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0788504849== Content-Type: multipart/alternative; boundary=001a114b127222254b05275b0748 --001a114b127222254b05275b0748 Content-Type: text/plain; charset=UTF-8 I would like people's opinions on deleting the non-CMake windows support files. We regularly get questions from people who see the windows projects in the source and (quite reasonably) assume they are the place to go to build libssh2 on Windows. But, as we know, they don't work very well. That's why we added CMake build support. I propose that now is the right time to remove the old non-CMake files for windows support to give us one well-supported method. I believe the CMake build has worked well over the last year, and that it replaces all parts of the legacy windows support, but I'm interested to hear dissenting views. Alex --001a114b127222254b05275b0748 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I would like people's opinions on deleting the non-CMa= ke windows support files.=C2=A0

We regularly get questions from people who see the windows projects i= n the source and (quite reasonably) assume they are the place to go to buil= d libssh2 on Windows. But, as we know, they don't work very well. That&= #39;s why we added CMake build support.=C2=A0

I propose that now is the right time to remove the old = non-CMake files for windows support to give us one well-supported method. I= believe the CMake build has worked well over the last year, and that it re= places all parts of the legacy windows support, but I'm interested to h= ear dissenting views.

Alex=
--001a114b127222254b05275b0748-- --===============0788504849== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0788504849==-- From libssh2-devel-bounces@cool.haxx.se Mon Dec 21 08:19:40 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBL7JJ5o011283; Mon, 21 Dec 2015 08:19:37 +0100 Received: from mx.uxnr.de (mx.uxnr.de [89.238.84.48]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBL7JHVK011256 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 21 Dec 2015 08:19:17 +0100 Received: from [IPv6:2a02:908:a32:ed9c:5c72:a9b6:60bf:37ce] (unknown [IPv6:2a02:908:a32:ed9c:5c72:a9b6:60bf:37ce]) by mx.uxnr.de (Postfix) with ESMTPSA id 3D5631C5A377 for ; Mon, 21 Dec 2015 08:19:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.9.2 mx.uxnr.de 3D5631C5A377 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=marc-hoersken.de; s=picard; t=1450682360; bh=iU7p0Bi9/ddkAtsWyof2TSGzxVXHLoRzQkZl56tVQLA=; h=Subject:To:References:From:Date:In-Reply-To:From; b=GWvRZQLR9G2aMwmGJ4xBFjKDNN7nxf3NryDCohJtoSCZmNcJ7ZfX+ozwJhzXA1x18 lqg/h1BI8EpWKZSIcb0MpXf2BZI9UARK8xs0QyWxc2LpB4Fvsb4WXG/EsG2+uchWzb z4K9CD2E3l6gJjGQ7hPTmNFJiP9VrI85qQLx8c1s= Subject: Re: Removing non-CMake windows support (was Re: problems building under Windows) To: libssh2-devel@cool.haxx.se References: From: Marc Hoersken Message-ID: <5677A7ED.1080807@marc-hoersken.de> Date: Mon, 21 Dec 2015 08:19:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tBL7JJ5o011283 I am in favor of removing the legacy Windows builds files as long as we keep the possibility of compiling using MinGW without CMake. Am 20.12.2015 um 22:26 schrieb Alexander Lamaison: > I would like people's opinions on deleting the non-CMake windows > support files. > > We regularly get questions from people who see the windows projects in > the source and (quite reasonably) assume they are the place to go to > build libssh2 on Windows. But, as we know, they don't work very well. > That's why we added CMake build support. > > I propose that now is the right time to remove the old non-CMake files > for windows support to give us one well-supported method. I believe > the CMake build has worked well over the last year, and that it > replaces all parts of the legacy windows support, but I'm interested > to hear dissenting views. > > Alex > > > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Dec 21 11:33:24 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBLAX4fp027091; Mon, 21 Dec 2015 11:33:21 +0100 Received: from lb3-smtp-cloud2.xs4all.net (lb3-smtp-cloud2.xs4all.net [194.109.24.29]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBLAX36A026909 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Mon, 21 Dec 2015 11:33:03 +0100 Received: from xs9.xs4all.nl ([194.109.21.9]) by smtp-cloud2.xs4all.net with ESMTP id wAYy1r00U0BlZ8J01AYy4q; Mon, 21 Dec 2015 11:32:58 +0100 Received: from X220 (IDENT:12615@shell.xs4all.nl [194.109.21.9]) by xs9.xs4all.nl (8.14.4/8.14.4/Debian-4) with ESMTP id tBLAWw0U021042 for ; Mon, 21 Dec 2015 11:32:58 +0100 From: Jan Ehrhardt To: libssh2-devel@cool.haxx.se Subject: Re: Removing non-CMake windows support (was Re: problems building under Windows) Date: Mon, 21 Dec 2015 11:32:58 +0100 Message-ID: References: In-Reply-To: X-Mailer: Forte Agent 3.3/32.846 MIME-Version: 1.0 X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id tBLAX36A026909 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tBLAX4fp027091 Alexander Lamaison in gmane.network.ssh.libssh2.devel (Sun, 20 Dec 2015 21:26:28 +0000): >I would like people's opinions on deleting the non-CMake windows support >files. > >We regularly get questions from people who see the windows projects in the >source and (quite reasonably) assume they are the place to go to build >libssh2 on Windows. But, as we know, they don't work very well. That's why >we added CMake build support. The VC-projects are used for compiling libssh2 as a dependency for PHP 5 and PHP 7: https://github.com/winlibs/libssh2 I would not advice to remove them. -- Jan _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Dec 31 15:51:31 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBVEp0fu017810; Thu, 31 Dec 2015 15:51:26 +0100 Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBVEovJv017731 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 31 Dec 2015 15:50:58 +0100 Received: by mail-wm0-x232.google.com with SMTP id f206so65135034wmf.0 for ; Thu, 31 Dec 2015 06:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmgsystemsinc-com.20150623.gappssmtp.com; s=20150623; h=mime-version:date:message-id:subject:from:to:content-type; bh=ht3hCTke4yFMsaQNJXFrPNqZMYPNqYCzlw3Ctk8J8CA=; b=mW0AOjY0FXvk2YKbT1rDfOHLnyrbtyzZwQCUkqKnA9y7rMIE/WHBJy5veMOdPJwxfJ 42uqwnti3hhT3vyAUU5zdXxl1TTM/wJrla6CbEHsgkzMy/k/33FQXb4TSQ4HClnX7TOm cEunbaezNzTqNO5IVCVF+XaIVCOroWPzlD6961OerIi3+xPsb4kXnrznuMzNtp2PSMkP 3jB/B+vHJkvxZIsf3KHF6WdVeRUBVyKEjl90xCOnK8seAeRbiCpZsjblseR4ZjsiSdEz PgtAiBXeB8eV/322K99TTvUsHSrRs4qodhLstF5xrDTQj2dtJePvwh1bQv1GgYP/CznI 2ZbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=ht3hCTke4yFMsaQNJXFrPNqZMYPNqYCzlw3Ctk8J8CA=; b=aVwAwEYOFyCHZBner4iQN8e//7YMixuvhlsbXpQ0pZWpUCJ7p9slM+LnZqeBL/N+40 reO11pfYT7as75TQBaLLEdYynKHrzBsjCn+lf10FbZ8PmvH8WJK7d7NR5NKnFYWjn5lD wvUCIZuLNitv5o/UeZRx7b5BBDzBWYZf4JqdWXNOK2TXKMGejoY9hAyxfvPTvPQCTKwR l8QaSS44xkyoCSX/GVQN2n5gXlD5NvK2dBY7giL6o6X1H5ugMNMUAG2jYuHtQR70f6Ie JaZny9H63kc6+XaosvIbPetmQLo28sIFHZ7vJ7oBhyM8GTXj/fhnU5Za1fEK3iver+Hj 6x1A== X-Gm-Message-State: ALoCoQlk+Dz/TQSOynkYraZkL/gNrSdhIOA9PUpyAWn9mAP1yC/xb4C1Vlw1K1U3TvaY9LKiE11MSylKPAIDejN8Y3bb2BeEpg== MIME-Version: 1.0 X-Received: by 10.28.184.136 with SMTP id i130mr56258841wmf.96.1451573453424; Thu, 31 Dec 2015 06:50:53 -0800 (PST) Received: by 10.28.22.19 with HTTP; Thu, 31 Dec 2015 06:50:53 -0800 (PST) X-Originating-IP: [173.73.188.136] Date: Thu, 31 Dec 2015 09:50:53 -0500 Message-ID: Subject: re: Removing non-CMake windows support (was Re: problems building under Windows) From: "George Garner (online)" To: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============1537898261==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============1537898261== Content-Type: multipart/alternative; boundary=001a114b30700ea152052832c8a1 --001a114b30700ea152052832c8a1 Content-Type: text/plain; charset=UTF-8 The existing VS project files don't work out of the box. Only the debug build appear to have been tested. There is no 64-bit build. That having been said they were a convenient starting point and with 15 minutes of work I was able to get both 32 and 64-bit projects to build with the WinCNG, zlib and secure zero memory support. I did have to edit the source files in places, for example to enclose some include files with a carrot ('<') rather than double quotes ('"'), and to change the "#ifdef WIN32" to "#if defined (WIN32) || defined (WIN64)." However, on whole, the current VS project files were helpful as a starting point. My main concern is the number of warnings. Many of the warnings appear to be benign warnings about the truncation of 64-bit to 32-bit data types. The warnings that concern me the most involve the signed/unsigned mismatches and what I consider the gratuitous use of signed data types. I would look at the code around each of these warnings and verify whether there is an arithmetic operation that could produce a negative number and no check for integer underflow. I have gone through the code and made a substantial number of edits, but then I will have to do it all over again with the next release. Silencing the warnings with appropriate edits to your code would show that you care. Regards, George. --001a114b30700ea152052832c8a1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
The existing VS project files don't work out of the bo= x. Only the debug build appear to have been tested. There is no 64-bit build. That=20 having been said they were a convenient starting point and with 15=20 minutes of work I was able to get both 32 and 64-bit projects to build=20 with the WinCNG, zlib and secure zero memory support. I did have to=20 edit the source files in places, for example to enclose some include=20 files with a carrot ('<') rather than double quotes ('"= '), and to=20 change the "#ifdef WIN32" to "#if defined (WIN32) || defined= (WIN64)." =20 However, on whole, the current VS project files were helpful as a=20 starting point.

My main concern is the number of warnings. Many of = the warnings appear to be benign warnings about the truncation of 64-bit to= 32-bit data types. The warnings that concern me the most involve the sign= ed/unsigned mismatches and what I consider the gratuitous use of signed dat= a types. I would look at the code around each of these warnings and verify= whether there is an arithmetic operation that could produce a negative num= ber and no check for integer underflow.

I have gone through the code= and made a substantial number of edits, but then I will have to do it all = over again with the next release. Silencing the warnings with appropriate = edits to your code would show that you care.

Regards,

George.=
--001a114b30700ea152052832c8a1-- --===============1537898261== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============1537898261==-- From libssh2-devel-bounces@cool.haxx.se Thu Dec 31 17:10:51 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBVGAZWi027474; Thu, 31 Dec 2015 17:10:49 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id tBVGAXpn027470 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 31 Dec 2015 17:10:33 +0100 Received: (qmail 15776 invoked by uid 501); 31 Dec 2015 16:10:34 -0000 Message-ID: <20151231161034.15775.qmail@stuge.se> Date: Thu, 31 Dec 2015 17:10:34 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: Removing non-CMake windows support (was Re: problems building under Windows) Mail-Followup-To: libssh2-devel@cool.haxx.se References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id tBVGAZWi027474 Alexander Lamaison wrote: > I would like people's opinions on deleting the non-CMake windows support > files. I think it is an awful idea. Maintain a native Nmakefile and nothing else. Windows is a much simpler system than *ix and is thus much simpler to build for. Maintaining the one native Nmakefile seems worthwhile, since it is convenient for users to be able to build without first having to install the cmake scaffolding. I am against cmake in general, but that's another discussion. Regardless of whether cmake or not I think the Nmakefile is the best way to support VS. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel