Dave McCaldon wrote:
> There's still the fix for incorrect username/password in userauth.c
> that I don't think is in; here's the synopsis:
Thanks for the ping! I hope we can finally solve this now.
Fact: libssh2 does not report password authentication failure.
Fact: libssh2 reports public key authentication failure using the
error code LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED.
There seemed to be good consensus that libssh2 should not invent new
error codes but rather stay close to errors in the protocol, and the
SSH Authentication Protocol (RFC4252) does not have method-specific
So the problem we are facing is that we should actually rename
LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED to something like
LIBSSH2_ERROR_AUTHENTICATION_FAILED and use that error code for
all failed authentication attempts, regardless of the method used.
Can we do this rename? It means changing the API. We could keep a
backwards-compatible alias define and mark _PUBLICKEY_UNRECOGNIZED
as deprecated, I guess that is as good as it gets?
Received on 2010-01-15