Subject: Re: libssh2 master 204100e KEX: stop pretending we negotiate language

Re: libssh2 master 204100e KEX: stop pretending we negotiate language

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 30 Apr 2010 08:08:31 +0200 (CEST)

On Fri, 30 Apr 2010, Peter Stuge wrote:

>> There was some stub-like parts of an implementation for
>> implementing kex language negotiation that caused clang-analyzer
>> to warn and as it did nothing I've now removed the dead code.
>
> It isn't removed at all, it has just been under the cpp carpet. Please do
> actually remove the code!

I'm generally of that same opinion, but in this particular case I left it
#if 0'ed simply because the code is now easier to actually put back and to
make real use of plus it reminds the reader of that code that it doesn't
actually do the language negotiate at this point.

-- 
  / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-04-30