Subject: Re: libssh2 master 204100e KEX: stop pretending we negotiate language

Re: libssh2 master 204100e KEX: stop pretending we negotiate language

From: Peter Stuge <peter_at_stuge.se>
Date: Fri, 30 Apr 2010 00:26:38 +0200

libssh2_at_git.stuge.se wrote:
> Commit: Daniel Stenberg <daniel_at_haxx.se>
>
> KEX: stop pretending we negotiate language
>
> There was some stub-like parts of an implementation for
> implementing kex language negotiation that caused clang-analyzer
> to warn and as it did nothing I've now removed the dead code.

It isn't removed at all, it has just been under the cpp carpet.
Please do actually remove the code!

> +++ b/src/kex.c
..
> @@ -1547,6 +1547,7 @@ static int kex_agree_methods(LIBSSH2_SESSION * session, unsigned char *data,
> s += 4 + comp_cs_len;
> comp_sc_len = _libssh2_ntohu32(s);
> comp_sc = s + 4;
> +#if 0
> s += 4 + comp_sc_len;
> lang_cs_len = _libssh2_ntohu32(s);
> lang_cs = s + 4;
> @@ -1554,7 +1555,7 @@ static int kex_agree_methods(LIBSSH2_SESSION * session, unsigned char *data,
> lang_sc_len = _libssh2_ntohu32(s);
> lang_sc = s + 4;
> s += 4 + lang_sc_len;
> -
> +#endif

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-04-30