www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Add support for "signal" message channel request

Re: [PATCH] Add support for "signal" message channel request

From: Henrik Nordström <henrik_at_henriknordstrom.net>
Date: Tue, 18 Oct 2011 09:45:37 +0200

tis 2011-10-18 klockan 08:47 +0200 skrev Daniel Stenberg:
> On Tue, 18 Oct 2011, Peter Stuge wrote:
>
> > I am not advocating using numbers in the API, but to have values in an enum
> > in libssh2.h, e.g. LIBSSH2_SIGNAL_QUIT. The names should match those in the
> > RFC of course.
>
> I agree completely with this.

Note, the "signal" request is open-ended and allows for other signals to
be sent in addition to what is explicitly listed in the RFC.

For signals not defined in an SSH RFC the normal <name>@<implementer>
style is used, and for OS defined signals
<name>@<implementer>.config.guess. Additional well defined signal names
may be added in other RFCs.

I do not think the API should restrict to only RFC4254 defined signals.
Not even sure we should sanity check them.

Regards
Henrik

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2011-10-18

the libssh2 team