www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Add support for "signal" message channel request

Re: [PATCH] Add support for "signal" message channel request

From: Steven Ayre <steveayre_at_gmail.com>
Date: Tue, 18 Oct 2011 08:59:38 +0100

>
> > Since this list is search linearly, you could make it ever so slightly
> faster
> > by sorting it in decreasing order or usage frequency. That would be hard
> to
> > determine, but I'd put signal like QUIT and HUP before ones like FPE.
> It's a
> > microoptimization, but it comes for free :)
> I'd prefer to keep it in the same order as in RFC, doc file and error
> string, if you don't mind.
>

In fact it might even be better this way. QUIT should only happen once,
but ALRM could potentially happen many times so in some situations it could
be less optimal to move them earlier than the RFC states. I agree I think
it's best to keep the listed order.

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2011-10-18

the libssh2 team