www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: Patch to ticket 228

Re: Patch to ticket 228

From: Jernej Kovacic <jkovacic_at_gmail.com>
Date: Tue, 25 Oct 2011 16:42:08 +0200

Hello,

Now I have modified the function to call _libssh2_error(), converted
tabs to spaces (hopefully none have remained) and reverted the changes
in comp.c. I have also added a few important lines into the doc. file
to ensure that the function will be used properly when "asked" for
compression methods.

There are two files attached. The first is (should be) the same as in
previous post, the second is relative to it. Maybe this could be done
better but I am not very familiar with Git :(

Regards,
Jernej

On Mon, Oct 24, 2011 at 12:34 PM, Alexander Lamaison <swish_at_lammy.co.uk> wrote:
> On 23 October 2011 11:57, Jernej Kovacic <jkovacic_at_gmail.com> wrote:
>>
>> I have finally updated the patch which you can find attached.
>
> Thanks Jernej.  I have a few observations about this versions:
>
> - The changes to _libssh2_comp_methods aren't necessary now as a
> session is always used.
> - The patch introduces tabs as indentation.  These should be spaces.
> - Any API function that returns an error must call _libssh2_error to
> set the session's error state.
>
> Alex
>
> --
> Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org)
> _______________________________________________
> libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
>

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Received on 2011-10-25

the libssh2 team