www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: RE: Patch to ticket 228

RE: Patch to ticket 228

From: Mark Smith <mts-filtered_at_avcosystems.co.uk>
Date: Mon, 21 Nov 2011 11:59:53 -0000

I've just compiled the snapshot from 20111121 and MSVC6 throws a compile
warning on the LIBSSH2_FREE() call due to the const pointer; patch attached.

PS: I don't have git, this is a plain diff -u

-- 
Mark Smith
-----Original Message-----
From: libssh2-devel-bounces_at_cool.haxx.se
[mailto:libssh2-devel-bounces_at_cool.haxx.se] On Behalf Of Daniel Stenberg
Sent: 25 October 2011 23:05
To: libssh2 development
Subject: Re: Patch to ticket 228
On Tue, 25 Oct 2011, Jernej Kovacic wrote:
> Now I have modified the function to call _libssh2_error(), converted tabs
to 
> spaces (hopefully none have remained) and reverted the changes in comp.c.
I 
> have also added a few important lines into the doc. file to ensure that
the 
> function will be used properly when "asked" for compression methods.
This is better but I still wish you'd pay more attention to: trailing white 
space, source code style and line lengths. You also modified some unrelated 
lines.
See the attachment here for my edited version showing my points. I'll commit
this within shortly and then we can continue polishing it based on what we 
have in git.
I only have one comment left here: 'char ***arg' is a really unfortunate 
argument type. I bet that will scare weak-hearted users really good. The
least 
we can do is to offer an example in the man page showing how to use it...
-- 
  / daniel.haxx.se


_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Received on 2011-11-21

the libssh2 team